From: kernel test robot <lkp@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Bernard Metzler <BMT@zurich.ibm.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-rdma@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] RDMA/rxe: Pass a pointer to virt_to_page()
Date: Fri, 24 Mar 2023 20:27:59 +0800 [thread overview]
Message-ID: <202303242000.HmTaa6yB-lkp@intel.com> (raw)
In-Reply-To: <20230324103252.712107-1-linus.walleij@linaro.org>
Hi Linus,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rdma/for-next]
[also build test WARNING on linus/master v6.3-rc3 next-20230324]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Linus-Walleij/RDMA-rxe-Pass-a-pointer-to-virt_to_page/20230324-183329
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link: https://lore.kernel.org/r/20230324103252.712107-1-linus.walleij%40linaro.org
patch subject: [PATCH] RDMA/rxe: Pass a pointer to virt_to_page()
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20230324/202303242000.HmTaa6yB-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f162d87e28eb5241d1a0e2085b80bfc70f626536
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Linus-Walleij/RDMA-rxe-Pass-a-pointer-to-virt_to_page/20230324-183329
git checkout f162d87e28eb5241d1a0e2085b80bfc70f626536
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/infiniband/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303242000.HmTaa6yB-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from arch/parisc/include/asm/page.h:181,
from include/linux/mm_types_task.h:16,
from include/linux/mm_types.h:5,
from include/linux/mmzone.h:22,
from include/linux/gfp.h:7,
from include/linux/xarray.h:15,
from include/linux/list_lru.h:14,
from include/linux/fs.h:13,
from include/linux/highmem.h:5,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/bio.h:10,
from include/linux/libnvdimm.h:14,
from drivers/infiniband/sw/rxe/rxe_mr.c:7:
drivers/infiniband/sw/rxe/rxe_mr.c: In function 'rxe_set_page':
>> drivers/infiniband/sw/rxe/rxe_mr.c:216:42: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
216 | struct page *page = virt_to_page((void *)(iova & mr->page_mask));
| ^
include/asm-generic/memory_model.h:18:46: note: in definition of macro '__pfn_to_page'
18 | #define __pfn_to_page(pfn) (mem_map + ((pfn) - ARCH_PFN_OFFSET))
| ^~~
arch/parisc/include/asm/page.h:179:45: note: in expansion of macro '__pa'
179 | #define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~
drivers/infiniband/sw/rxe/rxe_mr.c:216:29: note: in expansion of macro 'virt_to_page'
216 | struct page *page = virt_to_page((void *)(iova & mr->page_mask));
| ^~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe_mr.c: In function 'rxe_mr_copy_dma':
drivers/infiniband/sw/rxe/rxe_mr.c:291:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
291 | page = virt_to_page((void *)(iova & mr->page_mask));
| ^
include/asm-generic/memory_model.h:18:46: note: in definition of macro '__pfn_to_page'
18 | #define __pfn_to_page(pfn) (mem_map + ((pfn) - ARCH_PFN_OFFSET))
| ^~~
arch/parisc/include/asm/page.h:179:45: note: in expansion of macro '__pa'
179 | #define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~
drivers/infiniband/sw/rxe/rxe_mr.c:291:24: note: in expansion of macro 'virt_to_page'
291 | page = virt_to_page((void *)(iova & mr->page_mask));
| ^~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe_mr.c: In function 'rxe_mr_do_atomic_op':
drivers/infiniband/sw/rxe/rxe_mr.c:491:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
491 | page = virt_to_page((void *)(iova & PAGE_MASK));
| ^
include/asm-generic/memory_model.h:18:46: note: in definition of macro '__pfn_to_page'
18 | #define __pfn_to_page(pfn) (mem_map + ((pfn) - ARCH_PFN_OFFSET))
| ^~~
arch/parisc/include/asm/page.h:179:45: note: in expansion of macro '__pa'
179 | #define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~
drivers/infiniband/sw/rxe/rxe_mr.c:491:24: note: in expansion of macro 'virt_to_page'
491 | page = virt_to_page((void *)(iova & PAGE_MASK));
| ^~~~~~~~~~~~
vim +216 drivers/infiniband/sw/rxe/rxe_mr.c
212
213 static int rxe_set_page(struct ib_mr *ibmr, u64 iova)
214 {
215 struct rxe_mr *mr = to_rmr(ibmr);
> 216 struct page *page = virt_to_page((void *)(iova & mr->page_mask));
217 bool persistent = !!(mr->access & IB_ACCESS_FLUSH_PERSISTENT);
218 int err;
219
220 if (persistent && !is_pmem_page(page)) {
221 rxe_dbg_mr(mr, "Page cannot be persistent\n");
222 return -EINVAL;
223 }
224
225 if (unlikely(mr->nbuf == mr->num_buf))
226 return -ENOMEM;
227
228 err = xa_err(xa_store(&mr->page_list, mr->nbuf, page, GFP_KERNEL));
229 if (err)
230 return err;
231
232 mr->nbuf++;
233 return 0;
234 }
235
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-24 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 10:32 [PATCH] RDMA/rxe: Pass a pointer to virt_to_page() Linus Walleij
2023-03-24 12:27 ` kernel test robot [this message]
2023-03-24 13:59 ` Jason Gunthorpe
2023-03-29 14:28 ` Linus Walleij
2023-03-29 20:17 ` Bob Pearson
2023-03-29 23:16 ` Jason Gunthorpe
2023-03-30 2:45 ` Bob Pearson
2023-03-30 12:06 ` Jason Gunthorpe
2023-03-30 15:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303242000.HmTaa6yB-lkp@intel.com \
--to=lkp@intel.com \
--cc=BMT@zurich.ibm.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.