From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E72C76195 for ; Mon, 27 Mar 2023 12:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232369AbjC0Mpp (ORCPT ); Mon, 27 Mar 2023 08:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbjC0Mpn (ORCPT ); Mon, 27 Mar 2023 08:45:43 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 378D14200 for ; Mon, 27 Mar 2023 05:45:43 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id l7so7540651pjg.5 for ; Mon, 27 Mar 2023 05:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679921142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/7HUQqjeCU9xxuess/BilVQvbPRHx3dfJR9GG39px60=; b=UOf308ory3UnOGfi0PppTTQd7l5iXDJJXOaxA6/53htATAsUcWi/We6wwXVeHhDadl KR/XXgSVvCNdsEarceCq6hKlDXUjc7G9tfM+vJwi/rCfFx24jmfUK/ZtHA6uNMniaUsv /goXX4MzK+JVFCPD9SdTSSYPzyb5MFPzgameZzb8EWG7BCHFNJ4Im917gz4iDZrDZECG PH1EPumyz1rGjxgDmnj5n37JeFxGm/5ayABe+bU5v6RReWvOIqfYLDSguYSeAu06P/cC dgNkntx+cOn6Hh/eZXt/6HpfRFzOOe+XjcGOXOeHpu4JJtQKkK1vNZjYcKXbO5LGswok 3uxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679921142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/7HUQqjeCU9xxuess/BilVQvbPRHx3dfJR9GG39px60=; b=JfmEVYnTzFCd2X89zdxcvDh92hCGZJ7sKICzOrUmSb/3RrSemelHmMJQ/ZKvhDW6xD vGdV1Qit/7LZZCjei2KFBcY6YM2Yrtm0ah5CVq3Rn2rfPFlHGL6kO51rwDAy7up9S5AN nRxmqBvX6ob442SvQ0JKhuYZvqkHXntIiLf9gLj/nbfzKDOzuGaqWFSirTxq48X22RrC yCUJVKzvww58vlLcWU6f+VroQH+AnBon21MH2L6PGDWDE+HD0y8sU4qkqa4Zl1MfEP+T mdqP+PRl3gkUNPP8MQj1I6X2HH2KGAZTRDpWkhtlZ6fRLaUyDHvE576AfHE919Onul3I eY7A== X-Gm-Message-State: AAQBX9eq7HfcL3WTo0i3bn8lcsg0G6yGZAoHI8IU69E6CY/V1J4cLNUF WDg1g6Z1dyMJtGH5utP5K1I0gnI7mJM= X-Google-Smtp-Source: AKy350ZlpykYBDTbMnh8Zc7cbnq84TrAxlt+o7ve/mqys3lx8wvRjCBSVzF465oCXKa02Ccfxeu3JA== X-Received: by 2002:a17:902:e5c8:b0:19f:8bbf:9c56 with SMTP id u8-20020a170902e5c800b0019f8bbf9c56mr13752162plf.3.1679921142323; Mon, 27 Mar 2023 05:45:42 -0700 (PDT) Received: from bobo.ozlabs.ibm.com ([203.221.180.225]) by smtp.gmail.com with ESMTPSA id ay6-20020a1709028b8600b0019a997bca5csm19053965plb.121.2023.03.27.05.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 05:45:41 -0700 (PDT) From: Nicholas Piggin To: kvm@vger.kernel.org Cc: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Laurent Vivier , Thomas Huth Subject: [kvm-unit-tests v3 03/13] powerpc: Add some checking to exception handler install Date: Mon, 27 Mar 2023 22:45:10 +1000 Message-Id: <20230327124520.2707537-4-npiggin@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230327124520.2707537-1-npiggin@gmail.com> References: <20230327124520.2707537-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Check to ensure exception handlers are not being overwritten or invalid exception numbers are used. Signed-off-by: Nicholas Piggin --- Since v2: - New patch lib/powerpc/processor.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/powerpc/processor.c b/lib/powerpc/processor.c index ec85b9d..70391aa 100644 --- a/lib/powerpc/processor.c +++ b/lib/powerpc/processor.c @@ -19,11 +19,23 @@ static struct { void handle_exception(int trap, void (*func)(struct pt_regs *, void *), void * data) { + if (trap & 0xff) { + printf("invalid exception handler %#x\n", trap); + abort(); + } + trap >>= 8; if (trap < 16) { + if (func && handlers[trap].func) { + printf("exception handler installed twice %#x\n", trap); + abort(); + } handlers[trap].func = func; handlers[trap].data = data; + } else { + printf("invalid exception handler %#x\n", trap); + abort(); } } -- 2.37.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29FAFC7619A for ; Mon, 27 Mar 2023 12:49:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PlXgt4RQrz3fZN for ; Mon, 27 Mar 2023 23:49:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=UOf308or; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62e; helo=mail-pl1-x62e.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=UOf308or; dkim-atps=neutral Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PlXbr4lqyz3bh5 for ; Mon, 27 Mar 2023 23:45:44 +1100 (AEDT) Received: by mail-pl1-x62e.google.com with SMTP id ix20so8320148plb.3 for ; Mon, 27 Mar 2023 05:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679921142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/7HUQqjeCU9xxuess/BilVQvbPRHx3dfJR9GG39px60=; b=UOf308ory3UnOGfi0PppTTQd7l5iXDJJXOaxA6/53htATAsUcWi/We6wwXVeHhDadl KR/XXgSVvCNdsEarceCq6hKlDXUjc7G9tfM+vJwi/rCfFx24jmfUK/ZtHA6uNMniaUsv /goXX4MzK+JVFCPD9SdTSSYPzyb5MFPzgameZzb8EWG7BCHFNJ4Im917gz4iDZrDZECG PH1EPumyz1rGjxgDmnj5n37JeFxGm/5ayABe+bU5v6RReWvOIqfYLDSguYSeAu06P/cC dgNkntx+cOn6Hh/eZXt/6HpfRFzOOe+XjcGOXOeHpu4JJtQKkK1vNZjYcKXbO5LGswok 3uxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679921142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/7HUQqjeCU9xxuess/BilVQvbPRHx3dfJR9GG39px60=; b=lr1eVC/3835JNN5Pog2VhynvZagvfp06WDqo49UCW60R18ma1t3SXuQ8ClmY2lTFer HR50rsiZ9Rjpd7zijc1RIuMjCa1QK51ec1FGbhrIjz/ilj8EhmkeVCcLqqV+xzKU67Gk ssvc1oG4YejQvCIzEWZ8eZlbrXSeJzcH8kOyhPU7V5OE6LWPQnzaQhgc+Slk5tYjWFBv aIwC1ae/T5y98t8OucJKxf7k/KjJPFUPYZI5YjfFIR2WuYUEgYCpjwOgOHawag+exkhf i4D5yiubJAJMVKWiaxpKe+1Mf1j+AipJPCwAad9ZJCCQb+5yuFahtdbmCjAoR5MEQDVT ZZCQ== X-Gm-Message-State: AAQBX9fb+30eI9c7kNnLQWyr+MEGsN1dPdy+Ot2HpZI0oWP+dNJEzBFt BZO2q2Au4QzGMl2BEbEHJmI= X-Google-Smtp-Source: AKy350ZlpykYBDTbMnh8Zc7cbnq84TrAxlt+o7ve/mqys3lx8wvRjCBSVzF465oCXKa02Ccfxeu3JA== X-Received: by 2002:a17:902:e5c8:b0:19f:8bbf:9c56 with SMTP id u8-20020a170902e5c800b0019f8bbf9c56mr13752162plf.3.1679921142323; Mon, 27 Mar 2023 05:45:42 -0700 (PDT) Received: from bobo.ozlabs.ibm.com ([203.221.180.225]) by smtp.gmail.com with ESMTPSA id ay6-20020a1709028b8600b0019a997bca5csm19053965plb.121.2023.03.27.05.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 05:45:41 -0700 (PDT) From: Nicholas Piggin To: kvm@vger.kernel.org Subject: [kvm-unit-tests v3 03/13] powerpc: Add some checking to exception handler install Date: Mon, 27 Mar 2023 22:45:10 +1000 Message-Id: <20230327124520.2707537-4-npiggin@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230327124520.2707537-1-npiggin@gmail.com> References: <20230327124520.2707537-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Check to ensure exception handlers are not being overwritten or invalid exception numbers are used. Signed-off-by: Nicholas Piggin --- Since v2: - New patch lib/powerpc/processor.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/powerpc/processor.c b/lib/powerpc/processor.c index ec85b9d..70391aa 100644 --- a/lib/powerpc/processor.c +++ b/lib/powerpc/processor.c @@ -19,11 +19,23 @@ static struct { void handle_exception(int trap, void (*func)(struct pt_regs *, void *), void * data) { + if (trap & 0xff) { + printf("invalid exception handler %#x\n", trap); + abort(); + } + trap >>= 8; if (trap < 16) { + if (func && handlers[trap].func) { + printf("exception handler installed twice %#x\n", trap); + abort(); + } handlers[trap].func = func; handlers[trap].data = data; + } else { + printf("invalid exception handler %#x\n", trap); + abort(); } } -- 2.37.2