From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B45AAC77B61 for ; Mon, 27 Mar 2023 17:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231934AbjC0RxG (ORCPT ); Mon, 27 Mar 2023 13:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232207AbjC0RxE (ORCPT ); Mon, 27 Mar 2023 13:53:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ADF2170A; Mon, 27 Mar 2023 10:52:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F159E61460; Mon, 27 Mar 2023 17:52:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AABAC433EF; Mon, 27 Mar 2023 17:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679939578; bh=YUjw6HS7Ov0YlFJ936LcRdxbHpWylAOUWlXSpvo0Xus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T1MN3jBV0gb+UwCkF0T7VQ2Ufwhk5sPD+iei9Q9lOdNqlJoDm/Jo6HfJgg4rwrgW0 GI1bYD1pNH+oxApvz0AbaIniEKaVLTOSgflI6HGGB2+wNb5tViDNcxVNYJGbdAazK1 1mgRzjxvV23vJ/1IxjAInTfWzvNPo90/vLbV+jFu0KxC+ZQ+SInWb2AwBgiVdZ3GB3 z0C7NOxbWq5xKDXm65qsQymYFsNwMWWtGmrHUJ0IwlHktznE5yQs33J+z9Yx+IMS6F 2zVBD3c6pn6GsiooTVy02KA/pWscHe3Bs1X9n0HXD753oNUjN7TQS267UNSbWk2TZN F1OfRaOGTSjMQ== Date: Mon, 27 Mar 2023 10:52:55 -0700 From: Eric Biggers To: Abel Vesa Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Adrian Hunter , "James E . J . Bottomley" , "Martin K . Petersen" , Herbert Xu , "David S . Miller" , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: mmc: sdhci-msm: Add ICE phandle Message-ID: <20230327175255.GB1882@sol.localdomain> References: <20230327134734.3256974-1-abel.vesa@linaro.org> <20230327134734.3256974-3-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327134734.3256974-3-abel.vesa@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Mar 27, 2023 at 04:47:29PM +0300, Abel Vesa wrote: > Starting with SM8550, the ICE will have its own devicetree node > so add the qcom,ice property to reference it. > > Signed-off-by: Abel Vesa > --- > > The v3 (RFC) is here: > https://lore.kernel.org/all/20230313115202.3960700-3-abel.vesa@linaro.org/ > > Changes since v3: > * dropped the "and drop core clock" part from subject line > > Changes since v2: > * dropped all changes except the qcom,ice property > > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > index 64df6919abaf..0ad14d5b722e 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > @@ -120,6 +120,10 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: platform specific settings for DLL_CONFIG reg. > > + qcom,ice: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the Inline Crypto Engine node > + It would be helpful if the description was more detailed and explained that this is a replacement for the directly specified reg and clock. Otherwise, looks good to me. Reviewed-by: Eric Biggers - Eric