From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851AFC76195 for ; Tue, 28 Mar 2023 07:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbjC1Hdl (ORCPT ); Tue, 28 Mar 2023 03:33:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230432AbjC1Hdb (ORCPT ); Tue, 28 Mar 2023 03:33:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4756C1991 for ; Tue, 28 Mar 2023 00:33:23 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ph3pI-0007rq-AC; Tue, 28 Mar 2023 09:33:04 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ph3pG-0008R5-Pv; Tue, 28 Mar 2023 09:33:02 +0200 Date: Tue, 28 Mar 2023 09:33:02 +0200 From: Marco Felsch To: Greg Ungerer Cc: Ahmad Fatoum , peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, Markus.Niebel@ew.tq-group.com, paul.elder@ideasonboard.com, gerg@kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, l.stach@pengutronix.de, shawnguo@kernel.org, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Message-ID: <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 23-03-27, Greg Ungerer wrote: > Hi Ahmad, > > On 27/3/23 17:16, Ahmad Fatoum wrote: > > On 27.03.23 08:27, Alexander Stein wrote: > > > Am Montag, 27. März 2023, 06:50:37 CEST schrieb Greg Ungerer: > > > > Any thoughts on why this breaks USB? > > > > > > Maybe you are missing CONFIG_INTERCONNECT_IMX8MP? > > > > And if that's the case, did you check /sys/kernel/debug/devices_deferred > > to see if there was any indication that this is the reason? > > Yeah, it does: > > # cat /sys/kernel/debug/devices_deferred > 32f10100.usb platform: supplier 32f10000.blk-ctrl not ready > 32f10108.usb platform: supplier 32f10000.blk-ctrl not ready > 32ec0000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries > 381f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > 382f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > imx-pgc-domain.11 > imx-pgc-domain.12 > imx-pgc-domain.13 > 38330000.blk-ctrl platform: supplier imx-pgc-domain.11 not ready > 32f10000.blk-ctrl imx8mp-blk-ctrl: failed to get noc entries > > As far as I can tell blk-ctrl should be good: > > # > # i.MX SoC drivers > # > CONFIG_IMX_GPCV2_PM_DOMAINS=y > CONFIG_SOC_IMX8M=y > # CONFIG_SOC_IMX9 is not set > CONFIG_IMX8M_BLK_CTRL=y > # end of i.MX SoC drivers > > > > If you didn't find any hint there, you might want to place a > > dev_err_probe with a suitable message at the place where -EPROBE_DEFER > > was returned. > > I will try that. Can you check that CONFIG_ARM_IMX_BUS_DEVFREQ is enabled? This is the noc/interconnect driver. This could also the problem for you vpu issue. Regards, Marco > > Thanks > Greg > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EDB6C76195 for ; Tue, 28 Mar 2023 07:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S25mJP9m5+reTnOK48CC/eZvfUWf9xmvODLhMqGLXYg=; b=Jtzm3jY8V0LTmP JP6yo33r9T36TbYhN1857gRnOAablxE7BrdToLJ0J8+YjQ4PW0UjXqVYxFpu8wlIvLW+a0X6rA1z+ n9UFSHakO8ewwaRzx+zoAISh/gk6kV0j2cs+gWFdog+GzRI8i28XhKAb7ja2y1Hrlu0UUWxiiGUCZ RtfEybKBL5zYo1zBtJpRHtMrRhETxBApm3oq9diq226SpVIB1LK8Yps6nLh4n1ZnNXNjGtw48eh2w vpDSuh/LInWH5t4FQNyWDJxshBH45/OR6pLgPgtUFD3cNilLRM8U+grzKlNPie0uPrPZc3+Ei3l4O mPFvE3kGQXL+5ukYDsng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph3pW-00DSEM-17; Tue, 28 Mar 2023 07:33:18 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph3pT-00DSCw-01 for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 07:33:16 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ph3pI-0007rq-AC; Tue, 28 Mar 2023 09:33:04 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ph3pG-0008R5-Pv; Tue, 28 Mar 2023 09:33:02 +0200 Date: Tue, 28 Mar 2023 09:33:02 +0200 From: Marco Felsch To: Greg Ungerer Cc: Ahmad Fatoum , peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, Markus.Niebel@ew.tq-group.com, paul.elder@ideasonboard.com, gerg@kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, l.stach@pengutronix.de, shawnguo@kernel.org, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Message-ID: <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_003315_043581_1E012AD9 X-CRM114-Status: GOOD ( 22.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Greg, On 23-03-27, Greg Ungerer wrote: > Hi Ahmad, > = > On 27/3/23 17:16, Ahmad Fatoum wrote: > > On 27.03.23 08:27, Alexander Stein wrote: > > > Am Montag, 27. M=E4rz 2023, 06:50:37 CEST schrieb Greg Ungerer: > > > > Any thoughts on why this breaks USB? > > > = > > > Maybe you are missing CONFIG_INTERCONNECT_IMX8MP? > > = > > And if that's the case, did you check /sys/kernel/debug/devices_deferred > > to see if there was any indication that this is the reason? > = > Yeah, it does: > = > # cat /sys/kernel/debug/devices_deferred > 32f10100.usb platform: supplier 32f10000.blk-ctrl not ready > 32f10108.usb platform: supplier 32f10000.blk-ctrl not ready > 32ec0000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries > 381f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > 382f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready > imx-pgc-domain.11 = > imx-pgc-domain.12 = > imx-pgc-domain.13 = > 38330000.blk-ctrl platform: supplier imx-pgc-domain.11 not ready > 32f10000.blk-ctrl imx8mp-blk-ctrl: failed to get noc entries > = > As far as I can tell blk-ctrl should be good: > = > # > # i.MX SoC drivers > # > CONFIG_IMX_GPCV2_PM_DOMAINS=3Dy > CONFIG_SOC_IMX8M=3Dy > # CONFIG_SOC_IMX9 is not set > CONFIG_IMX8M_BLK_CTRL=3Dy > # end of i.MX SoC drivers > = > = > > If you didn't find any hint there, you might want to place a > > dev_err_probe with a suitable message at the place where -EPROBE_DEFER > > was returned. > = > I will try that. Can you check that CONFIG_ARM_IMX_BUS_DEVFREQ is enabled? This is the noc/interconnect driver. This could also the problem for you vpu issue. Regards, Marco > = > Thanks > Greg > = > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel