From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BFAC6FD18 for ; Tue, 28 Mar 2023 14:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbjC1ODR (ORCPT ); Tue, 28 Mar 2023 10:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbjC1OC6 (ORCPT ); Tue, 28 Mar 2023 10:02:58 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF392CC07 for ; Tue, 28 Mar 2023 07:01:46 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id CB45B6001E; Tue, 28 Mar 2023 14:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680012098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajebor2cex6mpQmPcqQgjjD0LTwwf/mMcc5v184iISI=; b=ZAIpBrc0V73yhIwZQdNSHbg3F6MObzE0GnIXlzghrmbaIRbhy1VGnMsN5SSKJvjFuVfMMQ fTZQIvi+2hJ80IprvkwGAujDIJ34xGLjPMptRSAdXS3nYFaxw2FZBdcrRvRwqR820xv5bS bc7OwQfWMVRz2c1pemi7eKMJgDBJQRIuTsluK3uSUhMQp8EEWAtGhRNP8MxGEcJy2mDhli R81Y9TAl9tJBUqVNlXvEjpzqBwnOD0EEnJGANkjl+pzZJpdbXC0y3ip3WSlbrnFwFZy1pK sPG3TIOJDD+KpGETKaT2ZrRVy0Xk7iEdkbtMb7BbywcHKMIVwbQDlzLlZlCy+g== Date: Tue, 28 Mar 2023 16:01:35 +0200 From: Miquel Raynal To: Christophe Kerello Cc: Tudor Ambarus , , , , , Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Message-ID: <20230328160135.06ef6e50@xps-13> In-Reply-To: <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> References: <20230327094742.38856-1-christophe.kerello@foss.st.com> <20230327094742.38856-3-christophe.kerello@foss.st.com> <75dcd205-5432-7103-370c-d65d792631ea@linaro.org> <20230327124313.1ccd3d66@xps-13> <70d0a8b6-62c2-fa3e-df5c-f86ba75484d0@linaro.org> <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, christophe.kerello@foss.st.com wrote on Tue, 28 Mar 2023 09:27:55 +0200: > Hello Miquel, >=20 > On 3/27/23 13:06, Tudor Ambarus wrote: > >=20 > >=20 > > On 3/27/23 11:43, Miquel Raynal wrote: =20 > >> Hi Tudor, > >> > >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: > >> =20 > >>> On 3/27/23 10:47, Christophe Kerello wrote: =20 > >>>> This patch is using timings.mode value instead of checking tRC_min t= iming > >>>> for EDO mode support. =20 > >>>> >>> =20 > >>> Fixes and Cc to stable here too, as you'd like to have this backported > >>> as well, don't you? =20 > >> > >> Actually the reason why Christophe split this into two patches is > >> because timings.mode was introduced rather lately, he wanted the same > >> patch to apply on all stable kernels, he actually asked for that split > >> and I agreed (another solution would have been to send this current > >> patch to Linus and have the other version sent to stable, but it > >> requires a bit of scheduling on both ends). > >> > >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13= /T/#t =20 > >=20 > > Right, I understood that from the beginning. If it were to me, I would > > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > > Cc: stable@vger.kernel.org #v5.10+ for the second. > >=20 > > So first would be alone just in v5.4, and starting with v5.10 we'll have > > both and we'll mimic what we currently have in upstream mainline. > > =20 >=20 > I can send a V3 with cc tag added as per Tudor's suggestion. > Or cc tag will be added when the patches will be applied? Actually I have other fixes to queue early next week, so can you please send a v3 with the tags discussed with Tudor? Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97B3CC6FD18 for ; Tue, 28 Mar 2023 14:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hyU4EXJTYuLCBjS7AUdvXyDN721u9Hu341xHPQ3FaQk=; b=ru5iVsyLMjnzc4 SQorqZgsjvKUw0/8zwoMI9TDbXU8k6Ohcnr0Q5FfHq0hPeSioncXEBDMExiPxEcPaQzwb9ptnQaZ/ F2nUTpPc5HFEuxldGUbZdsvBmWeconwdpLCLijdvrWJyVSOmJOxs2+U7NPXFaKc0RAqVDRu2uTS/E i7Y0nzYLDjWBPsBSU5TjjpzsZkbo7Tyc4ctwW9outym42HfV0mlbfzW18GdIEvGGNswuwD/PHqyzK /jwdBi+IGJp9UCs9wSWJVMWIAO3qlABOmrdYPjDGrEBBq41bMYGYGxkC7r1I2zU/RzYyvYuqIStFl sIjasK8tzlVnfUAOuYFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph9tW-00EitD-1A; Tue, 28 Mar 2023 14:01:50 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph9tP-00Eiqv-1X for linux-mtd@lists.infradead.org; Tue, 28 Mar 2023 14:01:48 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id CB45B6001E; Tue, 28 Mar 2023 14:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680012098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajebor2cex6mpQmPcqQgjjD0LTwwf/mMcc5v184iISI=; b=ZAIpBrc0V73yhIwZQdNSHbg3F6MObzE0GnIXlzghrmbaIRbhy1VGnMsN5SSKJvjFuVfMMQ fTZQIvi+2hJ80IprvkwGAujDIJ34xGLjPMptRSAdXS3nYFaxw2FZBdcrRvRwqR820xv5bS bc7OwQfWMVRz2c1pemi7eKMJgDBJQRIuTsluK3uSUhMQp8EEWAtGhRNP8MxGEcJy2mDhli R81Y9TAl9tJBUqVNlXvEjpzqBwnOD0EEnJGANkjl+pzZJpdbXC0y3ip3WSlbrnFwFZy1pK sPG3TIOJDD+KpGETKaT2ZrRVy0Xk7iEdkbtMb7BbywcHKMIVwbQDlzLlZlCy+g== Date: Tue, 28 Mar 2023 16:01:35 +0200 From: Miquel Raynal To: Christophe Kerello Cc: Tudor Ambarus , , , , , Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Message-ID: <20230328160135.06ef6e50@xps-13> In-Reply-To: <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> References: <20230327094742.38856-1-christophe.kerello@foss.st.com> <20230327094742.38856-3-christophe.kerello@foss.st.com> <75dcd205-5432-7103-370c-d65d792631ea@linaro.org> <20230327124313.1ccd3d66@xps-13> <70d0a8b6-62c2-fa3e-df5c-f86ba75484d0@linaro.org> <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_070143_658137_867D1E4A X-CRM114-Status: GOOD ( 20.97 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoZSwKCmNocmlzdG9waGUua2VyZWxsb0Bmb3NzLnN0LmNvbSB3cm90ZSBvbiBU dWUsIDI4IE1hciAyMDIzIDA5OjI3OjU1ICswMjAwOgoKPiBIZWxsbyBNaXF1ZWwsCj4gCj4gT24g My8yNy8yMyAxMzowNiwgVHVkb3IgQW1iYXJ1cyB3cm90ZToKPiA+IAo+ID4gCj4gPiBPbiAzLzI3 LzIzIDExOjQzLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4gSGkgVHVkb3IsCj4gPj4KPiA+ PiB0dWRvci5hbWJhcnVzQGxpbmFyby5vcmcgd3JvdGUgb24gTW9uLCAyNyBNYXIgMjAyMyAxMToz MDo1MSArMDEwMDoKPiA+PiAgCj4gPj4+IE9uIDMvMjcvMjMgMTA6NDcsIENocmlzdG9waGUgS2Vy ZWxsbyB3cm90ZTogIAo+ID4+Pj4gVGhpcyBwYXRjaCBpcyB1c2luZyB0aW1pbmdzLm1vZGUgdmFs dWUgaW5zdGVhZCBvZiBjaGVja2luZyB0UkNfbWluIHRpbWluZwo+ID4+Pj4gZm9yIEVETyBtb2Rl IHN1cHBvcnQuICAKPiA+Pj4+ICAgID4+PiAgCj4gPj4+IEZpeGVzIGFuZCBDYyB0byBzdGFibGUg aGVyZSB0b28sIGFzIHlvdSdkIGxpa2UgdG8gaGF2ZSB0aGlzIGJhY2twb3J0ZWQKPiA+Pj4gYXMg d2VsbCwgZG9uJ3QgeW91PyAgCj4gPj4KPiA+PiBBY3R1YWxseSB0aGUgcmVhc29uIHdoeSBDaHJp c3RvcGhlIHNwbGl0IHRoaXMgaW50byB0d28gcGF0Y2hlcyBpcwo+ID4+IGJlY2F1c2UgdGltaW5n cy5tb2RlIHdhcyBpbnRyb2R1Y2VkIHJhdGhlciBsYXRlbHksIGhlIHdhbnRlZCB0aGUgc2FtZQo+ ID4+IHBhdGNoIHRvIGFwcGx5IG9uIGFsbCBzdGFibGUga2VybmVscywgaGUgYWN0dWFsbHkgYXNr ZWQgZm9yIHRoYXQgc3BsaXQKPiA+PiBhbmQgSSBhZ3JlZWQgKGFub3RoZXIgc29sdXRpb24gd291 bGQgaGF2ZSBiZWVuIHRvIHNlbmQgdGhpcyBjdXJyZW50Cj4gPj4gcGF0Y2ggdG8gTGludXMgYW5k IGhhdmUgdGhlIG90aGVyIHZlcnNpb24gc2VudCB0byBzdGFibGUsIGJ1dCBpdAo+ID4+IHJlcXVp cmVzIGEgYml0IG9mIHNjaGVkdWxpbmcgb24gYm90aCBlbmRzKS4KPiA+Pgo+ID4+IExpbms6IGh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW10ZC8yMDIzMDMyNzEwMTE1Ni4wZWMyODE2YUB4 cHMtMTMvVC8jdCAgCj4gPiAKPiA+IFJpZ2h0LCBJIHVuZGVyc3Rvb2QgdGhhdCBmcm9tIHRoZSBi ZWdpbm5pbmcuIElmIGl0IHdlcmUgdG8gbWUsIEkgd291bGQKPiA+IENjOiBzdGFibGVAdmdlci5r ZXJuZWwub3JnICN2NS40KyBmb3IgdGhlIGZpcnN0IHBhdGNoIGFuZAo+ID4gQ2M6IHN0YWJsZUB2 Z2VyLmtlcm5lbC5vcmcgI3Y1LjEwKyBmb3IgdGhlIHNlY29uZC4KPiA+IAo+ID4gU28gZmlyc3Qg d291bGQgYmUgYWxvbmUganVzdCBpbiB2NS40LCBhbmQgc3RhcnRpbmcgd2l0aCB2NS4xMCB3ZSds bCBoYXZlCj4gPiBib3RoIGFuZCB3ZSdsbCBtaW1pYyB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGlu IHVwc3RyZWFtIG1haW5saW5lLgo+ID4gICAKPiAKPiBJIGNhbiBzZW5kIGEgVjMgd2l0aCBjYyB0 YWcgYWRkZWQgYXMgcGVyIFR1ZG9yJ3Mgc3VnZ2VzdGlvbi4KPiBPciBjYyB0YWcgd2lsbCBiZSBh ZGRlZCB3aGVuIHRoZSBwYXRjaGVzIHdpbGwgYmUgYXBwbGllZD8KCkFjdHVhbGx5IEkgaGF2ZSBv dGhlciBmaXhlcyB0byBxdWV1ZSBlYXJseSBuZXh0IHdlZWssIHNvIGNhbiB5b3UgcGxlYXNlCnNl bmQgYSB2MyB3aXRoIHRoZSB0YWdzIGRpc2N1c3NlZCB3aXRoIFR1ZG9yPwoKVGhhbmtzLApNaXF1 w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=