All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] docs/manual: ditch redundant -f 'rm' flag
Date: Tue, 28 Mar 2023 21:38:49 +0200	[thread overview]
Message-ID: <20230328193849.GB3204460@scaer> (raw)
In-Reply-To: <20230327141122.103829-2-luca.ceresoli@bootlin.com>

Luca, All,

On 2023-03-27 16:11 +0200, Luca Ceresoli spake thusly:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant. Avoid it on the docs to avoid developers taking it as a good
> example to follow.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Applied to master, thanks.

Will you send a tree-wide cleanup, now? ;-)

    $ git grep -E '\$\(RM\) -r?f' |wc -l
    47

Regards,
Yann E. MORIN.

> ---
>  docs/manual/writing-rules.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/manual/writing-rules.txt b/docs/manual/writing-rules.txt
> index 758965d80a0a..13b7fd5bea6a 100644
> --- a/docs/manual/writing-rules.txt
> +++ b/docs/manual/writing-rules.txt
> @@ -78,7 +78,7 @@ Do not align the +=+ signs.
>  +
>  ---------------------
>  define LIBFOO_REMOVE_DOC
> -	$(RM) -fr $(TARGET_DIR)/usr/share/libfoo/doc \
> +	$(RM) -r $(TARGET_DIR)/usr/share/libfoo/doc \
>  		$(TARGET_DIR)/usr/share/man/man3/libfoo*
>  endef
>  ---------------------
> @@ -118,7 +118,7 @@ YES:
>  ---------------------
>  ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
>  define LIBFOO_REMOVE_DATA
> -	$(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
> +	$(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
>  endef
>  LIBFOO_POST_INSTALL_TARGET_HOOKS += LIBFOO_REMOVE_DATA
>  endif
> @@ -128,7 +128,7 @@ NO:
>  +
>  ---------------------
>  define LIBFOO_REMOVE_DATA
> -	$(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
> +	$(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
>  endef
>  
>  ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
> -- 
> 2.34.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-03-28 19:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
2023-03-28 19:38   ` Yann E. MORIN [this message]
2023-03-29  6:43     ` Luca Ceresoli via buildroot
2023-04-10 19:24   ` Peter Korsgaard
2023-03-28 19:37 ` [Buildroot] [PATCH 1/2] package/linux-tools: perf: " Yann E. MORIN
2023-04-10 19:24 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328193849.GB3204460@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=thomas.de_schampheleire@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.