From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH 2/5] objtool: Combine '--backtrace' with '--verbose'
Date: Tue, 28 Mar 2023 13:19:21 -0700 [thread overview]
Message-ID: <20230328201921.ccl7p65le5aysa6j@treble> (raw)
In-Reply-To: <20230328080743.GC4253@hirez.programming.kicks-ass.net>
On Tue, Mar 28, 2023 at 10:07:43AM +0200, Peter Zijlstra wrote:
> On Mon, Mar 27, 2023 at 09:00:45AM -0700, Josh Poimboeuf wrote:
> > Get rid of the '--backtrace' option, instead including that
> > functionality in '--verbose'. This makes it easy to gather all the
> > information needed for diagnosing objtool warnings.
>
> Hurmm.. can't we have verbose imply backtrace but keep the separate
> option? I'm not sure if I always want the objdump thing -- esp with
> multiple warnings on vmlinux that's going to be really slow -- better to
> dump the whole of vmlinux.o once at the end.
That's a good point, vmlinux would be unbearable for multiple warnings.
We could accumulate a list of affected functions and then supply that to
objdump-func.sh at the end and dump them all at the same time.
objdump-func.sh would need to be changed to look for multiple funcs at
once.
If I do that, do you still want the separate backtrace option?
--
Josh
next prev parent reply other threads:[~2023-03-28 20:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:00 [PATCH 0/5] objtool: warning improvements Josh Poimboeuf
2023-03-27 16:00 ` [PATCH 1/5] objtool: Add '--verbose' option for disassembling affected functions Josh Poimboeuf
2023-03-28 8:47 ` Miroslav Benes
2023-03-27 16:00 ` [PATCH 2/5] objtool: Combine '--backtrace' with '--verbose' Josh Poimboeuf
2023-03-28 8:07 ` Peter Zijlstra
2023-03-28 20:19 ` Josh Poimboeuf [this message]
2023-03-29 7:25 ` Peter Zijlstra
2023-03-27 16:00 ` [PATCH 3/5] objtool: Remove superfluous dead_end_function() check Josh Poimboeuf
2023-03-27 16:00 ` [PATCH 4/5] objtool: Add per-function rate limiting for unreachable warnings Josh Poimboeuf
2023-03-28 8:11 ` Peter Zijlstra
2023-03-28 20:22 ` Josh Poimboeuf
2023-03-29 7:26 ` Peter Zijlstra
2023-03-28 9:07 ` Miroslav Benes
2023-03-27 16:00 ` [PATCH 5/5] objtool: Add "missing __noreturn" warning Josh Poimboeuf
2023-03-28 9:10 ` Miroslav Benes
2023-03-29 16:24 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328201921.ccl7p65le5aysa6j@treble \
--to=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.