From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F715C77B62 for ; Wed, 29 Mar 2023 23:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbjC2X4V (ORCPT ); Wed, 29 Mar 2023 19:56:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbjC2X4U (ORCPT ); Wed, 29 Mar 2023 19:56:20 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C1C1FD2; Wed, 29 Mar 2023 16:56:19 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id EB42C68C7B; Thu, 30 Mar 2023 01:56:15 +0200 (CEST) Date: Thu, 30 Mar 2023 01:56:15 +0200 From: Christoph Hellwig To: Andrew Morton Cc: Christoph Hellwig , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: return an ERR_PTR from __filemap_get_folio v2 Message-ID: <20230329235615.GA2012@lst.de> References: <20230121065755.1140136-1-hch@lst.de> <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Mar 28, 2023 at 04:04:33PM -0700, Andrew Morton wrote: > > Note that the shmem patches in here are non-trivial and need some > > careful review and testing. > > How are we going with the review and testing. I assume that > we're now OK on the runtime testing front, but do you feel that > review has been adequate? Yes, I think we're fine, mostly due to Hugh. I'm a little sad about the simplification / descoping from him, but at least we get the main objective done. Maybe at some point we can do another pass at cleaning up the shmem page finding/reading mess. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 30 Mar 2023 01:56:15 +0200 Subject: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2 In-Reply-To: <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> References: <20230121065755.1140136-1-hch@lst.de> <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> Message-ID: <20230329235615.GA2012@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Mar 28, 2023 at 04:04:33PM -0700, Andrew Morton wrote: > > Note that the shmem patches in here are non-trivial and need some > > careful review and testing. > > How are we going with the review and testing. I assume that > we're now OK on the runtime testing front, but do you feel that > review has been adequate? Yes, I think we're fine, mostly due to Hugh. I'm a little sad about the simplification / descoping from him, but at least we get the main objective done. Maybe at some point we can do another pass at cleaning up the shmem page finding/reading mess. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: return an ERR_PTR from __filemap_get_folio v2 Date: Thu, 30 Mar 2023 01:56:15 +0200 Message-ID: <20230329235615.GA2012@lst.de> References: <20230121065755.1140136-1-hch@lst.de> <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20230328160433.4f3dc32b480239bce9e2f9ef-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Christoph Hellwig , Matthew Wilcox , Hugh Dickins , linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Tue, Mar 28, 2023 at 04:04:33PM -0700, Andrew Morton wrote: > > Note that the shmem patches in here are non-trivial and need some > > careful review and testing. > > How are we going with the review and testing. I assume that > we're now OK on the runtime testing front, but do you feel that > review has been adequate? Yes, I think we're fine, mostly due to Hugh. I'm a little sad about the simplification / descoping from him, but at least we get the main objective done. Maybe at some point we can do another pass at cleaning up the shmem page finding/reading mess.