From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D42BC761AF for ; Thu, 30 Mar 2023 09:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbjC3Jrr (ORCPT ); Thu, 30 Mar 2023 05:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbjC3JrP (ORCPT ); Thu, 30 Mar 2023 05:47:15 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1616586B4; Thu, 30 Mar 2023 02:46:36 -0700 (PDT) Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 892C2E0010; Thu, 30 Mar 2023 09:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680169595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDZMFFeXlhTNHv0SPx6QXJ/W5qsCoVxWgCf1SwG+2Wo=; b=jl1v7xa81tnvUJc7h0fegAZMWr2Di8Zr9J7ucrXYdEnehswb+2ISKV+RyjocaWIoYTH9AI E6HMrrTV2eX7J5osIb34clZX6kQL46SOnjqcZp21jqhUhT349ljsSeaeAgNxIkihlvfyzz jFpIaOsBrejO1VxvmqNtSnW3zoW8biP5QIYg8ykBeby1NdknwWVUkJBOcNMZKMvGSlD81g z2Ou6jivSsdrTQlSYQwHjN0rhBQxUhdnO1h191oRXFqOYBjkY27a1ofnierJaW25hor1ZX m/xHqnOfqLrcT5viVwqpARBqIFc5mo9FkOKqageu4oA8v1RNvSjT/Npb4G5mSg== Date: Thu, 30 Mar 2023 11:46:31 +0200 From: Maxime Chevallier To: Andrew Lunn Cc: Mark Brown , Greg Kroah-Hartman , rafael@kernel.org, Colin Foster , Vladimir Oltean , Lee Jones , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: Re: [RFC 4/7] mfd: ocelot-spi: Change the regmap stride to reflect the real one Message-ID: <20230330114631.6afa041c@pc-7.home> In-Reply-To: <826e295b-6a0b-4015-85bc-5ba6015678dc@lunn.ch> References: <20230324093644.464704-1-maxime.chevallier@bootlin.com> <20230324093644.464704-5-maxime.chevallier@bootlin.com> <20230324134817.50358271@pc-7.home> <826e295b-6a0b-4015-85bc-5ba6015678dc@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andrew, On Mon, 27 Mar 2023 02:02:55 +0200 Andrew Lunn wrote: > > > > static const struct regmap_config ocelot_spi_regmap_config = { > > > > .reg_bits = 24, > > > > - .reg_stride = 4, > > > > + .reg_stride = 1, > > > > .reg_shift = REGMAP_DOWNSHIFT(2), > > > > .val_bits = 32, > > > > > > This does not look like a bisectable change? Or did it never work > > > before? > > > > Actually this works in all cases because of "regmap: check for > > alignment on translated register addresses" in this series. Before > > this series, I think using a stride of 1 would have worked too, as > > any 4-byte-aligned accesses are also 1-byte aligned. > > This is the sort of think which is good to explain in the commit > message. That is the place to answer questions reviewers are likely to > ask for things which are not obvious from just the patch. That's right, I will include this explanation in the next iteration. Thanks for the review, Maxime > Andrew