From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0B8C6FD1D for ; Tue, 4 Apr 2023 11:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbjDDL2k (ORCPT ); Tue, 4 Apr 2023 07:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234295AbjDDL2k (ORCPT ); Tue, 4 Apr 2023 07:28:40 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EB2E1FEF for ; Tue, 4 Apr 2023 04:28:39 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjepm-00043P-Ln; Tue, 04 Apr 2023 13:28:18 +0200 Received: from pengutronix.de (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 42D791A6300; Tue, 4 Apr 2023 11:28:13 +0000 (UTC) Date: Tue, 4 Apr 2023 13:28:12 +0200 From: Marc Kleine-Budde To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller Message-ID: <20230404-postage-handprint-efdb77646082@pengutronix.de> References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vrolgxtwhc7crda5" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --vrolgxtwhc7crda5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28.03.2023 11:28:59, Dario Binacchi wrote: > > Applied to linux-can-next. >=20 > Just one last question: To test this series, as described in the cover > letter, I could not use the iproute2 package since the microcontroller > is without MMU. I then extended busybox for the ip link command. I > actually also added the rtnl-link-can.c application to the libmnl > library. So now I find myself with two applications that have been > useful to me for this type of use case. >=20 > Did I do useless work because I could use other tools? systemd-networkd also supports CAN configuration, but I this will probably not work on no-MMU systemd, too. Then there is: | https://git.pengutronix.de/cgit/tools/canutils | https://git.pengutronix.de/cgit/tools/libsocketcan that contains canconfig, but it lacks CAN-FD support. > If instead the tools for this use case are missing, what do you think > is better to do? Submit to their respective repos or add this > functionality to another project that I haven't considered ? Yes, go ahead and upstream your changes! Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --vrolgxtwhc7crda5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQsCckACgkQvlAcSiqK BOiwvQf/bknW5120duEvKB4vzq6g1FE4pHri1PUIfK32NY2ZntW/rs/zYYH5KMTC A3DRsT4CsHVSXNDvW7JNgHJIxIZ8kFQGiAIfOv/a7OOYXZocvfBMW9yxgRqDlese N9BqaRggCBDhP829laPpXYntgW6k8lTMpWI7C6ANyis9tbKJ68Ut0d7bZ4eiYGme +R4neMSudT1l+tzSobkBpDrXloivl9uXhme25xmFTtQeokwCaXSZ7CFDpNcTV2zw 3wq4YYs3fnoxUbIauVk4mDGyoJTB0ZzDee5Kp8+ucH1+eukInkeHk37RerOpc4Wv Gl61KK/5ijUZNnIHiOJIS9C8Sv6kSQ== =L7qt -----END PGP SIGNATURE----- --vrolgxtwhc7crda5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0B11C761A6 for ; Tue, 4 Apr 2023 11:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s0Fy2mdlOdlzAF4gTglQaC6PtTtNFga7Lts/2fA5gSw=; b=jElskZIOT68HdRN7IIZnUC0ooZ orFF0F6FnfGw6Q/lXm80+IIiYflHnHD4vUd3qUDsUF2qlrsBRQgfC+onDTHebJfO5XRsxzBsG51vE MqmBITHoA2UO+DxvX8nBbg084gZ+ptkXIAI6ONSyjyCYgmj305t0WlYgpZPdGHOTZRIJk4B2zK+K8 1eYCpyVI+/fc2VFpkmeI8IjPIvw2RA+A2Yv3OUP3/GOAti57TNt/tkxIRXTrqMIYBG/klixBpQBOf uqirudJGkxbZJMYsj0345KpZopUOKccPX7rxSw8MlrAzoB5w/x9Cscsff3dGDG7YvsOssWnrXnt9a Lm2GV4yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjeq6-0014xC-32; Tue, 04 Apr 2023 11:28:38 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjeq4-0014wX-04 for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 11:28:37 +0000 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjepm-00043P-Ln; Tue, 04 Apr 2023 13:28:18 +0200 Received: from pengutronix.de (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 42D791A6300; Tue, 4 Apr 2023 11:28:13 +0000 (UTC) Date: Tue, 4 Apr 2023 13:28:12 +0200 From: Marc Kleine-Budde To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller Message-ID: <20230404-postage-handprint-efdb77646082@pengutronix.de> References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_042836_086494_D69FA844 X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8712211303667090827==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8712211303667090827== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vrolgxtwhc7crda5" Content-Disposition: inline --vrolgxtwhc7crda5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28.03.2023 11:28:59, Dario Binacchi wrote: > > Applied to linux-can-next. >=20 > Just one last question: To test this series, as described in the cover > letter, I could not use the iproute2 package since the microcontroller > is without MMU. I then extended busybox for the ip link command. I > actually also added the rtnl-link-can.c application to the libmnl > library. So now I find myself with two applications that have been > useful to me for this type of use case. >=20 > Did I do useless work because I could use other tools? systemd-networkd also supports CAN configuration, but I this will probably not work on no-MMU systemd, too. Then there is: | https://git.pengutronix.de/cgit/tools/canutils | https://git.pengutronix.de/cgit/tools/libsocketcan that contains canconfig, but it lacks CAN-FD support. > If instead the tools for this use case are missing, what do you think > is better to do? Submit to their respective repos or add this > functionality to another project that I haven't considered ? Yes, go ahead and upstream your changes! Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --vrolgxtwhc7crda5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQsCckACgkQvlAcSiqK BOiwvQf/bknW5120duEvKB4vzq6g1FE4pHri1PUIfK32NY2ZntW/rs/zYYH5KMTC A3DRsT4CsHVSXNDvW7JNgHJIxIZ8kFQGiAIfOv/a7OOYXZocvfBMW9yxgRqDlese N9BqaRggCBDhP829laPpXYntgW6k8lTMpWI7C6ANyis9tbKJ68Ut0d7bZ4eiYGme +R4neMSudT1l+tzSobkBpDrXloivl9uXhme25xmFTtQeokwCaXSZ7CFDpNcTV2zw 3wq4YYs3fnoxUbIauVk4mDGyoJTB0ZzDee5Kp8+ucH1+eukInkeHk37RerOpc4Wv Gl61KK/5ijUZNnIHiOJIS9C8Sv6kSQ== =L7qt -----END PGP SIGNATURE----- --vrolgxtwhc7crda5-- --===============8712211303667090827== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8712211303667090827==--