From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45310C76188 for ; Tue, 4 Apr 2023 21:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF16B6B0075; Tue, 4 Apr 2023 17:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA1026B0078; Tue, 4 Apr 2023 17:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8F846B007B; Tue, 4 Apr 2023 17:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9B0A76B0075 for ; Tue, 4 Apr 2023 17:25:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63EE1AC591 for ; Tue, 4 Apr 2023 21:25:33 +0000 (UTC) X-FDA: 80644990146.16.73AC918 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id A976240018 for ; Tue, 4 Apr 2023 21:25:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TzhwANgs; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680643531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rVms7mraodGMcoFMa/DcyTh1dgq4pTiuvlZVmDjQfLI=; b=iK9Lu3OGgvQ3VSUqqTh2P7wLF64QclQcvvuOVh5zZxt2bnuOhuygWXUlI06NyJxQQgfkdB 8b0yVpCSFhbRQscSpj8AH7ECKrddg9Ju8689NNkRCylHH6s7AQh+N3QgzkSI/l+miZCWBv 0i4cCRRMA3WIHkDVXFc/k/Flqi/M2k0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TzhwANgs; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680643531; a=rsa-sha256; cv=none; b=JPvDCPcNU6IbQzdbx6Mhq5bEVMFJtetUMWjB7d5PqG793ndgJfcJsh6Hgp6K2vVUTtsCRZ qyVPRYoYDmcbkORdC1H9f5RWBC3ELdFO6U/FPSRBNXl5VJTh0xgAHE8KvJ4eZ6TXI+JYnE JmGKJIeROm9qnT3vWtpPJggY1kQko/w= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 857D563A1F; Tue, 4 Apr 2023 21:25:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D3B5C433D2; Tue, 4 Apr 2023 21:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1680643529; bh=85xYZYVZISGH7AbeoTI3yHzPqvj3AUpqPA6RM+bybUA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzhwANgsvXNAK7A+7nE0AJ+kEeVGMrFJKNJRzpqnSk7fH0CZ3DO6MLoMgBWsZC4bm LNpM8M26XlnESzEQrgW0DEYz6UZgOA4aMTxDStHlOPtJqVPKvPi9pjs/KYy5ZcM2mf aLcqQQ9cnFTF72XNv1VxOyShPM9alyVxoe3R/hz0= Date: Tue, 4 Apr 2023 14:25:28 -0700 From: Andrew Morton To: Tetsuo Handa Cc: Michal Hocko , Petr Mladek , Patrick Daly , Mel Gorman , David Hildenbrand , Sergey Senozhatsky , Steven Rostedt , John Ogness , syzkaller-bugs@googlegroups.com, Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , syzbot , linux-mm Subject: Re: [PATCH v2] mm/page_alloc: fix potential deadlock on zonelist_update_seq seqlock Message-Id: <20230404142528.d232bcdc59ac9cf11de10580@linux-foundation.org> In-Reply-To: <8796b95c-3da3-5885-fddd-6ef55f30e4d3@I-love.SAKURA.ne.jp> References: <78ff6e70-e986-1fcb-eafb-3edd5f2bceae@I-love.SAKURA.ne.jp> <6266b161-e4c3-7d65-6590-da6cc04d93ec@I-love.SAKURA.ne.jp> <0585ddb9-5de8-8cdd-202e-53887bbb6b5f@I-love.SAKURA.ne.jp> <8796b95c-3da3-5885-fddd-6ef55f30e4d3@I-love.SAKURA.ne.jp> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A976240018 X-Rspam-User: X-Stat-Signature: r1exukqebt6pmhyhz1rfxawisnumtxg6 X-HE-Tag: 1680643531-677908 X-HE-Meta: U2FsdGVkX1+JyXLtQ54D0l13BqG1Mlg2YC9KLzf/nCFNbH+BgGjI/c+gOhVXibd/jW+7UPdDwBtDk+CKn8UB4vvd6bTBqREnV1ERGOMFkGK4bzwNZm6gnnGaMxduCt2hO7ZSp6A/C1dSdwUGM+hsuysTP+sc29dCBHtj/g8y1c/8QkbtcM6W2v+vHqKVrF+0euk3SdSYEdEHmkqBOOs3gfnaZvA84jlpa71rylPN4iU1L/gwY3UZQs9JyHqOUYL+IhsTJaEtHvHZmrceoPnuc4ReWW2q771gqkRl91O0GyzUTj0WK9eUa+xQWfSFuCmintVY2XLQSDpXPM2xPZ5yDfMoYUddAI6NMnEwMvo6nUfZJ6oGIHyMFwNiiyaMmPfnq9zfZvivLn1ia6g8YMT4osrWHcSy5r4YhKDOlfTdCJSzmI3+q/jufRU043tyK19jQcChs4CIhTF5Xd9qkEUeECOIu+PEC0/DXvkrGJE7uzTWE3sR0cI8E5yCTKsfbD/UezpmJNM1BfoXeM6rnGXugyk9zLdaN8yVTF/U7NEPyCnmiZWSXr+LKnCuBoMzoB9N84vd5xJ3VDhXStUYBfXamaJBkblLK5so+ZR7PUsXKw9Zblh+97lBVv8yBSbm1M58Q/Lpka7ywBJr/Wz56CkD/G2IE2nQLgQZIhECtpmyw4sM+ZuvGQOIGttfi+5XqG5U3cnH16CSnwijWIXfMGGXIEtwfQfY5g7YMwEzBQBan6Lna4H0Ow4Hu57jffgZEc1SDwc1TTe2VIFUdhjDzTKZwdYeg5Muj5FMXGG+gxWWwbXLZSQSNGmA4QppctWlKg+kJcXwNOXPUlK/qAKsx0IS3BX+2jVGf5cPMcXbqPSts2MS3eq3JqThs30+iA8g8EbsQS8/CVqriIbb7BE1GFSbG1VMXS2AXViIuv16g0KES5Mlt9gz1ejaWtoGnUguggv+lbiVb31UpOaSGubAgP5 JFQCFIGc Gyrdsf7mc+HHfRZOOoka0/3C8c2vE2da1OHIwQwCXnjquYQaL21egs5RoBJohDrryOuYExGf1zXXaC4n4obDerUQekwxnD3kngZhWKkdYSX0LBXoZmeo7zfpls7vewycF24I5u7W+sw3qldZEQ4cygput53cBxFSfE7Eji5FAohS149kH3ZaVfSj1IU4Y0nOkwSJAFFhKl7akPFu0cddW0PLTJq90qnRswJEZ8tA6dxLU4w0CjWSe4DXbtgwhhHV7Fh2tzuF7sGsw+DEiHb/a5FzTwpEqeoc4jzy2PVwZ0MZe8ho0EIGTAsqld/JhAO4XJBP7SKRsFTF5xImUn9kC0XpXRAS47zTerl+dC/WtmAo1WtH49uOZkZChT2swzKy7MWN4/6C52FPapVVz9w3KCM6UXRtFUNeesGGVDkhiDpCdAPqEms+RoXA/wuKcv6FSPtY/oqbQgRFmgE+WRaf20M9VdgyCmDpICrOa7VYK5l5HvT0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Apr 2023 23:31:58 +0900 Tetsuo Handa wrote: > syzbot is reporting circular locking dependency which involves > zonelist_update_seq seqlock [1], for this lock is checked by memory > allocation requests which do not need to be retried. I queued this, along with a note that an updated changelog is likely. Do we feel that a -stable backport is warranted? I think so, from your earlier comments. Please add the cc:stable to the changelog in this situation.