From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C37C77B61 for ; Mon, 10 Apr 2023 17:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbjDJRoP (ORCPT ); Mon, 10 Apr 2023 13:44:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbjDJRoO (ORCPT ); Mon, 10 Apr 2023 13:44:14 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FA5126B9 for ; Mon, 10 Apr 2023 10:44:13 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id m18so5215798plx.5 for ; Mon, 10 Apr 2023 10:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681148653; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yWQNPjxOiH9ikIbp275JanF40njNYNR09cvqLl6jQAE=; b=sFZiOJlR/azM1KLSZuC4d6gGG/o4LsLQldk2wiRC/oJSCDKReSANURRkcHhJRjUGuo H/c5rEyrx9HHs8+u8Sy78D7L+5xreTcsA+Q9HJPJq05QMQvaRgmJ2p1nyab1jzHhnSoy FZEyJM6XhjLXOHrSqVZgf7OIq6LK/HImYa4g3MxPlfoY1aZIU+APRSPTjoLnVtI88OrT 8NMRwNrfqXkZ1gMWcijAL94AnZBBMmg6mJrifl7ZRougbsRc7l4b5zS9AEwNpw4diQgI Ui9aClbn6XG4G1ut+BTlF3CXakefy3trXxSqQZ2tITeG6l/FDCAFGWAkV8PTpDMD/Sit WDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681148653; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yWQNPjxOiH9ikIbp275JanF40njNYNR09cvqLl6jQAE=; b=mFKYvoIYRxLAOPdf29xlW5dXfYcvt5LCAbDKlGEDSS40xQ0ynSS9E3pEQ5DbBiUhcD U3W/qob9ntOEsKHwl0gZAMRrOJLVES6JIpZY8SH+d5hrG5PuL+kvQsWYAJYYcKOMHIqM rBTNRjF+YDKzb8hm7qDfUcvOUBy1OnLa/kOoYL5yUXKRWwPj2DuyWWsPcYBkJgEcrHnX exP5GXLpg/7/Pqy/u9tupxwTzDOW2MxaX83ZnR8/QGT1sac64iGtT70XrTN8B28ZpjML 2DNyWQrLCan7f2EsHjmjdg+iIpqW9elMOMDpoALCmD6ZQfZp0/7RO7w8usEtN2pomcrw FN/A== X-Gm-Message-State: AAQBX9eZRhE1gqWwus5jpb9CcxSe4lVLX8nBBCSXeOdUha/xlWwfTLTI ZCmhS8qaNCQ+rCw/zWzFIVyOEg== X-Google-Smtp-Source: AKy350a0UqbFHqt+Sl9q/bhoxYb7h3/xxccDs8RVv+EDn0SI5G+SHERF4W6kDbcDz5ySUIJzae8ALQ== X-Received: by 2002:a17:90a:bb89:b0:246:5780:ccf8 with SMTP id v9-20020a17090abb8900b002465780ccf8mr10743326pjr.4.1681148653018; Mon, 10 Apr 2023 10:44:13 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:cecd:b1ee:70ec:874]) by smtp.gmail.com with ESMTPSA id t15-20020a17090ae50f00b0023377b98c7csm7753977pjy.38.2023.04.10.10.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 10:44:12 -0700 (PDT) Date: Mon, 10 Apr 2023 11:44:10 -0600 From: Mathieu Poirier To: Markus Elfring Cc: kernel-janitors@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, kernel@pengutronix.de, Bjorn Andersson , Fabio Estevam , Sascha Hauer , Shawn Guo , cocci@inria.fr, LKML Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: Improve exception handling in imx_dsp_rproc_mbox_alloc() Message-ID: <20230410174410.GB4129213@p14s> References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Thu, Apr 06, 2023 at 10:12:50PM +0200, Markus Elfring wrote: > Date: Thu, 6 Apr 2023 22:00:24 +0200 > > The label “err_out” was used to jump to another pointer check > despite of the detail in the implementation of the function > “imx_dsp_rproc_mbox_alloc” that it was determined already > that the corresponding variable contained an error pointer > because of a failed call of the function “mbox_request_channel_byname”. > > Thus perform the following adjustments: > > 1. Return directly after a call of the function > “mbox_request_channel_byname” failed for the input parameter “tx”. > > 2. Use more appropriate labels instead. > > 3. Reorder jump targets at the end. > > 4. Omit a function call and three extra checks. > > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/remoteproc/imx_dsp_rproc.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > Applied Thanks, Mathieu > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index 21759d9e5b7b..a8ad15ef1da0 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -530,7 +530,7 @@ static int imx_dsp_rproc_mbox_alloc(struct imx_dsp_rproc *priv) > ret = PTR_ERR(priv->tx_ch); > dev_dbg(cl->dev, "failed to request tx mailbox channel: %d\n", > ret); > - goto err_out; > + return ret; > } > > /* Channel for receiving message */ > @@ -539,7 +539,7 @@ static int imx_dsp_rproc_mbox_alloc(struct imx_dsp_rproc *priv) > ret = PTR_ERR(priv->rx_ch); > dev_dbg(cl->dev, "failed to request rx mailbox channel: %d\n", > ret); > - goto err_out; > + goto free_channel_tx; > } > > cl = &priv->cl_rxdb; > @@ -555,19 +555,15 @@ static int imx_dsp_rproc_mbox_alloc(struct imx_dsp_rproc *priv) > ret = PTR_ERR(priv->rxdb_ch); > dev_dbg(cl->dev, "failed to request mbox chan rxdb, ret %d\n", > ret); > - goto err_out; > + goto free_channel_rx; > } > > return 0; > > -err_out: > - if (!IS_ERR(priv->tx_ch)) > - mbox_free_channel(priv->tx_ch); > - if (!IS_ERR(priv->rx_ch)) > - mbox_free_channel(priv->rx_ch); > - if (!IS_ERR(priv->rxdb_ch)) > - mbox_free_channel(priv->rxdb_ch); > - > +free_channel_rx: > + mbox_free_channel(priv->rx_ch); > +free_channel_tx: > + mbox_free_channel(priv->tx_ch); > return ret; > } > > -- > 2.40.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2219CC77B61 for ; Mon, 10 Apr 2023 17:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m2N2dHlNf6SkcjFWRKk3y19VXSBU4p0dxUXFKmGGXDQ=; b=NZLVeNFHGAhqqb kwBMxmabptnl3uxF39I4rAFFZs0b/lZuC93ZzjT546+7Dd9ioqHdZRUDzKSQxeSl2PQp0338m7rBb NVTpn74mWSRPY9CkGgH34q+z+c4qG+vyVtXFu5N5P2SX35Y76xAo1hsINANUzfPqb1HAXebZDW0SO xJzhMKXMIrKQfllUhPQ6myvdL+tzYWNhrehENvupWqUHjxuR0BX+ZiyIgQ0xe10ZUu8iqEBZzBpQV zLHUrbDswboQXEcOkmxIgnG+hKaHBIx+0fjaUx4QUJQur7YOxp4XGX/fljTbAhewDy8MqJmCd0ucf z1AEwhntleAWM4mcCY1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plvYy-00FeeY-1W; Mon, 10 Apr 2023 17:44:20 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plvYu-00Fedn-1D for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 17:44:17 +0000 Received: by mail-pj1-x1031.google.com with SMTP id pc4-20020a17090b3b8400b0024676052044so5281059pjb.1 for ; Mon, 10 Apr 2023 10:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681148653; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yWQNPjxOiH9ikIbp275JanF40njNYNR09cvqLl6jQAE=; b=sFZiOJlR/azM1KLSZuC4d6gGG/o4LsLQldk2wiRC/oJSCDKReSANURRkcHhJRjUGuo H/c5rEyrx9HHs8+u8Sy78D7L+5xreTcsA+Q9HJPJq05QMQvaRgmJ2p1nyab1jzHhnSoy FZEyJM6XhjLXOHrSqVZgf7OIq6LK/HImYa4g3MxPlfoY1aZIU+APRSPTjoLnVtI88OrT 8NMRwNrfqXkZ1gMWcijAL94AnZBBMmg6mJrifl7ZRougbsRc7l4b5zS9AEwNpw4diQgI Ui9aClbn6XG4G1ut+BTlF3CXakefy3trXxSqQZ2tITeG6l/FDCAFGWAkV8PTpDMD/Sit WDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681148653; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yWQNPjxOiH9ikIbp275JanF40njNYNR09cvqLl6jQAE=; b=W4GzpUlcF7boSJmr1Z8dXPwfpYrgaKQg5dtbMfNJX1GfbtrLBQiGl1vxGr5Ok+HuHL fvGpeQK3/LjdlhYIcYKFkqxY5Tmrxll7fal10jNN03LqenzDuXt2QEEes/biIU3OjePu UaYu8+Gq/st1bc+N6QnCa4YIV4S4i2VIZNc1Kn/qSiYFyUCclOXYL6dJVeAhJGg+S+rr bGDn1hEuQNFYf8U60yuWOhmgplJdAfWufHRpk7AQeUiriee8y+q34S7pvJcbm7DsgTXZ hNBC7klhHkkolG6aksXpD02ZjypQDBsmJMqr52iaKRal66IvcYvOx7B+6x7oK0H/p2rZ dyDA== X-Gm-Message-State: AAQBX9eP1EzbwybdB5zgFZPan0sRe4rjhizFvv8BHxDwh55V/YrCLYjP 7HWJ+sLvYQWolO7OSG36MCsvmw== X-Google-Smtp-Source: AKy350a0UqbFHqt+Sl9q/bhoxYb7h3/xxccDs8RVv+EDn0SI5G+SHERF4W6kDbcDz5ySUIJzae8ALQ== X-Received: by 2002:a17:90a:bb89:b0:246:5780:ccf8 with SMTP id v9-20020a17090abb8900b002465780ccf8mr10743326pjr.4.1681148653018; Mon, 10 Apr 2023 10:44:13 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:cecd:b1ee:70ec:874]) by smtp.gmail.com with ESMTPSA id t15-20020a17090ae50f00b0023377b98c7csm7753977pjy.38.2023.04.10.10.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 10:44:12 -0700 (PDT) Date: Mon, 10 Apr 2023 11:44:10 -0600 From: Mathieu Poirier To: Markus Elfring Cc: kernel-janitors@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, kernel@pengutronix.de, Bjorn Andersson , Fabio Estevam , Sascha Hauer , Shawn Guo , cocci@inria.fr, LKML Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: Improve exception handling in imx_dsp_rproc_mbox_alloc() Message-ID: <20230410174410.GB4129213@p14s> References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_104416_425123_A73E735E X-CRM114-Status: GOOD ( 22.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMDYsIDIwMjMgYXQgMTA6MTI6NTBQTSArMDIwMCwgTWFya3VzIEVsZnJpbmcg d3JvdGU6Cj4gRGF0ZTogVGh1LCA2IEFwciAyMDIzIDIyOjAwOjI0ICswMjAwCj4gCj4gVGhlIGxh YmVsIOKAnGVycl9vdXTigJ0gd2FzIHVzZWQgdG8ganVtcCB0byBhbm90aGVyIHBvaW50ZXIgY2hl Y2sKPiBkZXNwaXRlIG9mIHRoZSBkZXRhaWwgaW4gdGhlIGltcGxlbWVudGF0aW9uIG9mIHRoZSBm dW5jdGlvbgo+IOKAnGlteF9kc3BfcnByb2NfbWJveF9hbGxvY+KAnSB0aGF0IGl0IHdhcyBkZXRl cm1pbmVkIGFscmVhZHkKPiB0aGF0IHRoZSBjb3JyZXNwb25kaW5nIHZhcmlhYmxlIGNvbnRhaW5l ZCBhbiBlcnJvciBwb2ludGVyCj4gYmVjYXVzZSBvZiBhIGZhaWxlZCBjYWxsIG9mIHRoZSBmdW5j dGlvbiDigJxtYm94X3JlcXVlc3RfY2hhbm5lbF9ieW5hbWXigJ0uCj4gCj4gVGh1cyBwZXJmb3Jt IHRoZSBmb2xsb3dpbmcgYWRqdXN0bWVudHM6Cj4gCj4gMS4gUmV0dXJuIGRpcmVjdGx5IGFmdGVy IGEgY2FsbCBvZiB0aGUgZnVuY3Rpb24KPiAgICDigJxtYm94X3JlcXVlc3RfY2hhbm5lbF9ieW5h bWXigJ0gZmFpbGVkIGZvciB0aGUgaW5wdXQgcGFyYW1ldGVyIOKAnHR44oCdLgo+IAo+IDIuIFVz ZSBtb3JlIGFwcHJvcHJpYXRlIGxhYmVscyBpbnN0ZWFkLgo+IAo+IDMuIFJlb3JkZXIganVtcCB0 YXJnZXRzIGF0IHRoZSBlbmQuCj4gCj4gNC4gT21pdCBhIGZ1bmN0aW9uIGNhbGwgYW5kIHRocmVl IGV4dHJhIGNoZWNrcy4KPiAKPiAKPiBUaGlzIGlzc3VlIHdhcyBkZXRlY3RlZCBieSB1c2luZyB0 aGUgQ29jY2luZWxsZSBzb2Z0d2FyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmlu ZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+Cj4gLS0tCj4gIGRyaXZlcnMvcmVtb3Rl cHJvYy9pbXhfZHNwX3Jwcm9jLmMgfCAxOCArKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4KCkFwcGxpZWQKClRoYW5r cywKTWF0aGlldQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZW1vdGVwcm9jL2lteF9kc3BfcnBy b2MuYyBiL2RyaXZlcnMvcmVtb3RlcHJvYy9pbXhfZHNwX3Jwcm9jLmMKPiBpbmRleCAyMTc1OWQ5 ZTViN2IuLmE4YWQxNWVmMWRhMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3JlbW90ZXByb2MvaW14 X2RzcF9ycHJvYy5jCj4gKysrIGIvZHJpdmVycy9yZW1vdGVwcm9jL2lteF9kc3BfcnByb2MuYwo+ IEBAIC01MzAsNyArNTMwLDcgQEAgc3RhdGljIGludCBpbXhfZHNwX3Jwcm9jX21ib3hfYWxsb2Mo c3RydWN0IGlteF9kc3BfcnByb2MgKnByaXYpCj4gIAkJcmV0ID0gUFRSX0VSUihwcml2LT50eF9j aCk7Cj4gIAkJZGV2X2RiZyhjbC0+ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgdHggbWFpbGJveCBj aGFubmVsOiAlZFxuIiwKPiAgCQkJcmV0KTsKPiAtCQlnb3RvIGVycl9vdXQ7Cj4gKwkJcmV0dXJu IHJldDsKPiAgCX0KPiAKPiAgCS8qIENoYW5uZWwgZm9yIHJlY2VpdmluZyBtZXNzYWdlICovCj4g QEAgLTUzOSw3ICs1MzksNyBAQCBzdGF0aWMgaW50IGlteF9kc3BfcnByb2NfbWJveF9hbGxvYyhz dHJ1Y3QgaW14X2RzcF9ycHJvYyAqcHJpdikKPiAgCQlyZXQgPSBQVFJfRVJSKHByaXYtPnJ4X2No KTsKPiAgCQlkZXZfZGJnKGNsLT5kZXYsICJmYWlsZWQgdG8gcmVxdWVzdCByeCBtYWlsYm94IGNo YW5uZWw6ICVkXG4iLAo+ICAJCQlyZXQpOwo+IC0JCWdvdG8gZXJyX291dDsKPiArCQlnb3RvIGZy ZWVfY2hhbm5lbF90eDsKPiAgCX0KPiAKPiAgCWNsID0gJnByaXYtPmNsX3J4ZGI7Cj4gQEAgLTU1 NSwxOSArNTU1LDE1IEBAIHN0YXRpYyBpbnQgaW14X2RzcF9ycHJvY19tYm94X2FsbG9jKHN0cnVj dCBpbXhfZHNwX3Jwcm9jICpwcml2KQo+ICAJCXJldCA9IFBUUl9FUlIocHJpdi0+cnhkYl9jaCk7 Cj4gIAkJZGV2X2RiZyhjbC0+ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgbWJveCBjaGFuIHJ4ZGIs IHJldCAlZFxuIiwKPiAgCQkJcmV0KTsKPiAtCQlnb3RvIGVycl9vdXQ7Cj4gKwkJZ290byBmcmVl X2NoYW5uZWxfcng7Cj4gIAl9Cj4gCj4gIAlyZXR1cm4gMDsKPiAKPiAtZXJyX291dDoKPiAtCWlm ICghSVNfRVJSKHByaXYtPnR4X2NoKSkKPiAtCQltYm94X2ZyZWVfY2hhbm5lbChwcml2LT50eF9j aCk7Cj4gLQlpZiAoIUlTX0VSUihwcml2LT5yeF9jaCkpCj4gLQkJbWJveF9mcmVlX2NoYW5uZWwo cHJpdi0+cnhfY2gpOwo+IC0JaWYgKCFJU19FUlIocHJpdi0+cnhkYl9jaCkpCj4gLQkJbWJveF9m cmVlX2NoYW5uZWwocHJpdi0+cnhkYl9jaCk7Cj4gLQo+ICtmcmVlX2NoYW5uZWxfcng6Cj4gKwlt Ym94X2ZyZWVfY2hhbm5lbChwcml2LT5yeF9jaCk7Cj4gK2ZyZWVfY2hhbm5lbF90eDoKPiArCW1i b3hfZnJlZV9jaGFubmVsKHByaXYtPnR4X2NoKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAKPiAt LQo+IDIuNDAuMAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=