All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: <sstabellini@kernel.org>, Vikram Garhwal <vikram.garhwal@amd.com>,
	"Julien Grall" <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h
Date: Tue, 11 Apr 2023 12:16:12 -0700	[thread overview]
Message-ID: <20230411191636.26926-12-vikram.garhwal@amd.com> (raw)
In-Reply-To: <20230411191636.26926-1-vikram.garhwal@amd.com>

Dynamic programming ops will modify the dt_host and there might be other
function which are browsing the dt_host at the same time. To avoid the race
conditions, adding rwlock for browsing the dt_host. But adding rwlock in
device_tree.h causes following circular dependency:
    device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h

To fix this, removed the "#include <xen/device_tree.h> and forward declared
"struct dt_device_node".

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
---
 xen/arch/arm/include/asm/smp.h | 3 ++-
 xen/arch/arm/smpboot.c         | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index 8133d5c295..afe6129276 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -3,13 +3,14 @@
 
 #ifndef __ASSEMBLY__
 #include <xen/cpumask.h>
-#include <xen/device_tree.h>
 #include <asm/current.h>
 #endif
 
 DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask);
 DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
 
+struct dt_device_node;
+
 #define cpu_is_offline(cpu) unlikely(!cpu_online(cpu))
 
 #define smp_processor_id() get_processor_id()
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index 412ae22869..336a7d418b 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -11,6 +11,7 @@
 #include <xen/cpumask.h>
 #include <xen/delay.h>
 #include <xen/domain_page.h>
+#include <xen/device_tree.h>
 #include <xen/errno.h>
 #include <xen/init.h>
 #include <xen/mm.h>
-- 
2.17.1



  parent reply	other threads:[~2023-04-11 19:17 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 19:16 [XEN][PATCH v5 00/17] dynamic node programming using overlay dtbo Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type Vikram Garhwal
2023-04-13  9:19   ` Michal Orzel
2023-04-14 17:28     ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Vikram Garhwal
2023-04-13  9:45   ` Michal Orzel
2023-04-13  9:53     ` Julien Grall
2023-04-13 10:03   ` Julien Grall
2023-04-14 17:51     ` Vikram Garhwal
2023-04-14 18:09       ` Julien Grall
2023-04-14 18:28         ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Vikram Garhwal
2023-04-13  9:58   ` Michal Orzel
2023-04-13 19:27     ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 04/17] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Vikram Garhwal
2023-04-13 13:11   ` Michal Orzel
2023-04-14 17:54     ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Vikram Garhwal
2023-04-13 13:40   ` Michal Orzel
2023-04-14 18:04     ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 07/17] xen/smmu: Add remove_device callback for smmu_iommu ops Vikram Garhwal
2023-04-17 10:24   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 08/17] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Vikram Garhwal
2023-04-17  9:14   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 09/17] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Vikram Garhwal
2023-04-17 10:35   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 10/17] xen/iommu: Introduce iommu_remove_dt_device() Vikram Garhwal
2023-04-17 10:49   ` Michal Orzel
2023-04-11 19:16 ` Vikram Garhwal [this message]
2023-04-14  1:50   ` [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Henry Wang
2023-04-17  9:41   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Vikram Garhwal
2023-04-14  2:09   ` Henry Wang
2023-04-14 17:23     ` Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 13/17] xen/arm: Implement device tree node removal functionalities Vikram Garhwal
2023-04-17  8:08   ` Jan Beulich
2023-04-17 15:06   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities Vikram Garhwal
2023-04-18  9:03   ` Michal Orzel
2023-04-11 19:16 ` [XEN][PATCH v5 15/17] tools/libs/ctrl: Implement new xc interfaces for dt overlay Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 16/17] tools/libs/light: Implement new libxl functions for device tree overlay ops Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 17/17] tools/xl: Add new xl command overlay for device tree overlay support Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 00/17] dynamic node programming using overlay dtbo Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 01/17] xen/arm/device: Remove __init from function type Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 02/17] common/device_tree: change __unflatten_device_tree() Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 03/17] xen/arm: Add CONFIG_OVERLAY_DTB Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 04/17] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 05/17] libfdt: overlay: change overlay_get_target() Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 06/17] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 07/17] xen/smmu: Add remove_device callback for smmu_iommu ops Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 08/17] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 09/17] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 10/17] xen/iommu: Introduce iommu_remove_dt_device() Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 12/17] common/device_tree: Add rwlock for dt_host Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 13/17] xen/arm: Implement device tree node removal functionalities Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 15/17] tools/libs/ctrl: Implement new xc interfaces for dt overlay Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 16/17] tools/libs/light: Implement new libxl functions for device tree overlay ops Vikram Garhwal
2023-04-11 19:16 ` [XEN][PATCH v5 17/17] tools/xl: Add new xl command overlay for device tree overlay support Vikram Garhwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411191636.26926-12-vikram.garhwal@amd.com \
    --to=vikram.garhwal@amd.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.