From: Christian Brauner <brauner@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: fix sysctls.c built
Date: Wed, 12 Apr 2023 11:19:56 +0200 [thread overview]
Message-ID: <20230412-sympathie-haltbar-da2d2183067b@brauner> (raw)
In-Reply-To: <66c0e8b6-64d1-5be6-cd4d-9700d84e1b84@huawei.com>
On Tue, Apr 11, 2023 at 12:14:44PM +0800, Kefeng Wang wrote:
> /proc/sys/fs/overflowuid and overflowgid will be lost without
> building this file, kindly ping, any comments, thanks.
>
>
> On 2023/3/31 16:45, Kefeng Wang wrote:
> > 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=",
> > or it won't be built as it is overwrited.
> >
> > Fixes: ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > ---
> > fs/Makefile | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/Makefile b/fs/Makefile
> > index 05f89b5c962f..8d4736fcc766 100644
> > --- a/fs/Makefile
> > +++ b/fs/Makefile
> > @@ -6,7 +6,6 @@
> > # Rewritten to use lists instead of if-statements.
> > #
> > -obj-$(CONFIG_SYSCTL) += sysctls.o
> > obj-y := open.o read_write.o file_table.o super.o \
> > char_dev.o stat.o exec.o pipe.o namei.o fcntl.o \
> > @@ -50,7 +49,7 @@ obj-$(CONFIG_FS_MBCACHE) += mbcache.o
> > obj-$(CONFIG_FS_POSIX_ACL) += posix_acl.o
> > obj-$(CONFIG_NFS_COMMON) += nfs_common/
> > obj-$(CONFIG_COREDUMP) += coredump.o
> > -obj-$(CONFIG_SYSCTL) += drop_caches.o
> > +obj-$(CONFIG_SYSCTL) += drop_caches.o sysctls.o
> > obj-$(CONFIG_FHANDLE) += fhandle.o
> > obj-y += iomap/
Given the description in
ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
you probably want to move this earlier.
next prev parent reply other threads:[~2023-04-12 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 8:45 [PATCH] fs: fix sysctls.c built Kefeng Wang
2023-04-11 4:14 ` Kefeng Wang
2023-04-12 9:19 ` Christian Brauner [this message]
2023-04-13 1:34 ` Kefeng Wang
2023-04-13 8:35 ` Christian Brauner
2023-04-13 9:45 ` Kefeng Wang
2023-04-13 12:06 ` Christian Brauner
2023-04-13 17:06 ` Luis Chamberlain
2023-04-13 18:46 ` Luis Chamberlain
2023-04-13 19:43 ` Luis Chamberlain
2023-04-14 1:19 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412-sympathie-haltbar-da2d2183067b@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.