From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH 1/3] objtool: Separate prefix code from stack validation code
Date: Thu, 13 Apr 2023 08:27:24 -0700 [thread overview]
Message-ID: <20230413152724.rwakb3lxaptgc7e5@treble> (raw)
In-Reply-To: <20230413093031.GK4253@hirez.programming.kicks-ass.net>
On Thu, Apr 13, 2023 at 11:30:31AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 12, 2023 at 01:26:13PM -0700, Josh Poimboeuf wrote:
> > Simplify the prefix code and make it a standalone feature.
>
> The main thing being that you moved it all after
> validate_reachable_instructions() ?
The main thing being that I extricated it from validate_symbol() so it's
a proper independent feature.
> > +static int add_prefix_symbols(struct objtool_file *file)
> > +{
> > + struct section *sec;
> > + struct symbol *func;
> > + int ret, warnings = 0;
> > +
> > + for_each_sec(file, sec) {
> > + if (!(sec->sh.sh_flags & SHF_EXECINSTR))
> > + continue;
> > +
> > + list_for_each_entry(func, &sec->symbol_list, list) {
>
> One of the other patches did a sec_for_each_symbol() thing.
Too many patch sets floating around ;-)
--
Josh
next prev parent reply other threads:[~2023-04-13 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 20:26 [PATCH 0/3] objtool: Generate ORC data for __pfx code Josh Poimboeuf
2023-04-12 20:26 ` [PATCH 1/3] objtool: Separate prefix code from stack validation code Josh Poimboeuf
2023-04-13 9:30 ` Peter Zijlstra
2023-04-13 15:27 ` Josh Poimboeuf [this message]
2023-04-14 14:47 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-04-12 20:26 ` [PATCH 2/3] x86/linkage: Fix padding for typed functions Josh Poimboeuf
2023-04-14 14:47 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
2023-04-12 20:26 ` [PATCH 3/3] objtool: Generate ORC data for __pfx code Josh Poimboeuf
2023-04-13 11:23 ` Peter Zijlstra
2023-04-13 11:24 ` Peter Zijlstra
2023-04-13 15:29 ` Josh Poimboeuf
2023-04-13 19:24 ` Peter Zijlstra
2023-04-13 19:30 ` Josh Poimboeuf
2023-04-14 14:47 ` [tip: objtool/core] " tip-bot2 for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413152724.rwakb3lxaptgc7e5@treble \
--to=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.