From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 232F8C77B6E for ; Fri, 14 Apr 2023 08:39:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6EC8885F64; Fri, 14 Apr 2023 10:39:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X6TrPaFU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0360685F2D; Fri, 14 Apr 2023 10:39:20 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7566F85ECF for ; Fri, 14 Apr 2023 10:39:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E74961530; Fri, 14 Apr 2023 08:39:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C196C433D2; Fri, 14 Apr 2023 08:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681461551; bh=AYmb2/4CKabq+AtqskjfVJKMwiajRI70Lon3tKODexg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=X6TrPaFUt3WEntSM0jqE9TibGtDSyPxXjhXRG/Dl7orjp+aBLmx9GgkdtKRdBmc60 bkiLd09meAcx3GTj/skBL6FU+QIbAam+XJf2Y6qKCzE0RbRP90qXy288mUKsESlhbS CshAjPmZFlptpOGaTg61Az3MEzsS0QIOW68PLku++F6YCjuyRukYPsO85RnkeTAWPL BsCLl0Etgmw1CRKoVcdTIVkex0Eh3+9/EJJ8yUV/uUBv//R3JUoOjVghrYdmdReuOH +Kpmu8gQ8hZJUOSpK6vZZHGutrGPHjKWjlUwUo849h4iBDggMB5EhNozyvHIbF4cmn FDgsjOxuvLw0g== Date: Fri, 14 Apr 2023 10:39:06 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Nishanth Menon Cc: Marek Vasut , Tom Rini , Siddharth Vadapalli , Vignesh Raghavendra , Michal Simek , Ramon Fried , Subject: Re: [PATCH V2 2/2] net: phy: Make phy_interface_is_rgmii a switch statement Message-ID: <20230414103906.5b8de223@dellmb> In-Reply-To: <20230414042433.3436425-3-nm@ti.com> References: <20230414042433.3436425-1-nm@ti.com> <20230414042433.3436425-3-nm@ti.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 13 Apr 2023 23:24:33 -0500 Nishanth Menon wrote: > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem in > range checking functions to identify the interface type. Though this > specific api was'nt impacted (all the RGMII definitions remained within > range), this experience should be used to never to have to face this > kind of challenge again. >=20 > While it is possible for the phy drivers to practically use the enum's > directly, drivers such as dp83867, dp83869, marvell, micrel_ksz90x1 etc > use the same. >=20 > Reported-by: Tom Rini > Signed-off-by: Nishanth Menon > --- > Changes since V1: > * Switch update based on feedback from Marek >=20 > V1: https://lore.kernel.org/r/20230413180713.2922524-3-nm@ti.com > include/phy.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/include/phy.h b/include/phy.h > index 51dadcf14478..600966bc8b20 100644 > --- a/include/phy.h > +++ b/include/phy.h > @@ -361,8 +361,15 @@ int get_phy_id(struct mii_dev *bus, int addr, int de= vad, u32 *phy_id); > */ > static inline bool phy_interface_is_rgmii(struct phy_device *phydev) > { > - return phydev->interface >=3D PHY_INTERFACE_MODE_RGMII && > - phydev->interface <=3D PHY_INTERFACE_MODE_RGMII_TXID; > + switch (phydev->interface) { > + case PHY_INTERFACE_MODE_RGMII: > + case PHY_INTERFACE_MODE_RGMII_ID: > + case PHY_INTERFACE_MODE_RGMII_RXID: > + case PHY_INTERFACE_MODE_RGMII_TXID: > + return 1; > + default: > + return 0; > + } > } > =20 > /** Reviewed-by: Marek Beh=C3=BAn