From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFA9C77B72 for ; Mon, 17 Apr 2023 06:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbjDQGvO (ORCPT ); Mon, 17 Apr 2023 02:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjDQGvO (ORCPT ); Mon, 17 Apr 2023 02:51:14 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231D41729 for ; Sun, 16 Apr 2023 23:51:13 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poIha-0000ao-VI; Mon, 17 Apr 2023 08:51:02 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1poIhX-00044M-V5; Mon, 17 Apr 2023 08:50:59 +0200 Date: Mon, 17 Apr 2023 08:50:59 +0200 From: Marco Felsch To: Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Xavier Roumegue , Rob Herring , linux-imx@nxp.com, Krzysztof Kozlowski , Jacopo Mondi , Shawn Guo , linux-media@vger.kernel.org Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes Message-ID: <20230417065059.fgmdfwk7pnj62amm@pengutronix.de> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, your patch LGTM just one nit/idea, please see below. On 23-04-17, Laurent Pinchart wrote: > Add DT nodes for the two CSI-2 receivers of the i.MX8MP. > > Signed-off-by: Laurent Pinchart > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 60 +++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 2dd60e3252f3..2a374a4c14a2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1239,6 +1239,66 @@ ldb_lvds_ch1: endpoint { > }; > }; > > + mipi_csi_0: csi@32e40000 { > + compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2"; > + reg = <0x32e40000 0x10000>; > + interrupts = ; > + clock-frequency = <500000000>; > + clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>; > + clock-names = "pclk", "wrap", "phy", "axi"; > + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_CAM1_PIX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>; > + assigned-clock-rates = <500000000>; > + power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; If we would add: mipi_csi_0_in: endpoint {}; here we could refernce it from overlays/board dts files more easily. Regards, Marco > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > + }; > + > + mipi_csi_1: csi@32e50000 { > + compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2"; > + reg = <0x32e50000 0x10000>; > + interrupts = ; > + clock-frequency = <266000000>; > + clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_CAM2_PIX_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>; > + clock-names = "pclk", "wrap", "phy", "axi"; > + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_CAM2_PIX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>; > + assigned-clock-rates = <266000000>; > + power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > + }; > + > pcie_phy: pcie-phy@32f00000 { > compatible = "fsl,imx8mp-pcie-phy"; > reg = <0x32f00000 0x10000>; > -- > Regards, > > Laurent Pinchart > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E7CAC77B77 for ; Mon, 17 Apr 2023 06:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iOioH1DalbxLUtl766P7AWzra9FAwN0Tr2bK+XOzkOM=; b=SooEVmwIEQ+bxL MzoIHaTto0O9BislU8pZzrju7l85MruKEACaU3EYoAaZgE2WuCFupnNvIMHvg2KvOdLRitKKh/Yz2 lJeM1INJOux3s0/JraoxNM0WWcbpi9QHZVtuJxnqjJbPg0AqbJABH55TKgAvIKeeuu19aH1eAZGkj jOc84y7RhUAl3oBcZXEGlhZxu/qlC18jdzabweNsX+9vuHqRJGYyrtfKz7lVpwsYSkN3NBUFGHCZ2 WjIESf3eb/z1WuM+JRjmbxBI0s2vxPYazIrLft9i1y1M3ImplE645uMpJc01v4m74XCcjQRoS8Jzk IRN6Ee9B5Xq31Zi204Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poIhp-00F5M4-0m; Mon, 17 Apr 2023 06:51:17 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poIhe-00F5HU-0z for linux-arm-kernel@lists.infradead.org; Mon, 17 Apr 2023 06:51:10 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poIha-0000ao-VI; Mon, 17 Apr 2023 08:51:02 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1poIhX-00044M-V5; Mon, 17 Apr 2023 08:50:59 +0200 Date: Mon, 17 Apr 2023 08:50:59 +0200 From: Marco Felsch To: Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Xavier Roumegue , Rob Herring , linux-imx@nxp.com, Krzysztof Kozlowski , Jacopo Mondi , Shawn Guo , linux-media@vger.kernel.org Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes Message-ID: <20230417065059.fgmdfwk7pnj62amm@pengutronix.de> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230416_235106_342270_9F033D53 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, your patch LGTM just one nit/idea, please see below. On 23-04-17, Laurent Pinchart wrote: > Add DT nodes for the two CSI-2 receivers of the i.MX8MP. > > Signed-off-by: Laurent Pinchart > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 60 +++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 2dd60e3252f3..2a374a4c14a2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1239,6 +1239,66 @@ ldb_lvds_ch1: endpoint { > }; > }; > > + mipi_csi_0: csi@32e40000 { > + compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2"; > + reg = <0x32e40000 0x10000>; > + interrupts = ; > + clock-frequency = <500000000>; > + clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>; > + clock-names = "pclk", "wrap", "phy", "axi"; > + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_CAM1_PIX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>; > + assigned-clock-rates = <500000000>; > + power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; If we would add: mipi_csi_0_in: endpoint {}; here we could refernce it from overlays/board dts files more easily. Regards, Marco > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > + }; > + > + mipi_csi_1: csi@32e50000 { > + compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2"; > + reg = <0x32e50000 0x10000>; > + interrupts = ; > + clock-frequency = <266000000>; > + clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_CAM2_PIX_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>; > + clock-names = "pclk", "wrap", "phy", "axi"; > + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_CAM2_PIX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>; > + assigned-clock-rates = <266000000>; > + power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_2>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > + }; > + > pcie_phy: pcie-phy@32f00000 { > compatible = "fsl,imx8mp-pcie-phy"; > reg = <0x32f00000 0x10000>; > -- > Regards, > > Laurent Pinchart > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel