From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB9CC6FD18 for ; Tue, 18 Apr 2023 19:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjDRTJ1 (ORCPT ); Tue, 18 Apr 2023 15:09:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232742AbjDRTJX (ORCPT ); Tue, 18 Apr 2023 15:09:23 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D55A7AAE for ; Tue, 18 Apr 2023 12:09:07 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-552f169d85eso45050047b3.13 for ; Tue, 18 Apr 2023 12:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681844946; x=1684436946; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iNinZ/xtW0ZVHNrwkVxIEbNSe13fqzLdKKr8yvRoE6Q=; b=5KSRwCuwMyrWMDBBcG/2qLwTpPHtKAMowKCiYtJuWD677A0UXbzGo0q/j1L9X2nkwT /hhHbfJnm7Hqc+akjWuhWRfRa9Di+SCcPtKhuNFFSh05wLVH16h4SPITGgjk/DNdCSav lDRw53gtqwSId6DXnuqEewZ1QZWZ/+ev5ui6QrZ5DX3dQiis0PHO2QaM9DoOAhSFWT2n 97KqM+M6HutWEDT3mcSJj+RhKc+hH7HL76NKsWUUidq7mkr7yfKaWBWGKGRKm9w8lxeP cYc2zt9hH+9Iug0bGJn4nX08OFaWQREGVYhcO+nHeVZenJS4Tqxuz6zoajfhTyCE7bW2 vwYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681844946; x=1684436946; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iNinZ/xtW0ZVHNrwkVxIEbNSe13fqzLdKKr8yvRoE6Q=; b=DAO/1Op3bMm29upjh+tprLnowkbLR5RySSyJWPVMmRC6QW09FaERRKkrxpTCMxeoTW ACSBaHUDAJq0in0g+3pMTJ8G3wDYzmnaqlRzxqiLqoELJnAnXqLzbqX50qzA56ILDfpp uR0dp790DzfzCVTrHxVpqAD+ZewFl2XzDHMS1TdV0DGTeTWmrfOeGUGCXy8gl/qXv9ER 84Q3yOoHS4xdVeSEJf6AbYIXkOzQwfRABliJF9ijVRkjw1nvvQRJ0MKldtaWsyRsKSO6 9R6L3+0EZ69Sw03ojGUgkaYk8cI0BDLNZhBmsFVhEGOinfko5PMx2NYKAdVMzzVxen6Y YqPg== X-Gm-Message-State: AAQBX9cXSX/W3PhAB1Mo98+d+GLcfoI0UgNnUZ671r/7cJ9euP+wfOgq a9WYxY0PqYpcU2XhJDMNBd8vDdCXEC4zT5UM X-Google-Smtp-Source: AKy350YWGJFweuXeHcx9cUcke+9jMuVzygNWAx4ledq3nz33xrIMBM/epux3EmdAsS26KjKWBxYShjH22qlzY9nD X-Received: from vannapurve2.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:41f8]) (user=vannapurve job=sendgmr) by 2002:a25:cf4c:0:b0:b8f:47c4:58ed with SMTP id f73-20020a25cf4c000000b00b8f47c458edmr12907520ybg.9.1681844946790; Tue, 18 Apr 2023 12:09:06 -0700 (PDT) Date: Tue, 18 Apr 2023 19:09:04 +0000 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog Message-ID: <20230418190904.1111011-1-vannapurve@google.com> Subject: Re: [PATCH v13 098/113] KVM: TDX: Handle TDX PV map_gpa hypercall From: Vishal Annapurve To: isaku.yamahata@intel.com Cc: dmatlack@google.com, erdemaktas@google.com, isaku.yamahata@gmail.com, kai.huang@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, sagis@google.com, seanjc@google.com, zhi.wang.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int tdx_map_gpa(struct kvm_vcpu *vcpu) > +{ > + struct kvm *kvm = vcpu->kvm; > + gpa_t gpa = tdvmcall_a0_read(vcpu); > + gpa_t size = tdvmcall_a1_read(vcpu); > + gpa_t end = gpa + size; > + > + if (!IS_ALIGNED(gpa, PAGE_SIZE) || !IS_ALIGNED(size, PAGE_SIZE) || > + end < gpa || > + end > kvm_gfn_shared_mask(kvm) << (PAGE_SHIFT + 1) || > + kvm_is_private_gpa(kvm, gpa) != kvm_is_private_gpa(kvm, end)) { > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_INVALID_OPERAND); > + return 1; > + } > + > + return tdx_vp_vmcall_to_user(vcpu); This will result into exits to userspace for MMIO regions as well. Does it make sense to only exit to userspace for guest physical memory regions backed by memslots? > +} > +