From: Mark Hasemeyer <markhas@chromium.org>
To: stable@vger.kernel.org
Cc: bhelgaas@google.com, kai.heng.feng@canonical.com
Subject: [PATCH] PCI:ASPM: Remove pcie_aspm_pm_state_change()
Date: Fri, 21 Apr 2023 12:42:30 -0600 [thread overview]
Message-ID: <20230421184230.1468609-1-markhas@chromium.org> (raw)
commit 08d0cc5f34265d1a1e3031f319f594bd1970976c upstream.
This change is desired because without it, it has been observed that
re-applying aspm settings can cause the system to crash with certain pci
devices (ie. Genesys GL9755).
Tested by issuing 100 suspend/resume cycles on a symptomatic system running
5.15.107.
L1 settings looked identical before and after:
```
localhost ~ # lspci -vvv -d 0x17a0: | grep L1Sub
L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+ L1_PM_Substates+
L1SubCtl1: PCI-PM_L1.2- PCI-PM_L1.1+ ASPM_L1.2- ASPM_L1.1+
L1SubCtl2: T_PwrOn=3100us
```
Cc: <stable@vger.kernel.org> # 5.15.y
next reply other threads:[~2023-04-21 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 18:42 Mark Hasemeyer [this message]
2023-04-23 10:30 ` [PATCH] PCI:ASPM: Remove pcie_aspm_pm_state_change() Greg KH
2023-04-24 18:35 ` Mark Hasemeyer
2023-04-25 5:08 ` Greg KH
2023-04-25 17:34 ` Mark Hasemeyer
-- strict thread matches above, loose matches on Subject: below --
2023-04-21 18:33 Mark Hasemeyer
2022-05-09 7:36 Kai-Heng Feng
2022-06-21 2:27 ` Kai-Heng Feng
2022-07-11 23:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421184230.1468609-1-markhas@chromium.org \
--to=markhas@chromium.org \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.