From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7121C77B7E for ; Tue, 2 May 2023 13:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbjEBNlQ (ORCPT ); Tue, 2 May 2023 09:41:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233975AbjEBNkm (ORCPT ); Tue, 2 May 2023 09:40:42 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92917285; Tue, 2 May 2023 06:39:58 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A12CC1F8D7; Tue, 2 May 2023 13:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683034729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=crvNNZKHkX0qSv+47z6gi2siVKpNnXpyMa5UXHMzqQg=; b=PgbCIBlRsSh3JTLYfKjClKjprcbn9dDOrwzSI48oqzC8Za6rSjZhTcRjbJjhx3G3GcUMkH GDsVgc3VXNyAOEWuPPYC5uPNP2NyBoVzTWJS+KMhzu7OfTRSmbGsT1gF66FpRWV4RR5iLx 0F70pNiNbLtU19jYvzEwRru7w+Zqp9U= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 651B2134FB; Tue, 2 May 2023 13:38:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Wx3hF2kSUWTOYQAAMHmgww (envelope-from ); Tue, 02 May 2023 13:38:49 +0000 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Alexander Viro , Christian Brauner , Tejun Heo , Zefan Li , Johannes Weiner , Dave Chinner , Rik van Riel , Jiri Wiesner Subject: [RFC PATCH 0/3] Rework locking when rendering mountinfo cgroup paths Date: Tue, 2 May 2023 15:38:44 +0200 Message-Id: <20230502133847.14570-1-mkoutny@suse.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Idea for these modification came up when css_set_lock seemed unneeded in cgroup_show_path. It's a delicate change, so the deciding factor was when cgroup_show_path popped up also in some profiles of frequent mountinfo readers. The idea is to trade the exclusive css_set_lock for the shared namespace_sem when rendering cgroup paths. Details are described more in individual commits. Michal Koutný (3): cgroup: Drop unused function for cgroup_path cgroup: Rely on namespace_sem in current_cgns_cgroup_from_root explicitly cgroup: Do not take css_set_lock in cgroup_show_path fs/namespace.c | 5 +++- include/linux/mount.h | 4 +++ kernel/cgroup/cgroup.c | 58 ++++++++---------------------------------- 3 files changed, 18 insertions(+), 49 deletions(-) -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= Subject: [RFC PATCH 0/3] Rework locking when rendering mountinfo cgroup paths Date: Tue, 2 May 2023 15:38:44 +0200 Message-ID: <20230502133847.14570-1-mkoutny@suse.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683034729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=crvNNZKHkX0qSv+47z6gi2siVKpNnXpyMa5UXHMzqQg=; b=PgbCIBlRsSh3JTLYfKjClKjprcbn9dDOrwzSI48oqzC8Za6rSjZhTcRjbJjhx3G3GcUMkH GDsVgc3VXNyAOEWuPPYC5uPNP2NyBoVzTWJS+KMhzu7OfTRSmbGsT1gF66FpRWV4RR5iLx 0F70pNiNbLtU19jYvzEwRru7w+Zqp9U= List-ID: Content-Type: text/plain; charset="macroman" To: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Alexander Viro , Christian Brauner , Tejun Heo , Zefan Li , Johannes Weiner , Dave Chinner , Rik van Riel , Jiri Wiesner SWRlYSBmb3IgdGhlc2UgbW9kaWZpY2F0aW9uIGNhbWUgdXAgd2hlbiBjc3Nfc2V0X2xvY2sgc2Vl bWVkIHVubmVlZGVkIGluCmNncm91cF9zaG93X3BhdGguCkl0J3MgYSBkZWxpY2F0ZSBjaGFuZ2Us IHNvIHRoZSBkZWNpZGluZyBmYWN0b3Igd2FzIHdoZW4gY2dyb3VwX3Nob3dfcGF0aCBwb3BwZWQK dXAgYWxzbyBpbiBzb21lIHByb2ZpbGVzIG9mIGZyZXF1ZW50IG1vdW50aW5mbyByZWFkZXJzLgpU aGUgaWRlYSBpcyB0byB0cmFkZSB0aGUgZXhjbHVzaXZlIGNzc19zZXRfbG9jayBmb3IgdGhlIHNo YXJlZApuYW1lc3BhY2Vfc2VtIHdoZW4gcmVuZGVyaW5nIGNncm91cCBwYXRocy4gRGV0YWlscyBh cmUgZGVzY3JpYmVkIG1vcmUgaW4KaW5kaXZpZHVhbCBjb21taXRzLgoKTWljaGFsIEtvdXRuw70g KDMpOgogIGNncm91cDogRHJvcCB1bnVzZWQgZnVuY3Rpb24gZm9yIGNncm91cF9wYXRoCiAgY2dy b3VwOiBSZWx5IG9uIG5hbWVzcGFjZV9zZW0gaW4gY3VycmVudF9jZ25zX2Nncm91cF9mcm9tX3Jv b3QKICAgIGV4cGxpY2l0bHkKICBjZ3JvdXA6IERvIG5vdCB0YWtlIGNzc19zZXRfbG9jayBpbiBj Z3JvdXBfc2hvd19wYXRoCgogZnMvbmFtZXNwYWNlLmMgICAgICAgICB8ICA1ICsrKy0KIGluY2x1 ZGUvbGludXgvbW91bnQuaCAgfCAgNCArKysKIGtlcm5lbC9jZ3JvdXAvY2dyb3VwLmMgfCA1OCAr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pCgotLSAKMi40MC4xCgo=