From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6B6C77B7E for ; Tue, 2 May 2023 13:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233935AbjEBNjv (ORCPT ); Tue, 2 May 2023 09:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234101AbjEBNja (ORCPT ); Tue, 2 May 2023 09:39:30 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F30C6E87; Tue, 2 May 2023 06:38:56 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D19311FD63; Tue, 2 May 2023 13:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683034729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAg4rxVkAQ9qbbHiRpMQeKxQl0QBkdUCjNX5t2zLxPg=; b=ucryHQBDna3EZnuiMh3G9y4iAHPKeJYgG5vW3YRNWNx+RmQanqEifFfVPpU4RuNZvgpLzK dMzvFoUWdePAEGbT1Akvg+MJoZuf3pHOAN0HwewEt2EjQLKqfdq4pEq4k4CABGqPdn/hh6 72u9XPh9PqGjmr7yHuob9GzfKzp2ql8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A245C139D2; Tue, 2 May 2023 13:38:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2MHVJmkSUWTOYQAAMHmgww (envelope-from ); Tue, 02 May 2023 13:38:49 +0000 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Cc: Alexander Viro , Christian Brauner , Tejun Heo , Zefan Li , Johannes Weiner , Dave Chinner , Rik van Riel , Jiri Wiesner Subject: [RFC PATCH 1/3] cgroup: Drop unused function for cgroup_path Date: Tue, 2 May 2023 15:38:45 +0200 Message-Id: <20230502133847.14570-2-mkoutny@suse.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230502133847.14570-1-mkoutny@suse.com> References: <20230502133847.14570-1-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no current user and there are alternative methods to obtain task's cgroup path. Signed-off-by: Michal Koutný --- kernel/cgroup/cgroup.c | 39 --------------------------------------- 1 file changed, 39 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 625d7483951c..55e5f0110e3b 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -2378,45 +2378,6 @@ int cgroup_path_ns(struct cgroup *cgrp, char *buf, size_t buflen, } EXPORT_SYMBOL_GPL(cgroup_path_ns); -/** - * task_cgroup_path - cgroup path of a task in the first cgroup hierarchy - * @task: target task - * @buf: the buffer to write the path into - * @buflen: the length of the buffer - * - * Determine @task's cgroup on the first (the one with the lowest non-zero - * hierarchy_id) cgroup hierarchy and copy its path into @buf. This - * function grabs cgroup_mutex and shouldn't be used inside locks used by - * cgroup controller callbacks. - * - * Return value is the same as kernfs_path(). - */ -int task_cgroup_path(struct task_struct *task, char *buf, size_t buflen) -{ - struct cgroup_root *root; - struct cgroup *cgrp; - int hierarchy_id = 1; - int ret; - - cgroup_lock(); - spin_lock_irq(&css_set_lock); - - root = idr_get_next(&cgroup_hierarchy_idr, &hierarchy_id); - - if (root) { - cgrp = task_cgroup_from_root(task, root); - ret = cgroup_path_ns_locked(cgrp, buf, buflen, &init_cgroup_ns); - } else { - /* if no hierarchy exists, everyone is in "/" */ - ret = strscpy(buf, "/", buflen); - } - - spin_unlock_irq(&css_set_lock); - cgroup_unlock(); - return ret; -} -EXPORT_SYMBOL_GPL(task_cgroup_path); - /** * cgroup_attach_lock - Lock for ->attach() * @lock_threadgroup: whether to down_write cgroup_threadgroup_rwsem -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Michal=20Koutn=C3=BD?= Subject: [RFC PATCH 1/3] cgroup: Drop unused function for cgroup_path Date: Tue, 2 May 2023 15:38:45 +0200 Message-ID: <20230502133847.14570-2-mkoutny@suse.com> References: <20230502133847.14570-1-mkoutny@suse.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1683034729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAg4rxVkAQ9qbbHiRpMQeKxQl0QBkdUCjNX5t2zLxPg=; b=ucryHQBDna3EZnuiMh3G9y4iAHPKeJYgG5vW3YRNWNx+RmQanqEifFfVPpU4RuNZvgpLzK dMzvFoUWdePAEGbT1Akvg+MJoZuf3pHOAN0HwewEt2EjQLKqfdq4pEq4k4CABGqPdn/hh6 72u9XPh9PqGjmr7yHuob9GzfKzp2ql8= In-Reply-To: <20230502133847.14570-1-mkoutny-IBi9RG/b67k@public.gmane.org> List-ID: Content-Type: text/plain; charset="macroman" To: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Alexander Viro , Christian Brauner , Tejun Heo , Zefan Li , Johannes Weiner , Dave Chinner , Rik van Riel , Jiri Wiesner VGhlcmUgaXMgbm8gY3VycmVudCB1c2VyIGFuZCB0aGVyZSBhcmUgYWx0ZXJuYXRpdmUgbWV0aG9k cyB0byBvYnRhaW4KdGFzaydzIGNncm91cCBwYXRoLgoKU2lnbmVkLW9mZi1ieTogTWljaGFsIEtv dXRuw70gPG1rb3V0bnktSUJpOVJHL2I2N2tAcHVibGljLmdtYW5lLm9yZz4KLS0tCiBrZXJuZWwv Y2dyb3VwL2Nncm91cC5jIHwgMzkgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgMzkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEva2VybmVs L2Nncm91cC9jZ3JvdXAuYyBiL2tlcm5lbC9jZ3JvdXAvY2dyb3VwLmMKaW5kZXggNjI1ZDc0ODM5 NTFjLi41NWU1ZjAxMTBlM2IgMTAwNjQ0Ci0tLSBhL2tlcm5lbC9jZ3JvdXAvY2dyb3VwLmMKKysr IGIva2VybmVsL2Nncm91cC9jZ3JvdXAuYwpAQCAtMjM3OCw0NSArMjM3OCw2IEBAIGludCBjZ3Jv dXBfcGF0aF9ucyhzdHJ1Y3QgY2dyb3VwICpjZ3JwLCBjaGFyICpidWYsIHNpemVfdCBidWZsZW4s CiB9CiBFWFBPUlRfU1lNQk9MX0dQTChjZ3JvdXBfcGF0aF9ucyk7CiAKLS8qKgotICogdGFza19j Z3JvdXBfcGF0aCAtIGNncm91cCBwYXRoIG9mIGEgdGFzayBpbiB0aGUgZmlyc3QgY2dyb3VwIGhp ZXJhcmNoeQotICogQHRhc2s6IHRhcmdldCB0YXNrCi0gKiBAYnVmOiB0aGUgYnVmZmVyIHRvIHdy aXRlIHRoZSBwYXRoIGludG8KLSAqIEBidWZsZW46IHRoZSBsZW5ndGggb2YgdGhlIGJ1ZmZlcgot ICoKLSAqIERldGVybWluZSBAdGFzaydzIGNncm91cCBvbiB0aGUgZmlyc3QgKHRoZSBvbmUgd2l0 aCB0aGUgbG93ZXN0IG5vbi16ZXJvCi0gKiBoaWVyYXJjaHlfaWQpIGNncm91cCBoaWVyYXJjaHkg YW5kIGNvcHkgaXRzIHBhdGggaW50byBAYnVmLiAgVGhpcwotICogZnVuY3Rpb24gZ3JhYnMgY2dy b3VwX211dGV4IGFuZCBzaG91bGRuJ3QgYmUgdXNlZCBpbnNpZGUgbG9ja3MgdXNlZCBieQotICog Y2dyb3VwIGNvbnRyb2xsZXIgY2FsbGJhY2tzLgotICoKLSAqIFJldHVybiB2YWx1ZSBpcyB0aGUg c2FtZSBhcyBrZXJuZnNfcGF0aCgpLgotICovCi1pbnQgdGFza19jZ3JvdXBfcGF0aChzdHJ1Y3Qg dGFza19zdHJ1Y3QgKnRhc2ssIGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZmxlbikKLXsKLQlzdHJ1Y3Qg Y2dyb3VwX3Jvb3QgKnJvb3Q7Ci0Jc3RydWN0IGNncm91cCAqY2dycDsKLQlpbnQgaGllcmFyY2h5 X2lkID0gMTsKLQlpbnQgcmV0OwotCi0JY2dyb3VwX2xvY2soKTsKLQlzcGluX2xvY2tfaXJxKCZj c3Nfc2V0X2xvY2spOwotCi0Jcm9vdCA9IGlkcl9nZXRfbmV4dCgmY2dyb3VwX2hpZXJhcmNoeV9p ZHIsICZoaWVyYXJjaHlfaWQpOwotCi0JaWYgKHJvb3QpIHsKLQkJY2dycCA9IHRhc2tfY2dyb3Vw X2Zyb21fcm9vdCh0YXNrLCByb290KTsKLQkJcmV0ID0gY2dyb3VwX3BhdGhfbnNfbG9ja2VkKGNn cnAsIGJ1ZiwgYnVmbGVuLCAmaW5pdF9jZ3JvdXBfbnMpOwotCX0gZWxzZSB7Ci0JCS8qIGlmIG5v IGhpZXJhcmNoeSBleGlzdHMsIGV2ZXJ5b25lIGlzIGluICIvIiAqLwotCQlyZXQgPSBzdHJzY3B5 KGJ1ZiwgIi8iLCBidWZsZW4pOwotCX0KLQotCXNwaW5fdW5sb2NrX2lycSgmY3NzX3NldF9sb2Nr KTsKLQljZ3JvdXBfdW5sb2NrKCk7Ci0JcmV0dXJuIHJldDsKLX0KLUVYUE9SVF9TWU1CT0xfR1BM KHRhc2tfY2dyb3VwX3BhdGgpOwotCiAvKioKICAqIGNncm91cF9hdHRhY2hfbG9jayAtIExvY2sg Zm9yIC0+YXR0YWNoKCkKICAqIEBsb2NrX3RocmVhZGdyb3VwOiB3aGV0aGVyIHRvIGRvd25fd3Jp dGUgY2dyb3VwX3RocmVhZGdyb3VwX3J3c2VtCi0tIAoyLjQwLjEKCg==