From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD507C7EE21 for ; Thu, 4 May 2023 20:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WzhuB2athzhhTlNAVUJa4n3keQ+Kk58xR//nK+z0bLQ=; b=wnVU5DkkwxgoVl PELUBqOHRVXCFjG6u1B+LTtIf8LGZc+JS3DCQJxevjUhQh6DaqR3FCf8gmQfYE4/7z6O3c2hUF0gR rJT06budLeaZ62GKrLvuoHOmtz0PgAaHh7hzgWYNjn84L2g+8WR/bIHcl5Kaeyqt/HouEk08sv9MN S1SiRvVAdMnE+31UxVYy1Fl/ICqlpZmMT3v74IuP5dezHXxyojmTh9doQjrKZG75dYQ5MfyihADMK S2eBkTqv2fZ6ewhOY79stRPh4RhhGYHPl+4mUYFznwPLPjuXgt//5Gm8su+T3/Uwuaz5Kmxl6ephS tN+G/qigzd9W52L4rJLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pufpl-008xJ4-0a; Thu, 04 May 2023 20:45:49 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puetV-008qY8-0T for linux-arm-kernel@bombadil.infradead.org; Thu, 04 May 2023 19:45:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=BJVFo4ZS9Pw/fHWP5GrdZV8chyFzHk94J7i/XW6+fj0=; b=UI5JMvrEnGHdlNx4PykI6Pc4E3 ERehjmEv4SKqjLgVCa7c5lDxD5vZ6E98WR6XGN/63yoMR9XoPTTG3lTYKde+vJ4sPxIEuwSwAjBJx MAwQ/YTNA6P+X5/mZOthq6GlME7rLn8lbjQTBorCWi87L2GpWtcQVypgD4JmyGkN8R16alckbDJL2 e58KvRUh7mWtRJiZSRUuRqC3DwBi/SElUQpMZTIVTad0ywtNbQxpStfLRXpa+ygwpjvAg+6HmsQUC ziUdUkvFPFoFUgts12/kcnQKwhM+Iz3sLiY2rMvj9L4/sAdvS6Et7A5VA+fgGn9UQehNM8gemJ8fj hNf9HpEg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puetQ-001ovL-0y for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 19:45:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puet7-0007r8-5L; Thu, 04 May 2023 21:45:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1puet6-0018GN-G8; Thu, 04 May 2023 21:45:12 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1puet5-001JiC-Pc; Thu, 04 May 2023 21:45:11 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Patrice Chotard , Bjorn Andersson , Mathieu Poirier Cc: linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 16/18] remoteproc: st: Convert to platform remove callback returning void Date: Thu, 4 May 2023 21:44:51 +0200 Message-Id: <20230504194453.1150368-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> References: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1683; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=9Hpc+1nEHcry74XcdQCz/ksi4LbJ7ai5C+zSEEKp4lk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkVAnPj1ADWabic6+xCCxZOpEF0L+YTwAzs8WDz nHxlp6S+UCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZFQJzwAKCRCPgPtYfRL+ TlRoB/9zMKuw0qMffVkRack/9/Fg3t0DCVrKCyeQtlonarTOq8LhK71cPi9DDXwFWs+LtXbq4FW b/QkTsenI98/dYdGY+Kr8YTWTlUSc9CaXMB0X7NtLrUeyqgbGyBkWOr+wLK86G2GKcmTk9KGdiz scNU0aBcRIhVtszl6Wlq3CUtCCn1IUtdMkDmLR9LbZoXdAWNYnaFQhTk6ooYIywn6S1doESi1cH s9MfY8QagJVAZwaAmTWyDVOmvFO0B8UJFiq/oBLDaSqQZtuBRiqBKCJoELstljxY96PGFI5MX2p OIDgZep/ws2HG8sVhat/bbYYtCv/k9CXetB6l36m6Pt47JnA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_204532_516758_69688243 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClNpZ25lZC1vZmYtYnk6IFV3 ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Ci0tLQogZHJp dmVycy9yZW1vdGVwcm9jL3N0X3JlbW90ZXByb2MuYyB8IDYgKystLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMv cmVtb3RlcHJvYy9zdF9yZW1vdGVwcm9jLmMgYi9kcml2ZXJzL3JlbW90ZXByb2Mvc3RfcmVtb3Rl cHJvYy5jCmluZGV4IDNmMWI4OTYzNjM5Zi4uZTNjZTAxZDk4YjRjIDEwMDY0NAotLS0gYS9kcml2 ZXJzL3JlbW90ZXByb2Mvc3RfcmVtb3RlcHJvYy5jCisrKyBiL2RyaXZlcnMvcmVtb3RlcHJvYy9z dF9yZW1vdGVwcm9jLmMKQEAgLTQ0OCw3ICs0NDgsNyBAQCBzdGF0aWMgaW50IHN0X3Jwcm9jX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJcmV0dXJuIHJldDsKIH0KIAotc3Rh dGljIGludCBzdF9ycHJvY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKK3N0 YXRpYyB2b2lkIHN0X3Jwcm9jX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQog ewogCXN0cnVjdCBycHJvYyAqcnByb2MgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKIAlz dHJ1Y3Qgc3RfcnByb2MgKmRkYXRhID0gcnByb2MtPnByaXY7CkBAIC00NjIsMTMgKzQ2MiwxMSBA QCBzdGF0aWMgaW50IHN0X3Jwcm9jX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQogCQltYm94X2ZyZWVfY2hhbm5lbChkZGF0YS0+bWJveF9jaGFuW2ldKTsKIAogCXJwcm9jX2Zy ZWUocnByb2MpOwotCi0JcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJp dmVyIHN0X3Jwcm9jX2RyaXZlciA9IHsKIAkucHJvYmUgPSBzdF9ycHJvY19wcm9iZSwKLQkucmVt b3ZlID0gc3RfcnByb2NfcmVtb3ZlLAorCS5yZW1vdmVfbmV3ID0gc3RfcnByb2NfcmVtb3ZlLAog CS5kcml2ZXIgPSB7CiAJCS5uYW1lID0gInN0LXJwcm9jIiwKIAkJLm9mX21hdGNoX3RhYmxlID0g b2ZfbWF0Y2hfcHRyKHN0X3Jwcm9jX21hdGNoKSwKLS0gCjIuMzkuMgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4F7C7EE21 for ; Thu, 4 May 2023 21:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjEDVFU (ORCPT ); Thu, 4 May 2023 17:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbjEDVE4 (ORCPT ); Thu, 4 May 2023 17:04:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A6E14E76 for ; Thu, 4 May 2023 14:04:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puet7-0007r8-5L; Thu, 04 May 2023 21:45:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1puet6-0018GN-G8; Thu, 04 May 2023 21:45:12 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1puet5-001JiC-Pc; Thu, 04 May 2023 21:45:11 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Patrice Chotard , Bjorn Andersson , Mathieu Poirier Cc: linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 16/18] remoteproc: st: Convert to platform remove callback returning void Date: Thu, 4 May 2023 21:44:51 +0200 Message-Id: <20230504194453.1150368-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> References: <20230504194453.1150368-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1683; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=9Hpc+1nEHcry74XcdQCz/ksi4LbJ7ai5C+zSEEKp4lk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkVAnPj1ADWabic6+xCCxZOpEF0L+YTwAzs8WDz nHxlp6S+UCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZFQJzwAKCRCPgPtYfRL+ TlRoB/9zMKuw0qMffVkRack/9/Fg3t0DCVrKCyeQtlonarTOq8LhK71cPi9DDXwFWs+LtXbq4FW b/QkTsenI98/dYdGY+Kr8YTWTlUSc9CaXMB0X7NtLrUeyqgbGyBkWOr+wLK86G2GKcmTk9KGdiz scNU0aBcRIhVtszl6Wlq3CUtCCn1IUtdMkDmLR9LbZoXdAWNYnaFQhTk6ooYIywn6S1doESi1cH s9MfY8QagJVAZwaAmTWyDVOmvFO0B8UJFiq/oBLDaSqQZtuBRiqBKCJoELstljxY96PGFI5MX2p OIDgZep/ws2HG8sVhat/bbYYtCv/k9CXetB6l36m6Pt47JnA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-remoteproc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/remoteproc/st_remoteproc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c index 3f1b8963639f..e3ce01d98b4c 100644 --- a/drivers/remoteproc/st_remoteproc.c +++ b/drivers/remoteproc/st_remoteproc.c @@ -448,7 +448,7 @@ static int st_rproc_probe(struct platform_device *pdev) return ret; } -static int st_rproc_remove(struct platform_device *pdev) +static void st_rproc_remove(struct platform_device *pdev) { struct rproc *rproc = platform_get_drvdata(pdev); struct st_rproc *ddata = rproc->priv; @@ -462,13 +462,11 @@ static int st_rproc_remove(struct platform_device *pdev) mbox_free_channel(ddata->mbox_chan[i]); rproc_free(rproc); - - return 0; } static struct platform_driver st_rproc_driver = { .probe = st_rproc_probe, - .remove = st_rproc_remove, + .remove_new = st_rproc_remove, .driver = { .name = "st-rproc", .of_match_table = of_match_ptr(st_rproc_match), -- 2.39.2