From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB708C7EE2D for ; Tue, 9 May 2023 21:19:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235729AbjEIVTy (ORCPT ); Tue, 9 May 2023 17:19:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234934AbjEIVTm (ORCPT ); Tue, 9 May 2023 17:19:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F9B30F0; Tue, 9 May 2023 14:19:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F98A634CE; Tue, 9 May 2023 21:19:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15CA3C433D2; Tue, 9 May 2023 21:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683667177; bh=YiOsMtl98E05Kazdf4l0D33RTjcr/FcSs8FHjbYQngk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QDND55Om1vRj5NeYZWiYg3jlUIa0mQw+6bswzHGe+fp71KRK9RU2Vt3GaeMrUb0ZR RtqAuCsdat+t59/1QTaq6NwSt3KorGEr1O7e9Queix6dFYDI75jfcJ5N41BtwjOgdX A3ClxncxE8kP1ewpAn+irkfJFaGJudXpyfZHRS2dAl3B2auSnyXiIwy2Rz2X0pZ1pz tRT0xO226Pp4oZhLcvj4ren4qt1nb4AkWZ/ny0liNUV7a3YvZpZ1Z45QFG60DhrkvJ s3iGg4z+TJnCpwanIHdC/PlAosxmrhqNK4vOFBg1/YJlmbwp/kkueHfTbyYobPCTGP VPuUclURq3ELQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ivan Orlov , Sean Christopherson , Sasha Levin , pbonzini@redhat.com, shuah@kernel.org, dmatlack@google.com, vannapurve@google.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 02/18] KVM: selftests: Add 'malloc' failure check in vcpu_save_state Date: Tue, 9 May 2023 17:19:10 -0400 Message-Id: <20230509211928.21010-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230509211928.21010-1-sashal@kernel.org> References: <20230509211928.21010-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Orlov [ Upstream commit 735b0e0f2d001b7ed9486db84453fb860e764a4d ] There is a 'malloc' call in vcpu_save_state function, which can be unsuccessful. This patch will add the malloc failure checking to avoid possible null dereference and give more information about test fail reasons. Signed-off-by: Ivan Orlov Link: https://lore.kernel.org/r/20230322144528.704077-1-ivan.orlov0322@gmail.com Signed-off-by: Sean Christopherson Signed-off-by: Sasha Levin --- tools/testing/selftests/kvm/lib/x86_64/processor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c index c39a4353ba194..827647ff3d41b 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c @@ -954,6 +954,7 @@ struct kvm_x86_state *vcpu_save_state(struct kvm_vcpu *vcpu) vcpu_run_complete_io(vcpu); state = malloc(sizeof(*state) + msr_list->nmsrs * sizeof(state->msrs.entries[0])); + TEST_ASSERT(state, "-ENOMEM when allocating kvm state"); vcpu_events_get(vcpu, &state->events); vcpu_mp_state_get(vcpu, &state->mp_state); -- 2.39.2