From: Dylan Van Assche <me@dylanvanassche.be>
To: srinivas.kandagatla@linaro.org, amahesh@qti.qualcomm.com,
arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, dan.carpenter@linaro.org,
Dylan Van Assche <me@dylanvanassche.be>,
Caleb Connolly <caleb.connolly@linaro.org>
Subject: [PATCH v4 1/2] misc: fastrpc: support complete DMA pool access to the DSP
Date: Thu, 11 May 2023 16:11:45 +0200 [thread overview]
Message-ID: <20230511141146.30465-2-me@dylanvanassche.be> (raw)
In-Reply-To: <20230511141146.30465-1-me@dylanvanassche.be>
To support FastRPC Context Banks which aren't mapped via the SMMU,
make the whole reserved memory region available to the DSP to allow
access to coherent buffers.
This is performed by assigning the memory to the DSP via a hypervisor
call to set the correct permissions for the Virtual Machines on the DSP.
This is only necessary when a memory region is provided for SLPI DSPs
so guard this with a domain ID check.
Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
---
drivers/misc/fastrpc.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index f48466960f1b..1ced553ae959 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -2231,6 +2231,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
int i, err, domain_id = -1, vmcount;
const char *domain;
bool secure_dsp;
+ struct device_node *rmem_node;
+ struct reserved_mem *rmem;
unsigned int vmids[FASTRPC_MAX_VMIDS];
err = of_property_read_string(rdev->of_node, "label", &domain);
@@ -2274,6 +2276,19 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
}
}
+ rmem_node = of_parse_phandle(rdev->of_node, "memory-region", 0);
+ if (domain_id == SDSP_DOMAIN_ID && rmem_node) {
+ rmem = of_reserved_mem_lookup(rmem_node);
+ if (!rmem) {
+ err = -EINVAL;
+ goto fdev_error;
+ }
+
+ qcom_scm_assign_mem(rmem->base, rmem->size, &data->perms,
+ data->vmperms, data->vmcount);
+
+ }
+
secure_dsp = !(of_property_read_bool(rdev->of_node, "qcom,non-secure-domain"));
data->secure = secure_dsp;
--
2.40.1
next prev parent reply other threads:[~2023-05-11 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 14:11 [PATCH v4 0/2] misc: fastrpc: FastRPC reserved memory assignment for SDM845 SLPI Dylan Van Assche
2023-05-11 14:11 ` Dylan Van Assche [this message]
2023-05-30 10:52 ` [PATCH v4 1/2] misc: fastrpc: support complete DMA pool access to the DSP Srinivas Kandagatla
2023-05-30 13:31 ` Caleb Connolly
2023-05-11 14:11 ` [PATCH v4 2/2] misc: fastrpc: use coherent pool for untranslated Compute Banks Dylan Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511141146.30465-2-me@dylanvanassche.be \
--to=me@dylanvanassche.be \
--cc=amahesh@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=caleb.connolly@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.