All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Jia <jiahao.os@bytedance.com>
To: mingo@redhat.com, peterz@infradead.org, mingo@kernel.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
	vschneid@redhat.com, mgorman@techsingularity.net
Cc: linux-kernel@vger.kernel.org, Hao Jia <jiahao.os@bytedance.com>
Subject: [PATCH v3 0/4] Fix some warnings about rq clock
Date: Mon, 15 May 2023 14:38:44 +0800	[thread overview]
Message-ID: <20230515063848.77947-1-jiahao.os@bytedance.com> (raw)

These four patches fix some warnings about rq clock.

Patch1 fixes the warning of using the old rq clock caused by
missing update rq clock.

Patch2-4 fixes the warning that the rq clock was updated multiple
times while holding the rq lock.

v2->v3:
    - Modify the commit information of patch1 to make the description clearer.
    - Split v2 patch2 into 3 separate patches.

v1->v2:
    - Vincent Guittot suggested using rq_clock_start_loop_update()
      to prevent multiple calls to update_rq_clock() in unthrottle_cfs_rq()
      instead of removing update_rq_clock() from unthrottle_cfs_rq()
      and updating the rq clock before unthrottle_cfs_rq() for patch2.

[v2] https://lore.kernel.org/all/20230510083450.62334-1-jiahao.os@bytedance.com
[v1] https://lore.kernel.org/all/20230410081206.23441-1-jiahao.os@bytedance.com


Hao Jia (4):
  sched/core: Fixed missing rq clock update before calling
    set_rq_offline()
  sched/core: Avoid double calling update_rq_clock() in
    __balance_push_cpu_stop()
  sched/core: Avoid multiple calling update_rq_clock() in
    __cfsb_csd_unthrottle()
  sched/core: Avoid multiple calling update_rq_clock() in
    unthrottle_offline_cfs_rqs()

 kernel/sched/core.c     |  7 ++++---
 kernel/sched/fair.c     | 18 ++++++++++++++++++
 kernel/sched/sched.h    | 21 +++++++++++++++++++++
 kernel/sched/topology.c | 10 ++++++----
 4 files changed, 49 insertions(+), 7 deletions(-)

-- 
2.37.0


             reply	other threads:[~2023-05-15  6:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  6:38 Hao Jia [this message]
2023-05-15  6:38 ` [PATCH v3 1/4] sched/core: Fixed missing rq clock update before calling set_rq_offline() Hao Jia
2023-05-15 13:29   ` Vincent Guittot
2023-05-15  6:38 ` [PATCH v3 2/4] sched/core: Avoid double calling update_rq_clock() in __balance_push_cpu_stop() Hao Jia
2023-05-15 13:29   ` Vincent Guittot
2023-05-15  6:38 ` [PATCH v3 3/4] sched/core: Avoid multiple calling update_rq_clock() in __cfsb_csd_unthrottle() Hao Jia
2023-05-15 13:30   ` Vincent Guittot
2023-05-15  6:38 ` [PATCH v3 4/4] sched/core: Avoid multiple calling update_rq_clock() in unthrottle_offline_cfs_rqs() Hao Jia
2023-05-15 13:30   ` Vincent Guittot
2023-05-23  7:52 ` [PATCH v3 0/4] Fix some warnings about rq clock Hao Jia
2023-06-01  9:14 ` Hao Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230515063848.77947-1-jiahao.os@bytedance.com \
    --to=jiahao.os@bytedance.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.