From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B09FC77B7D for ; Mon, 15 May 2023 21:12:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1ED0384663; Mon, 15 May 2023 23:12:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="t16XMeqR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FD3F82721; Mon, 15 May 2023 23:12:34 +0200 (CEST) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8AC27847B0 for ; Mon, 15 May 2023 23:12:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-ba716790926so5861070276.2 for ; Mon, 15 May 2023 14:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1684185149; x=1686777149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=33dzBJ7WuM9x803d4ix3tmdpzsM1lTqxN/Ta/+wtPv4=; b=t16XMeqReoE15IlUmjv10PdA9T3+A2aFRC4aj+hGbPyvB5MCt5oPEdb21ggtvZsgsj AoFBVZXyhfrJrq/hvEK0iVOGf4obpx/WAnIILl4R3HTL0szab4wTvob736NwLwZ++6NA KCsRj2bv0/Tbz54IIgj7hsiC5lG923fuR9y0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684185149; x=1686777149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=33dzBJ7WuM9x803d4ix3tmdpzsM1lTqxN/Ta/+wtPv4=; b=LE4AXB/dfQyaKlfhSEPk499PelO39Oo4iSoF6gyUKsazpdOf+s2aE8gdqlyBj3MKQP 0EmWFDAenaUAP8fEh5hPLx3wHd82DWYf7SRUoFDD12vOqvZl+IqkeBrnC1d3fbbux+ir WmUFcOWZajV2MYwJypqVMrP5wKZlnKLOVF12B/So4IgjcwSiWhXRGHYlZUaGp9NCF9W8 6XpVBw/5ELKjsB+vKs0LBKsPk1JbVgGLygaXscSHyq36Y+omQu+0p1gVUIBE8J4m0yTo 4WZIIfNyGwNUhRWLJVkkKhcYigJLsI4ZF/rX8rQcGZ+ZhoJWAbcUw/04KmAubLr/u8kZ EWow== X-Gm-Message-State: AC+VfDyb1cjCjUINONS5I/vSCd2OMHMojbR/EXCk1quoApXlXkD6RyQV sbR+hmUKGTIc0/ulh98YVUbk3g== X-Google-Smtp-Source: ACHHUZ4jigU4F91jntjtntFejUIhwU/oMv5i4WqifAvP8xYS2XuUE2qK2j3JJh1t+Xd6LKBgPr2jQQ== X-Received: by 2002:a25:641:0:b0:b9e:d6ac:6941 with SMTP id 62-20020a250641000000b00b9ed6ac6941mr29989730ybg.8.1684185149230; Mon, 15 May 2023 14:12:29 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b213-426d-36fe-d1f1.res6.spectrum.com. [2603:6081:7b00:6400:b213:426d:36fe:d1f1]) by smtp.gmail.com with ESMTPSA id s5-20020a255e05000000b00b7767ca7485sm78732ybb.34.2023.05.15.14.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 14:12:28 -0700 (PDT) Date: Mon, 15 May 2023 17:12:27 -0400 From: Tom Rini To: Frieder Schrempf , Michael Nazzareno Trimarchi , Dario Binacchi Cc: Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation Message-ID: <20230515211227.GP2398826@bill-the-cat> References: <20230110115843.391630-1-frieder@fris.de> <9d83d7ae-a69c-1584-fabf-c2dd0e1d1b67@kontron.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lngNZO2Wp1J15xyy" Content-Disposition: inline In-Reply-To: <9d83d7ae-a69c-1584-fabf-c2dd0e1d1b67@kontron.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --lngNZO2Wp1J15xyy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 09, 2023 at 09:09:28AM +0200, Frieder Schrempf wrote: > Hi Michael, hi Dario, >=20 > On 18.04.23 15:46, Frieder Schrempf wrote: > > Hi Michael, Dario, > >=20 > > On 28.03.23 09:57, Frieder Schrempf wrote: > >> Hi Michael, > >> > >> On 10.02.23 12:57, Michael Nazzareno Trimarchi wrote: > >>> Hi > >>> > >>> I will review > >>> > >>> On Thu, Feb 9, 2023 at 5:52 PM Tom Rini wrote: > >>>> > >>>> On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > >>>>> Hi, > >>>>> > >>>>> On 10.01.23 12:58, Frieder Schrempf wrote: > >>>>>> From: Mikhail Kshevetskiy > >>>>>> > >>>>>> Currently there are 3 different variants of read_id implementation: > >>>>>> 1. opcode only. Found in GD5FxGQ4xF. > >>>>>> 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > >>>>>> 3. opcode + 1 dummy byte. Found in other currently supported chips. > >>>>>> > >>>>>> Original implementation was for variant 1 and let detect function > >>>>>> of chips with variant 2 and 3 to ignore the first byte. This isn't > >>>>>> robust: > >>>>>> > >>>>>> 1. For chips of variant 2, if SPI master doesn't keep MOSI low > >>>>>> during read, chip will get a random id offset, and the entire id > >>>>>> buffer will shift by that offset, causing detect failure. > >>>>>> > >>>>>> 2. For chips of variant 1, if it happens to get a devid that equals > >>>>>> to manufacture id of variant 2 or 3 chips, it'll get incorrectly > >>>>>> detected. > >>>>>> > >>>>>> This patch reworks detect procedure to address problems above. New > >>>>>> logic do detection for all variants separatedly, in 1-2-3 order. > >>>>>> Since all current detect methods do exactly the same id matching > >>>>>> procedure, unify them into core.c and remove detect method from > >>>>>> manufacture_ops. > >>>>>> > >>>>>> This is a rework of Chuanhong Guo patch > >>>>>> submitted to linux kernel > >>>>>> > >>>>>> Signed-off-by: Mikhail Kshevetskiy > >>>>>> Signed-off-by: Frieder Schrempf > >>>>> > >>>>> +Cc: Jagan, Tom > >>>>> > >>>>> Who is supposed to pick up these patches? Some of them have been ar= ound > >>>>> for some months (before I resent them). > >>>>> > >>>>> There is no maintainer for drivers/mtd/spinand/ and no maintainer f= or > >>>>> drivers/mtd/ in general. > >>>>> > >>>>> In Patchwork Jagan got assigned, but the get_maintainer.pl script d= idn't > >>>>> even add him to Cc, of course. > >>>>> > >>>>> Any ideas how to proceed? > >>>> > >>>> We don't have anyone dedicated to that area, yes, sadly. I've added > >>>> Michael and Dario as they've also been doing mtd-but-not-spi work of > >>>> late to see if they're interested. Or since you've long been working > >>>> here, would you like to more formally maintain the area? Thanks! > >>> > >>> They can come from our tree. I will try to sort out all my duties wee= ked > >> > >> Any news regarding reviewing/picking these patches? > >=20 > > Ping! > >=20 > > Can you please apply these patches, that have been waiting for so long? >=20 > I still can't see this applied anywhere. You already told me to take > care of it multiple times. Can you please get it done? Yes, I'd really like to see a PR at least vs -next at this point so things aren't lost, thanks! --=20 Tom --lngNZO2Wp1J15xyy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRioDQACgkQFHw5/5Y0 tywmiwv/aw9JLAIU1C7niQFu9H6uC4NL4/08brJHZNnoREDWsh91rAUjaWMVF71c aqzMAUVp+M2UeoPOrC/D/r3+xTNBu4PtypZ1nYqJMGpmaRNlq1cVbRE/0v4B9SvK 7mMTQ03x8e8z/oheSyXz3BHolB/xhlXNRXlVoO3YxcXje69Gq9YUFt4cd4tm/ZxA yfMQh1NP3Xxe3RF3xpNNAe8+go8ToUu+tbHTklmmZnnYyMrmmY+E6dr3sHUTGsKx G6ZOfwUouasDPv/1Zg/mDdLnNQM61Nn/6aTThySw4plNyrgQkBgovXZHTxK8Ax45 vi9WQtwcwuETw7LABD5p4eZGisX4vOr7VpZabq1486qC3m5DEHIcCrhASXNC0PDM buVqWkgL4iQRtQ8u6rqpHCPLixMk2W6dk/u/nKaZ5Qd2yP4V4AanH/F7Uv98m53x OEEfsgSjPhtCvIw4EX8zo+2/kScmmC6OPGgeqv13kaGJ/MQy5MF5c0B6A4cPmO+j BRSVHPOr =0wa3 -----END PGP SIGNATURE----- --lngNZO2Wp1J15xyy--