From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C33FAC77B7F for ; Tue, 16 May 2023 16:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aUDn0xCsMeS54Y4Bcns5kI06rdTgnmxzcu0ztscH7gc=; b=NBWwdsyzg9yVm+ V5A43vUohDDJXicwtFD41kqQUgQa4ZSk/NXNPHqMQpSpjOE5EU61O1C3oizYbFGiEcYro4qa3L1q3 6gej7OMuhovbcceZeqz/057VQiGIA19NLv8w4KmksEOsj+pGAQByohPZsLywpXU3s0iQTVJwC0r5z BFU1urJqULdLJRUZU04yWi3Dv4GlweMhUBVIuCEq47rHevgdTbgP2OJBpqJhLPXIsKB7/uNRR7Tsb JG31O/qYWNPM7ZYfg8KUBWvXEooRgnOzmASgySXW6MF33NxXQoMUGDe+FtKCD4yFfFn14JkQ4Hxd2 JAMz6rD+eKGdGwRAHaEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyxEs-006Pql-1R; Tue, 16 May 2023 16:09:26 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyxEq-006Ppg-06; Tue, 16 May 2023 16:09:25 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QLLkX6b27z6D8jV; Wed, 17 May 2023 00:08:20 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 17:09:20 +0100 Date: Tue, 16 May 2023 17:09:19 +0100 From: Jonathan Cameron To: Sascha Hauer CC: , , Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , , Michael Riesch Subject: Re: [PATCH v4 12/21] PM / devfreq: rockchip-dfi: Handle LPDDR4X Message-ID: <20230516170919.00000dc4@Huawei.com> In-Reply-To: <20230505113856.463650-13-s.hauer@pengutronix.de> References: <20230505113856.463650-1-s.hauer@pengutronix.de> <20230505113856.463650-13-s.hauer@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_090924_216607_E6B2C35E X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, 5 May 2023 13:38:47 +0200 Sascha Hauer wrote: > In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add > the missing case. > > Signed-off-by: Sascha Hauer No equivalent for the DMC driver you moved to he defines earlier? I'm guessing not in which case this seems fine to me Reviewed-by: Jonathan Cameron > --- > drivers/devfreq/event/rockchip-dfi.c | 1 + > include/soc/rockchip/rockchip_grf.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 92ee61c96a1a9..dc48d9c26f599 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -89,6 +89,7 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev) > dfi_regs + DDRMON_CTRL); > break; > case ROCKCHIP_DDRTYPE_LPDDR4: > + case ROCKCHIP_DDRTYPE_LPDDR4X: > writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK), > dfi_regs + DDRMON_CTRL); > break; > diff --git a/include/soc/rockchip/rockchip_grf.h b/include/soc/rockchip/rockchip_grf.h > index dc77bb762a05a..7150a3362b142 100644 > --- a/include/soc/rockchip/rockchip_grf.h > +++ b/include/soc/rockchip/rockchip_grf.h > @@ -11,5 +11,6 @@ > #define ROCKCHIP_DDRTYPE_LPDDR2 5 > #define ROCKCHIP_DDRTYPE_LPDDR3 6 > #define ROCKCHIP_DDRTYPE_LPDDR4 7 > +#define ROCKCHIP_DDRTYPE_LPDDR4X 8 > > #endif /* __SOC_ROCKCHIP_GRF_H */ _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3978C77B7F for ; Tue, 16 May 2023 16:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9YpysxhgUjy0MmAxV/m6QsSBY5zNL9EgqWcowY1lz7Q=; b=O83zAurBk7AgRn Q4a19JkNZRTi4ruwrZr48Z0GkyWhlAk9N/YcJvzVQzeMaClhkN7aQ/HD7DduiXI28TVfLanFyd8oV Z5H/yy4Csvromcd6PKlY0xFG/bBiDH4f8oCLqMuyek5QYfuep2rGYLxXDFM6JqUSV0Dyc2TE0DAz9 TTWdksVMRYLvUaC9dp8QAS29nGOmZnj2iBG5Pp0VBrkQXtXQYewNFybr91z34J7GMR5Uy6yL+8NEW h36B3Zdp4wA/O0EQyR157DxWmAhVNfKrdnMISbLNUNzmMAezzsf3PSn+iZWSCKYuWDtho490Afbbg OcLVp+KDNcNPBQ//8gSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyxEr-006PqO-3D; Tue, 16 May 2023 16:09:26 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyxEq-006Ppg-06; Tue, 16 May 2023 16:09:25 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QLLkX6b27z6D8jV; Wed, 17 May 2023 00:08:20 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 17:09:20 +0100 Date: Tue, 16 May 2023 17:09:19 +0100 From: Jonathan Cameron To: Sascha Hauer CC: , , Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , , Michael Riesch Subject: Re: [PATCH v4 12/21] PM / devfreq: rockchip-dfi: Handle LPDDR4X Message-ID: <20230516170919.00000dc4@Huawei.com> In-Reply-To: <20230505113856.463650-13-s.hauer@pengutronix.de> References: <20230505113856.463650-1-s.hauer@pengutronix.de> <20230505113856.463650-13-s.hauer@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_090924_216607_E6B2C35E X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 5 May 2023 13:38:47 +0200 Sascha Hauer wrote: > In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add > the missing case. > > Signed-off-by: Sascha Hauer No equivalent for the DMC driver you moved to he defines earlier? I'm guessing not in which case this seems fine to me Reviewed-by: Jonathan Cameron > --- > drivers/devfreq/event/rockchip-dfi.c | 1 + > include/soc/rockchip/rockchip_grf.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 92ee61c96a1a9..dc48d9c26f599 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -89,6 +89,7 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev) > dfi_regs + DDRMON_CTRL); > break; > case ROCKCHIP_DDRTYPE_LPDDR4: > + case ROCKCHIP_DDRTYPE_LPDDR4X: > writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK), > dfi_regs + DDRMON_CTRL); > break; > diff --git a/include/soc/rockchip/rockchip_grf.h b/include/soc/rockchip/rockchip_grf.h > index dc77bb762a05a..7150a3362b142 100644 > --- a/include/soc/rockchip/rockchip_grf.h > +++ b/include/soc/rockchip/rockchip_grf.h > @@ -11,5 +11,6 @@ > #define ROCKCHIP_DDRTYPE_LPDDR2 5 > #define ROCKCHIP_DDRTYPE_LPDDR3 6 > #define ROCKCHIP_DDRTYPE_LPDDR4 7 > +#define ROCKCHIP_DDRTYPE_LPDDR4X 8 > > #endif /* __SOC_ROCKCHIP_GRF_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel