From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7732DC77B7A for ; Thu, 18 May 2023 18:08:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E5D0F40B53; Thu, 18 May 2023 18:08:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E5D0F40B53 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Hqukn0+s X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ssKHVhnQ7thZ; Thu, 18 May 2023 18:08:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6609541C9B; Thu, 18 May 2023 18:08:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6609541C9B Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1F1E0C0036; Thu, 18 May 2023 18:08:34 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8299DC002A for ; Thu, 18 May 2023 18:08:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5C50541403 for ; Thu, 18 May 2023 18:08:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5C50541403 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Hqukn0+s X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fbEhcu1cmxfs for ; Thu, 18 May 2023 18:08:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 69B40410E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 69B40410E7 for ; Thu, 18 May 2023 18:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684433310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EP8NV9ONBFRX7JUAfH+hASHYoMHOz+nZ6k5QS4Ruiow=; b=Hqukn0+sJoRADf9S62utw8QhG9d25nFsodf3dihI+gVrFqLp7sXwvi5Yk/+EKGtRMi65BC mz9PydDhL/kDj2Ikxc2o6Iv2eXSytZE6+o/bR96kzAWNaGNLTxPe838C7BXnQoRGLbAqRu tq0J9iH/ckIO2ETke6a/cfyt8gq1kEo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-JUfL8dQDNR-h3gj8vcQ0Lw-1; Thu, 18 May 2023 14:08:29 -0400 X-MC-Unique: JUfL8dQDNR-h3gj8vcQ0Lw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4399D800047; Thu, 18 May 2023 18:08:28 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.20]) by smtp.corp.redhat.com (Postfix) with SMTP id 451BD63F8F; Thu, 18 May 2023 18:08:25 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 18 May 2023 20:08:14 +0200 (CEST) Date: Thu, 18 May 2023 20:08:10 +0200 From: Oleg Nesterov To: Christian Brauner Subject: Re: [RFC PATCH 1/8] signal: Dequeue SIGKILL even if SIGNAL_GROUP_EXIT/group_exec_task is set Message-ID: <20230518180809.GA5817@redhat.com> References: <20230518000920.191583-1-michael.christie@oracle.com> <20230518000920.191583-2-michael.christie@oracle.com> <20230518-kontakt-geduckt-25bab595f503@brauner> <7412912a-a470-bd3d-fb1c-54c094cc01ee@oracle.com> <20230518-ratgeber-erbeben-843e68b0d6ac@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230518-ratgeber-erbeben-843e68b0d6ac@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Cc: axboe@kernel.dk, mst@redhat.com, linux@leemhuis.info, linux-kernel@vger.kernel.org, ebiederm@xmission.com, stefanha@redhat.com, nicolas.dichtel@6wind.com, virtualization@lists.linux-foundation.org, torvalds@linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 05/18, Christian Brauner wrote: > > Yeah, but these are issues that exist with PF_IO_WORKER then too This was my thought too but I am starting to think I was wrong. Of course I don't understand the code in io_uring/ but it seems that it always breaks the IO loops if get_signal() returns SIGKILL. Oleg. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3DAC77B7A for ; Thu, 18 May 2023 18:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbjERSJT (ORCPT ); Thu, 18 May 2023 14:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjERSJS (ORCPT ); Thu, 18 May 2023 14:09:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1108910E for ; Thu, 18 May 2023 11:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684433315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EP8NV9ONBFRX7JUAfH+hASHYoMHOz+nZ6k5QS4Ruiow=; b=NKXwt7T2znLcPpW78gXch8V7O/sT+QQyF06LBsfB1jNJyMnsHmRltl8NnijrYqvt4Kb+Yq GuBEJf2uS0iLuoTOeCbSbk8wGm+CiQoZ73+0393/MIB1SK42ZFQLGECS3t3sxhcPHlaI3b fHJvRJ0bXSeyqXzFjEfczw6TbZtnrOo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-JUfL8dQDNR-h3gj8vcQ0Lw-1; Thu, 18 May 2023 14:08:29 -0400 X-MC-Unique: JUfL8dQDNR-h3gj8vcQ0Lw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4399D800047; Thu, 18 May 2023 18:08:28 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.20]) by smtp.corp.redhat.com (Postfix) with SMTP id 451BD63F8F; Thu, 18 May 2023 18:08:25 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 18 May 2023 20:08:14 +0200 (CEST) Date: Thu, 18 May 2023 20:08:10 +0200 From: Oleg Nesterov To: Christian Brauner Cc: Mike Christie , linux@leemhuis.info, nicolas.dichtel@6wind.com, axboe@kernel.dk, ebiederm@xmission.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com Subject: Re: [RFC PATCH 1/8] signal: Dequeue SIGKILL even if SIGNAL_GROUP_EXIT/group_exec_task is set Message-ID: <20230518180809.GA5817@redhat.com> References: <20230518000920.191583-1-michael.christie@oracle.com> <20230518000920.191583-2-michael.christie@oracle.com> <20230518-kontakt-geduckt-25bab595f503@brauner> <7412912a-a470-bd3d-fb1c-54c094cc01ee@oracle.com> <20230518-ratgeber-erbeben-843e68b0d6ac@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518-ratgeber-erbeben-843e68b0d6ac@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18, Christian Brauner wrote: > > Yeah, but these are issues that exist with PF_IO_WORKER then too This was my thought too but I am starting to think I was wrong. Of course I don't understand the code in io_uring/ but it seems that it always breaks the IO loops if get_signal() returns SIGKILL. Oleg.