From: David Epping <david.epping@missinglinkelectronics.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock
Date: Mon, 22 May 2023 16:00:57 +0200 [thread overview]
Message-ID: <20230522140057.GB18381@nucnuc.mle> (raw)
In-Reply-To: <20230522095833.otk2nv24plmvarpt@skbuf>
On Mon, May 22, 2023 at 12:58:33PM +0300, Vladimir Oltean wrote:
> If you still prefer to write twice in a row to the same paged register
> instead of combining the changes, then fine by me, it's not a huge deal.
Since the clock enablement now happens in all modes the existing rgmii
function name seems misleading to me. Also we don't want to enable for
all PHY types, and the differentiation is already available at the
caller. I would thus opt for a separate function and fewer conditional
statements.
Its my first patch re-submission, so sorry for the noob question:
Should I include your "pw-bot: changes-requested" tag with the third
patch? Probably not.
Of course I'll include your tags for patches 1 and 2.
next prev parent reply other threads:[~2023-05-22 14:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 16:06 [PATCH net 0/3] net: phy: mscc: support VSC8501 David Epping
2023-05-20 16:06 ` [PATCH net 1/3] net: phy: mscc: add VSC8502 to MODULE_DEVICE_TABLE David Epping
2023-05-21 12:28 ` Vladimir Oltean
2023-05-20 16:06 ` [PATCH net 2/3] net: phy: mscc: add support for VSC8501 David Epping
2023-05-21 12:28 ` Vladimir Oltean
2023-05-20 16:06 ` [PATCH net 3/3] net: phy: mscc: enable VSC8501/2 RGMII RX clock David Epping
2023-05-21 12:35 ` Vladimir Oltean
2023-05-21 13:12 ` Vladimir Oltean
2023-05-21 16:08 ` David Epping
2023-05-21 13:43 ` Vladimir Oltean
2023-05-21 16:16 ` David Epping
2023-05-22 9:49 ` Vladimir Oltean
2023-05-22 9:54 ` Vladimir Oltean
2023-05-22 9:58 ` Vladimir Oltean
2023-05-22 14:00 ` David Epping [this message]
2023-05-22 14:42 ` Andrew Lunn
2023-05-22 15:11 ` Vladimir Oltean
2023-05-22 15:22 ` David Epping
2023-05-22 15:42 ` Vladimir Oltean
2023-05-21 17:59 ` Russell King (Oracle)
2023-05-22 13:48 ` David Epping
2023-05-21 13:33 ` [PATCH net 0/3] net: phy: mscc: support VSC8501 Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522140057.GB18381@nucnuc.mle \
--to=david.epping@missinglinkelectronics.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.