From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] fs: Drop wait_unfrozen wait queue
Date: Thu, 25 May 2023 20:16:04 +0200 [thread overview]
Message-ID: <20230525-vorenthalten-drama-aafc614c20df@brauner> (raw)
In-Reply-To: <20230525141710.7595-1-jack@suse.cz>
On Thu, May 25, 2023 at 04:17:10PM +0200, Jan Kara wrote:
> wait_unfrozen waitqueue is used only in quota code to wait for
> filesystem to become unfrozen. In that place we can just use
> sb_start_write() - sb_end_write() pair to achieve the same. So just
> remove the waitqueue.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
Removing code. I'm all here for it...
Reviewed-by: Christian Brauner <brauner@kernel.org>
> fs/quota/quota.c | 5 +++--
> fs/super.c | 4 ----
> include/linux/fs.h | 1 -
> 3 files changed, 3 insertions(+), 7 deletions(-)
>
> Guys, I can merge this cleanup through my tree since I don't expect any
> conflicts and the generic part is pure removal of unused code.
There'll likely be another set of fixes I'll take next week but I
honestly don't care. But seems that this isn't really urgent so why not
just wait for the merge window?
next prev parent reply other threads:[~2023-05-25 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 14:17 [PATCH] fs: Drop wait_unfrozen wait queue Jan Kara
2023-05-25 18:16 ` Christian Brauner [this message]
2023-05-30 13:34 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525-vorenthalten-drama-aafc614c20df@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.