From: Bjorn Andersson <andersson@kernel.org>
To: tremblay.gabriel@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Change the interrupt from level_low to edge_falling
Date: Wed, 24 May 2023 20:55:38 -0700 [thread overview]
Message-ID: <20230525035538.wcdpqmaumz5ad4r5@ripper> (raw)
In-Reply-To: <20230502-gtremblay-x13s-keyboard-v1-1-6bc3e59b0d39@gmail.com>
On Tue, May 02, 2023 at 02:31:14PM -0400, Gabriel Tremblay via B4 Relay wrote:
> From: Gabriel Tremblay <tremblay.gabriel@gmail.com>
>
>
>
> ---
> Lenovo's x13s internal keyboard shows responsivity issues when fast
> typing occurs. The problem is not replicated with external HID keyboard.
>
> This fix tries to alleviate the problem but requires further testing
> and commenting.
>
This is interesting, can you tell us a little bit more about why/how
this improves the situation? Perhaps that could help someone with
schematics to look into this further as well.
Regards,
Bjorn
> Signed-off-by: Gabriel Tremblay <tremblay.gabriel@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index bdcba719fc38..e8d7f02c9bf3 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -639,7 +639,7 @@ keyboard@68 {
> reg = <0x68>;
>
> hid-descr-addr = <0x1>;
> - interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
> + interrupts-extended = <&tlmm 104 IRQ_TYPE_EDGE_FALLING>;
> vdd-supply = <&vreg_misc_3p3>;
> vddl-supply = <&vreg_s10b>;
>
>
> ---
> base-commit: 84e2893b4573da3bc0c9f24e2005442e420e3831
> change-id: 20230502-gtremblay-x13s-keyboard-289935f922e2
>
> Best regards,
> --
> Gabriel Tremblay <tremblay.gabriel@gmail.com>
>
prev parent reply other threads:[~2023-05-25 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 18:31 [PATCH] Change the interrupt from level_low to edge_falling Gabriel Tremblay via B4 Relay
2023-05-02 18:31 ` Gabriel Tremblay
2023-05-02 20:30 ` Caleb Connolly
2023-05-25 3:55 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525035538.wcdpqmaumz5ad4r5@ripper \
--to=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tremblay.gabriel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.