From: Jakub Kicinski <kuba@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] net/tls: handle MSG_EOR for tls_sw TX flow
Date: Fri, 26 May 2023 21:13:53 -0700 [thread overview]
Message-ID: <20230526211353.33df9ca0@kernel.org> (raw)
In-Reply-To: <20230526143152.53954-2-hare@suse.de>
On Fri, 26 May 2023 16:31:50 +0200 Hannes Reinecke wrote:
> tls_sw_sendmsg() / tls_do_sw_sendpage() already handles
> MSG_MORE / MSG_SENDPAGE_NOTLAST, but bails out on MSG_EOR.
> But seeing that MSG_EOR is basically the opposite of
> MSG_MORE / MSG_SENDPAGE_NOTLAST this patch adds handling
> MSG_EOR by treating it as the negation of MSG_MORE.
The cover letter didn't make it to netdev so replying here -
please add test cases for EOR to tools/testing/selftests/net/tls.c
(FWIW selftests now take command line arguments allowing you to narrow
down the set of test cases run, it's pretty useful here, waiting for
all crypto algos to finish is annoying)
next prev parent reply other threads:[~2023-05-27 4:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 14:31 [PATCH 0/3] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-05-26 14:31 ` [PATCH 1/3] net/tls: handle MSG_EOR for tls_sw TX flow Hannes Reinecke
2023-05-27 4:13 ` Jakub Kicinski [this message]
2023-05-26 14:31 ` [PATCH 2/3] net/tls: handle MSG_EOR for tls_device " Hannes Reinecke
2023-05-26 14:31 ` [PATCH 3/3] net/tls: implement ->read_sock() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526211353.33df9ca0@kernel.org \
--to=kuba@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.