From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D242B611B for ; Sun, 28 May 2023 19:44:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BC32C433EF; Sun, 28 May 2023 19:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685303081; bh=SWQb1EoQzjP6GCWmYP5J+/uJAIKTXjNVdAvPYYYcIJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E0XtMsRbJNtSdBGPiZL9ZOCy53Cu96OSv+MTVGbSbBHLvU0BCJ1nIMyRRG14oZz2T rMFGKRC2KlHtM8hBulmkMpVqrR4oLgKxLrPKW5JxEY8wheze+io177pq0o1y5E1DgI v8IRPdphvX9BZTKOFF2+Q5S3VLUOXS9pHFtJxwCo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christophe JAILLET , Pavan Chebbi , Simon Horman , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 118/211] cassini: Fix a memory leak in the error handling path of cas_init_one() Date: Sun, 28 May 2023 20:10:39 +0100 Message-Id: <20230528190846.491802761@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230528190843.514829708@linuxfoundation.org> References: <20230528190843.514829708@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Christophe JAILLET [ Upstream commit 412cd77a2c24b191c65ea53025222418db09817c ] cas_saturn_firmware_init() allocates some memory using vmalloc(). This memory is freed in the .remove() function but not it the error handling path of the probe. Add the missing vfree() to avoid a memory leak, should an error occur. Fixes: fcaa40669cd7 ("cassini: use request_firmware") Signed-off-by: Christophe JAILLET Reviewed-by: Pavan Chebbi Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/sun/cassini.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 9ff894ba8d3ea..d245f6e21e8ca 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -5122,6 +5122,8 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) cas_shutdown(cp); mutex_unlock(&cp->pm_mutex); + vfree(cp->fw_data); + pci_iounmap(pdev, cp->regs); -- 2.39.2