From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C250C7EE2E for ; Tue, 30 May 2023 08:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjE3IQ7 (ORCPT ); Tue, 30 May 2023 04:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjE3IQ4 (ORCPT ); Tue, 30 May 2023 04:16:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E305A1 for ; Tue, 30 May 2023 01:16:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3uXF-0008MO-AW; Tue, 30 May 2023 10:16:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q3uXE-003pUu-LD; Tue, 30 May 2023 10:16:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q3uXD-009PLq-Pi; Tue, 30 May 2023 10:16:51 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, AngeloGioacchino Del Regno Subject: [PATCH v2 2/3] spi: mt65xx: Convert to platform remove callback returning void Date: Tue, 30 May 2023 10:16:47 +0200 Message-Id: <20230530081648.2199419-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1790; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=RMZEMdZ0GqYLZEELtvtNLR429tgOZGoJUI2pqpA2CY4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkdbDuWdq8rXYgK7WodWwgE3y3t+cF8MaToAmwD 2WTnHYzJ5KJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZHWw7gAKCRCPgPtYfRL+ Tj2/B/9etgpKKQOLXjPFtJ6cKloOTN73b/RnWt0UCOtUBYlD2E5ynsgoDH3hgzE9bFivNFJ/5ne 8XjzQPJwkz1dlwbL59bevn+pzXd5aRvJX6MFG/wFV1quSojxk8noVGKZNG5sq2O6SDyUaVCLMOd IEVaZw+D4/tvnPjnH/9HYRu6Vf+vE1FqN57RvrxgKXOswVQ8Or/gEqbvAGyfmf1JOEUZV7QioeQ CCqa73xZsQN18K5UgSX6awi5YVM9LxC9CzI6DrppUT36aZtQvIW6I1yz2HTcmUurrSLOosoKlRn Pf5QU5mLJO68G6t4tQRWmZexCkpGhDGeAoaln/I2t5sMKXXx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-spi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-mt65xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index 9333a0e8204d..f532cee3461e 100644 --- a/drivers/spi/spi-mt65xx.c +++ b/drivers/spi/spi-mt65xx.c @@ -1269,7 +1269,7 @@ static int mtk_spi_probe(struct platform_device *pdev) return 0; } -static int mtk_spi_remove(struct platform_device *pdev) +static void mtk_spi_remove(struct platform_device *pdev) { struct spi_master *master = platform_get_drvdata(pdev); struct mtk_spi *mdata = spi_master_get_devdata(master); @@ -1294,8 +1294,6 @@ static int mtk_spi_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1415,7 +1413,7 @@ static struct platform_driver mtk_spi_driver = { .of_match_table = mtk_spi_of_match, }, .probe = mtk_spi_probe, - .remove = mtk_spi_remove, + .remove_new = mtk_spi_remove, }; module_platform_driver(mtk_spi_driver); -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC182C77B73 for ; Tue, 30 May 2023 08:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zS1LvolLtpxxMEJUFVDiR/0PSsGjzEEQpscMoJV5nME=; b=D7TQpkveADom+a BxN5mV/4CbvT7mQfxcdNnaLssr24fSg8wMEhVO9WHaIVkPagsDUfNx2lPRjT/Fm+1PZRceOXslidK xU4R9iEuKfETT5T/qVAJ07tqjEDScMo0ADPs3LaoTaxHASAWXcmc3V0FCdQLN178OC713mMmm88WZ RkP4SN3s4fPmVPdtI5ZZXtLZHNdT21rRfaQX3et6iF8fcY6AdlgjGbccDmXbpg6Yd3WU5OxksVcMN S6A7EVFu2CENY9HF1qHzEjTTs/So2uEqreuZz0v7sfsIJvDB1Kf78lHaadIWTQmvCBurDFu+Czatk 8X3cG6g68Zt8l6ZcB9dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3uXS-00CtHn-0h; Tue, 30 May 2023 08:17:06 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3uXM-00CtDx-2M for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 08:17:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3uXF-0008MO-AW; Tue, 30 May 2023 10:16:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q3uXE-003pUu-LD; Tue, 30 May 2023 10:16:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q3uXD-009PLq-Pi; Tue, 30 May 2023 10:16:51 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, AngeloGioacchino Del Regno Subject: [PATCH v2 2/3] spi: mt65xx: Convert to platform remove callback returning void Date: Tue, 30 May 2023 10:16:47 +0200 Message-Id: <20230530081648.2199419-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1790; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=RMZEMdZ0GqYLZEELtvtNLR429tgOZGoJUI2pqpA2CY4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkdbDuWdq8rXYgK7WodWwgE3y3t+cF8MaToAmwD 2WTnHYzJ5KJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZHWw7gAKCRCPgPtYfRL+ Tj2/B/9etgpKKQOLXjPFtJ6cKloOTN73b/RnWt0UCOtUBYlD2E5ynsgoDH3hgzE9bFivNFJ/5ne 8XjzQPJwkz1dlwbL59bevn+pzXd5aRvJX6MFG/wFV1quSojxk8noVGKZNG5sq2O6SDyUaVCLMOd IEVaZw+D4/tvnPjnH/9HYRu6Vf+vE1FqN57RvrxgKXOswVQ8Or/gEqbvAGyfmf1JOEUZV7QioeQ CCqa73xZsQN18K5UgSX6awi5YVM9LxC9CzI6DrppUT36aZtQvIW6I1yz2HTcmUurrSLOosoKlRn Pf5QU5mLJO68G6t4tQRWmZexCkpGhDGeAoaln/I2t5sMKXXx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_011700_770624_F10C9537 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIC5yZW1vdmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBp bnQgd2hpY2ggbWFrZXMKbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBv c3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5CnJldHVybmluZyBhbiBlcnJvciBjb2RlLiBI b3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCmFuZCB0aGlzIHR5 cGljYWxseSByZXN1bHRzIGluIHJlc291cmNlIGxlYWtzLiBUbyBpbXByb3ZlIGhlcmUgdGhlcmUg aXMgYQpxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRo ZSBmaXJzdCBzdGVwIG9mIHRoaXMKcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAu cmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwp2b2lkLgoKVHJpdmlhbGx5IGNvbnZl cnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQpj YWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFyaWFudC4KClJldmlld2VkLWJ5OiBBbmdl bG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJv cmEuY29tPgpTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmln QHBlbmd1dHJvbml4LmRlPgotLS0KIGRyaXZlcnMvc3BpL3NwaS1tdDY1eHguYyB8IDYgKystLS0t CiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvc3BpL3NwaS1tdDY1eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1tdDY1eHgu YwppbmRleCA5MzMzYTBlODIwNGQuLmY1MzJjZWUzNDYxZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9z cGkvc3BpLW10NjV4eC5jCisrKyBiL2RyaXZlcnMvc3BpL3NwaS1tdDY1eHguYwpAQCAtMTI2OSw3 ICsxMjY5LDcgQEAgc3RhdGljIGludCBtdGtfc3BpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgbXRrX3NwaV9yZW1vdmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKK3N0YXRpYyB2b2lkIG10a19zcGlfcmVtb3ZlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB7CiAJc3RydWN0IHNwaV9tYXN0ZXIgKm1hc3Rl ciA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwogCXN0cnVjdCBtdGtfc3BpICptZGF0YSA9 IHNwaV9tYXN0ZXJfZ2V0X2RldmRhdGEobWFzdGVyKTsKQEAgLTEyOTQsOCArMTI5NCw2IEBAIHN0 YXRpYyBpbnQgbXRrX3NwaV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAog CXBtX3J1bnRpbWVfcHV0X25vaWRsZSgmcGRldi0+ZGV2KTsKIAlwbV9ydW50aW1lX2Rpc2FibGUo JnBkZXYtPmRldik7Ci0KLQlyZXR1cm4gMDsKIH0KIAogI2lmZGVmIENPTkZJR19QTV9TTEVFUApA QCAtMTQxNSw3ICsxNDEzLDcgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbXRrX3Nw aV9kcml2ZXIgPSB7CiAJCS5vZl9tYXRjaF90YWJsZSA9IG10a19zcGlfb2ZfbWF0Y2gsCiAJfSwK IAkucHJvYmUgPSBtdGtfc3BpX3Byb2JlLAotCS5yZW1vdmUgPSBtdGtfc3BpX3JlbW92ZSwKKwku cmVtb3ZlX25ldyA9IG10a19zcGlfcmVtb3ZlLAogfTsKIAogbW9kdWxlX3BsYXRmb3JtX2RyaXZl cihtdGtfc3BpX2RyaXZlcik7Ci0tIAoyLjM5LjIKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==