From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6612DC7EE31 for ; Tue, 30 May 2023 08:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjE3IQ7 (ORCPT ); Tue, 30 May 2023 04:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbjE3IQ4 (ORCPT ); Tue, 30 May 2023 04:16:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B053DA8 for ; Tue, 30 May 2023 01:16:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3uXF-0008MQ-Hy; Tue, 30 May 2023 10:16:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q3uXE-003pV0-SO; Tue, 30 May 2023 10:16:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q3uXE-009PLt-0L; Tue, 30 May 2023 10:16:52 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, AngeloGioacchino Del Regno Subject: [PATCH v2 3/3] spi: mt65xx: Don't disguise a "return 0" as "return ret" Date: Tue, 30 May 2023 10:16:48 +0200 Message-Id: <20230530081648.2199419-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=802; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ew7u2vVjRGswRnJ0Le+vSh/UTGZDw0qmYIiCRc9OzYk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkdbDv3hfrWqOKRbA5eyKpO+36tm6FOWuuaFq4T Pi1bwKRRpeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZHWw7wAKCRCPgPtYfRL+ Tt/DB/44PJgEduak7dCLH9t+Dlt0HWOfr/wUwjV5gRjJpu54mmJ+Fc7FsX+IAcebhW7VO0iIhw9 R9ywW8VC5j3j9jZ8gjAmVyINoWg0yDoGAsAfcb0HyFmORXOyJudhrSSs5+nXU1t1gBL4LSaJ9bI BP6kOw/VhrTRIKwZCkrNNCTC7yfc7ejl/nKFIBQVjV1hPHcZJ++rONpsaDOe8a0WtCNIxc6BUNl Vwmi8FSfYAdHK1ui6c15iBcydFR90DdWHCrnPPKlrwf6wTyY1RYsbHZYEqojKrawNl8ZkjSicTQ Djp2FbivQCAauxYQu+S2UhQ84pVZJPVJ0BtSQeG3r2Wtdyu1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-spi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Because of the earlier if (ret) return ret; ret is always zero at the end of mtk_spi_suspend(). Write it as explicit return 0 for slightly improved clearness. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-mt65xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index f532cee3461e..5a0b04c1c755 100644 --- a/drivers/spi/spi-mt65xx.c +++ b/drivers/spi/spi-mt65xx.c @@ -1312,7 +1312,7 @@ static int mtk_spi_suspend(struct device *dev) clk_disable_unprepare(mdata->spi_hclk); } - return ret; + return 0; } static int mtk_spi_resume(struct device *dev) -- 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00930C77B7A for ; Tue, 30 May 2023 08:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QFNxe1xwCuJCRc3sMZQZ8VPLdRUEir70D4IXyoyp6UA=; b=eb3UxCMilc+TJO p1zpxMM5xXGKdftmOk32wZH65hsx84Ukc/l4K/Rqxs9SRyYpy6kKS5RSoc4dhj9uTsU8f9UNJtjfi 9VEfzRXnDslX5OootvhVKRVISlOMxkVzy5sQfaf9vmsJmEwrhxW4hmQkrfDiIaIaLc0XW7Eqr0fPH WoGlrD4YmyjnChD9lNPMwfDaPv3G7oc7DlITzwbbjvFU8hKpQsPC9HucI6Wk+OpvQ7nIW70E8/i7h m+RU9H0nD4YeZTO132veWAIPIGp9KG/JhNM6pK59zkbi1vHzmp0WKyY2gzAciJGBMTu2yKw7e91t6 oWUdr3o/RBAxLBGoRr/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3uXS-00CtIJ-2S; Tue, 30 May 2023 08:17:06 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3uXN-00CtEQ-0I for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 08:17:02 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3uXF-0008MQ-Hy; Tue, 30 May 2023 10:16:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q3uXE-003pV0-SO; Tue, 30 May 2023 10:16:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q3uXE-009PLt-0L; Tue, 30 May 2023 10:16:52 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, AngeloGioacchino Del Regno Subject: [PATCH v2 3/3] spi: mt65xx: Don't disguise a "return 0" as "return ret" Date: Tue, 30 May 2023 10:16:48 +0200 Message-Id: <20230530081648.2199419-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=802; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ew7u2vVjRGswRnJ0Le+vSh/UTGZDw0qmYIiCRc9OzYk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkdbDv3hfrWqOKRbA5eyKpO+36tm6FOWuuaFq4T Pi1bwKRRpeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZHWw7wAKCRCPgPtYfRL+ Tt/DB/44PJgEduak7dCLH9t+Dlt0HWOfr/wUwjV5gRjJpu54mmJ+Fc7FsX+IAcebhW7VO0iIhw9 R9ywW8VC5j3j9jZ8gjAmVyINoWg0yDoGAsAfcb0HyFmORXOyJudhrSSs5+nXU1t1gBL4LSaJ9bI BP6kOw/VhrTRIKwZCkrNNCTC7yfc7ejl/nKFIBQVjV1hPHcZJ++rONpsaDOe8a0WtCNIxc6BUNl Vwmi8FSfYAdHK1ui6c15iBcydFR90DdWHCrnPPKlrwf6wTyY1RYsbHZYEqojKrawNl8ZkjSicTQ Djp2FbivQCAauxYQu+S2UhQ84pVZJPVJ0BtSQeG3r2Wtdyu1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_011701_129717_AA4256C6 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QmVjYXVzZSBvZiB0aGUgZWFybGllcgoKCSBpZiAocmV0KQoJCXJldHVybiByZXQ7CgpyZXQgaXMg YWx3YXlzIHplcm8gYXQgdGhlIGVuZCBvZiBtdGtfc3BpX3N1c3BlbmQoKS4gV3JpdGUgaXQgYXMg ZXhwbGljaXQKcmV0dXJuIDAgZm9yIHNsaWdodGx5IGltcHJvdmVkIGNsZWFybmVzcy4KClJldmll d2VkLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxy ZWdub0Bjb2xsYWJvcmEuY29tPgpTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgotLS0KIGRyaXZlcnMvc3BpL3NwaS1tdDY1eHgu YyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3BpL3NwaS1tdDY1eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1t dDY1eHguYwppbmRleCBmNTMyY2VlMzQ2MWUuLjVhMGIwNGMxYzc1NSAxMDA2NDQKLS0tIGEvZHJp dmVycy9zcGkvc3BpLW10NjV4eC5jCisrKyBiL2RyaXZlcnMvc3BpL3NwaS1tdDY1eHguYwpAQCAt MTMxMiw3ICsxMzEyLDcgQEAgc3RhdGljIGludCBtdGtfc3BpX3N1c3BlbmQoc3RydWN0IGRldmlj ZSAqZGV2KQogCQljbGtfZGlzYWJsZV91bnByZXBhcmUobWRhdGEtPnNwaV9oY2xrKTsKIAl9CiAK LQlyZXR1cm4gcmV0OworCXJldHVybiAwOwogfQogCiBzdGF0aWMgaW50IG10a19zcGlfcmVzdW1l KHN0cnVjdCBkZXZpY2UgKmRldikKLS0gCjIuMzkuMgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK