From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21FD7C77B7A for ; Tue, 30 May 2023 14:47:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q40cW-0006tc-OZ; Tue, 30 May 2023 10:46:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q40c9-0006le-Re for qemu-devel@nongnu.org; Tue, 30 May 2023 10:46:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q40c6-00077H-VK for qemu-devel@nongnu.org; Tue, 30 May 2023 10:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685457978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O1HxeF5m3sFufMGO0E7IjEwfIpmMk+aQrABXPvWZqeg=; b=MwVmGI2NzKYVlpcIwQ6YfcWAa8fy9dCrFI0CqIYQqoIEXISgcp0fGh7IvBXzMOt4WuYnGI nG5W1K6pEvF5E8jOm6YQK6OfEr7xSmIorfSBRIifGN7TsOdcXKUsk8ELUjTWtWFjctXgc6 4RrIPxGDT2Sn2J77/GoID57ApEIAl78= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-Gb7TNTmDPUGFVONUsbexMw-1; Tue, 30 May 2023 10:46:17 -0400 X-MC-Unique: Gb7TNTmDPUGFVONUsbexMw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f60f085cd2so17498055e9.0 for ; Tue, 30 May 2023 07:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685457972; x=1688049972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O1HxeF5m3sFufMGO0E7IjEwfIpmMk+aQrABXPvWZqeg=; b=gYaZszPvJZAB19POak8Fh+eMuMuZ6movcBP45kaLtnA1GizHTXUXhmoT5PZ62ffmfV p1z5bVj0ELxXBnm7l96HASzBn+4z44L1qyQY/tBzT1Z8Yz3pg03ViSx8LsPBvkmQoglF eIt3/i4fl/FCjZZAqbOmfgwKZOczow3AdzrmYtXtAUc9TGDhoKv/r7A/+9SzOKVz0yCZ dtXP1WdVMbtACBV5eYA0j6pKJ7ui22Uxe5SNKobbAhIu9M+UCRqDE9s1irrAVua8HFk5 uHGn30bm/nryNhSA7zO0+Abt5m7RCNrgK7zy4ilNtEcyszMtwHZDvC0m52p2JBMpYGiy NIqA== X-Gm-Message-State: AC+VfDwReFWNHodDeFxSPU7ceMRWMlCt8GxuWbYO4xzwYAOFZawn3e35 qaMDtLy1mV9Ht+lY/uuKM9/skc92GmFe6VA2XmCvS0vrmsejeqf7GkKQ1jAlnnZVmPsDL+193wJ aZyzDE4K+pW7iW1c= X-Received: by 2002:a7b:c048:0:b0:3f6:2a6:e2c with SMTP id u8-20020a7bc048000000b003f602a60e2cmr2077405wmc.9.1685457972288; Tue, 30 May 2023 07:46:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Iz7kyDuKX3yLz9zwz06Q1mjQ4vuUBAKSZCtLgIekoldFFi5bN70ULZi0vK3HkjO4PJDWf3A== X-Received: by 2002:a7b:c048:0:b0:3f6:2a6:e2c with SMTP id u8-20020a7bc048000000b003f602a60e2cmr2077385wmc.9.1685457972011; Tue, 30 May 2023 07:46:12 -0700 (PDT) Received: from redhat.com ([2.52.11.69]) by smtp.gmail.com with ESMTPSA id k10-20020a7bc40a000000b003f606869603sm21221562wmi.6.2023.05.30.07.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 07:46:11 -0700 (PDT) Date: Tue, 30 May 2023 10:46:01 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Igor Mammedov , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Xiao Guangrong , =?iso-8859-1?Q?C=E9dric?= Le Goater , Daniel Henrique Barboza , David Gibson , Eduardo Habkost , Greg Kurz , Harsh Prateek Bora , Marcel Apfelbaum , Paolo Bonzini , Peter Maydell , Richard Henderson , Song Gao , Xiaojuan Yang Subject: Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE Message-ID: <20230530104504-mutt-send-email-mst@kernel.org> References: <20230530113838.257755-1-david@redhat.com> <20230530113838.257755-9-david@redhat.com> <20230530090655-mutt-send-email-mst@kernel.org> <9d395d6f-4da9-45c6-bf20-ed33f1c4bca5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 30, 2023 at 03:41:58PM +0200, David Hildenbrand wrote: > On 30.05.23 15:11, David Hildenbrand wrote: > > On 30.05.23 15:07, Michael S. Tsirkin wrote: > > > On Tue, May 30, 2023 at 01:38:36PM +0200, David Hildenbrand wrote: > > > > There are no remaining users in the tree, so let's remove it. > > > > > > > > Cc: Paolo Bonzini > > > > Cc: Richard Henderson > > > > Cc: Eduardo Habkost > > > > Cc: "Michael S. Tsirkin" > > > > Cc: Marcel Apfelbaum > > > > Signed-off-by: David Hildenbrand > > > > > > > > > This (with previous patches) means any user changing > > > device-memory-region-size machine property is now broken, right? > > > > We only had a getter, no setter (for good reason). > > > > > How do we know there are no users? > > > > We don't. A quick google search makes "device-memory-region-size" and > > "qom-get" only pop up in BUG fixes for something that appears to be QEMU > > developer driven. > > > > I don't consider it any useful, but if we want to be careful, sure we > > can leave it around. > > Looking further, libvirt doesn't use it (and never used it). > > I already renamed it in 2018 without anybody complaining: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg532101.html > > So I'm quite confident that nobody will really miss this property. > > -- > Thanks, > > David / dhildenb OK. In the future we need to be careful and use "x-" prefix for what we don't want to expose. -- MST