From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B1E1C77B7A for ; Tue, 30 May 2023 12:30:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3ySv-0001PX-Iw; Tue, 30 May 2023 08:28:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3ySe-0001Ko-75 for qemu-devel@nongnu.org; Tue, 30 May 2023 08:28:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3ySc-0000e3-A4 for qemu-devel@nongnu.org; Tue, 30 May 2023 08:28:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685449700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HvbH2JivrXtRyj31DbRcR4D9BcW1StoMekPCQBEQB0Y=; b=MsaNT4D9n2SJXVK49BCfYy/lnxmKKZuPE692mb/kocL/7N9M+FiQ9wl4nmMtsxS0nsoIw1 75b8qrswtnMPwcAZV7cI1oQwEn39WPZiu7VlKcAiP6F+TWlD3VRbIjWo1Vssx+G3cemUek U18mVBnNoStT2T7ehHuPMARaYJ8aXhI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-56-OgJENU3oOPudXr_d1_y3Dw-1; Tue, 30 May 2023 08:28:16 -0400 X-MC-Unique: OgJENU3oOPudXr_d1_y3Dw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37028811E8F; Tue, 30 May 2023 12:28:16 +0000 (UTC) Received: from secure.mitica (unknown [10.39.195.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65D9340CFD46; Tue, 30 May 2023 12:28:14 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Leonardo Bras , Hailiang Zhang , Peter Xu , Fam Zheng , Juan Quintela , Stefan Hajnoczi Subject: [PATCH 00/16] Next round of migration atomic counters Date: Tue, 30 May 2023 14:27:57 +0200 Message-Id: <20230530122813.2674-1-quintela@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi On this series: - Make sure that qemu_file_transferred() make sense and its used coherently - Use stat64 for qemu_file_transferred(), so we can call the function from any thread. - Don't account for the same transfer twice (i.e. it is multifd_bytes, rdma_bytes or qemu_file_bytes) qemu_file_transferred() just sums all of them. - Use this new counter for rate_limit() - Remove old trasferred stat64 (now we use the real thing) - Simplify qemu_file_get_error(): see where next cleanups are coming - As an example, qemu_fflush() now return errors. Please review. Later, Juan. Based-on: Message-Id: <20230530115429.1998-1-quintela@redhat.com> Subject: [PULL 00/21] Migration 20230530 patches Juan Quintela (16): qemu-file: Rename qemu_file_transferred_ fast -> noflush migration: Change qemu_file_transferred to noflush migration: Use qemu_file_transferred_noflush() for block migration. qemu-file: Don't call qemu_fflush() for read only files qemu-file: We only call qemu_file_transferred_* on the sending side qemu_file: Use a stat64 for qemu_file_transferred qemu_file: total_transferred is not used anymore migration: Use the number of transferred bytes directly qemu_file: Remove unused qemu_file_transferred() qemu-file: Remove _noflush from qemu_file_transferred_noflush() migration: migration_transferred_bytes() don't need the QEMUFile migration: migration_rate_limit_reset() don't need the QEMUFile qemu-file: Simplify qemu_file_get_error() migration: Use migration_transferred_bytes() migration: Remove transferred atomic counter qemu-file: Make qemu_fflush() return errors migration/migration-stats.h | 16 ++++++---------- migration/qemu-file.h | 29 +++++------------------------ migration/colo.c | 11 +++-------- migration/migration-stats.c | 10 +++++----- migration/migration.c | 17 ++++++----------- migration/multifd.c | 3 --- migration/qemu-file.c | 35 ++++++++++++++--------------------- migration/ram.c | 29 ++++++++++------------------- migration/rdma.c | 4 +--- migration/savevm.c | 7 +++---- migration/vmstate.c | 4 ++-- 11 files changed, 55 insertions(+), 110 deletions(-) -- 2.40.1