From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Leonardo Bras <leobras@redhat.com>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
Fiona Ebner <f.ebner@proxmox.com>, Peter Xu <peterx@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Fam Zheng <fam@euphon.net>
Subject: [PATCH v2 00/20] Next round of migration atomic counters
Date: Tue, 30 May 2023 20:39:21 +0200 [thread overview]
Message-ID: <20230530183941.7223-1-quintela@redhat.com> (raw)
Hi
On this v2:
- dropped qemu_fflush() assert for read only files (make Richard
happy)
- Update documentation for qemu_file_transferred (make Fabiano happy)
- migration/rdma: Remove qemu_fopen_rdma() and make it look like
everything else
- Simplify a couple of qemu-file functions, and unexport the ones that
are not used outside of qemu-file.c
- Added Reviewed-by comments.
Please review.
Thanks, Juan.
[v1]
On this series:
- Make sure that qemu_file_transferred() make sense and its used
coherently
- Use stat64 for qemu_file_transferred(), so we can call the function
from any thread.
- Don't account for the same transfer twice (i.e. it is multifd_bytes,
rdma_bytes or qemu_file_bytes) qemu_file_transferred() just sums all
of them.
- Use this new counter for rate_limit()
- Remove old trasferred stat64 (now we use the real thing)
- Simplify qemu_file_get_error(): see where next cleanups are coming
- As an example, qemu_fflush() now return errors.
Please review.
Later, Juan.
Based-on: Message-Id: <20230530115429.1998-1-quintela@redhat.com>
Subject: [PULL 00/21] Migration 20230530 patches
Juan Quintela (20):
qemu-file: Rename qemu_file_transferred_ fast -> noflush
migration: Change qemu_file_transferred to noflush
migration: Use qemu_file_transferred_noflush() for block migration.
qemu-file: We only call qemu_file_transferred_* on the sending side
qemu_file: Use a stat64 for qemu_file_transferred
qemu_file: total_transferred is not used anymore
migration: Use the number of transferred bytes directly
qemu_file: Remove unused qemu_file_transferred()
qemu-file: Remove _noflush from qemu_file_transferred_noflush()
migration: migration_transferred_bytes() don't need the QEMUFile
migration: migration_rate_limit_reset() don't need the QEMUFile
qemu-file: Simplify qemu_file_get_error()
migration: Use migration_transferred_bytes()
migration: Remove transferred atomic counter
qemu-file: Make qemu_fflush() return errors
migration/rdma: Split qemu_fopen_rdma() into input/output functions
qemu-file: Remove unused qemu_file_mode_is_not_valid()
qemu_file: Make qemu_file_is_writable() static
qemu-file: Simplify qemu_file_shutdown()
qemu-file: Make qemu_file_get_error_obj() static
migration/migration-stats.h | 16 ++++-----
migration/qemu-file.h | 31 +++---------------
migration/colo.c | 11 ++-----
migration/migration-stats.c | 10 +++---
migration/migration.c | 17 ++++------
migration/multifd.c | 3 --
migration/qemu-file.c | 65 ++++++++++---------------------------
migration/ram.c | 29 ++++++-----------
migration/rdma.c | 39 ++++++++++------------
migration/savevm.c | 7 ++--
migration/vmstate.c | 4 +--
11 files changed, 73 insertions(+), 159 deletions(-)
--
2.40.1
next reply other threads:[~2023-05-30 18:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 18:39 Juan Quintela [this message]
2023-05-30 18:39 ` [PATCH v2 01/20] qemu-file: Rename qemu_file_transferred_ fast -> noflush Juan Quintela
2023-05-30 18:39 ` [PATCH v2 02/20] migration: Change qemu_file_transferred to noflush Juan Quintela
2023-05-30 18:39 ` [PATCH v2 03/20] migration: Use qemu_file_transferred_noflush() for block migration Juan Quintela
2023-05-30 18:39 ` [PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side Juan Quintela
2023-06-05 18:18 ` Peter Xu
2023-06-13 16:02 ` Juan Quintela
2023-06-14 13:36 ` Peter Xu
2023-06-21 22:20 ` Juan Quintela
2023-05-30 18:39 ` [PATCH v2 05/20] qemu_file: Use a stat64 for qemu_file_transferred Juan Quintela
2023-06-05 18:22 ` Peter Xu
2023-06-13 16:12 ` Juan Quintela
2023-05-30 18:39 ` [PATCH v2 06/20] qemu_file: total_transferred is not used anymore Juan Quintela
2023-06-14 14:52 ` Peter Xu
2023-06-21 23:05 ` Juan Quintela
2023-06-22 14:45 ` Peter Xu
2023-05-30 18:39 ` [PATCH v2 07/20] migration: Use the number of transferred bytes directly Juan Quintela
2023-05-30 18:39 ` [PATCH v2 08/20] qemu_file: Remove unused qemu_file_transferred() Juan Quintela
2023-05-30 18:39 ` [PATCH v2 09/20] qemu-file: Remove _noflush from qemu_file_transferred_noflush() Juan Quintela
2023-05-30 18:39 ` [PATCH v2 10/20] migration: migration_transferred_bytes() don't need the QEMUFile Juan Quintela
2023-05-30 18:39 ` [PATCH v2 11/20] migration: migration_rate_limit_reset() " Juan Quintela
2023-05-30 18:39 ` [PATCH v2 12/20] qemu-file: Simplify qemu_file_get_error() Juan Quintela
2023-05-30 18:39 ` [PATCH v2 13/20] migration: Use migration_transferred_bytes() Juan Quintela
2023-05-30 18:39 ` [PATCH v2 14/20] migration: Remove transferred atomic counter Juan Quintela
2023-05-30 18:39 ` [PATCH v2 15/20] qemu-file: Make qemu_fflush() return errors Juan Quintela
2023-05-30 18:39 ` [PATCH v2 16/20] migration/rdma: Split qemu_fopen_rdma() into input/output functions Juan Quintela
2023-06-14 15:07 ` Peter Xu
2023-05-30 18:39 ` [PATCH v2 17/20] qemu-file: Remove unused qemu_file_mode_is_not_valid() Juan Quintela
2023-05-30 18:39 ` [PATCH v2 18/20] qemu_file: Make qemu_file_is_writable() static Juan Quintela
2023-06-14 15:54 ` Peter Xu
2023-05-30 18:39 ` [PATCH v2 19/20] qemu-file: Simplify qemu_file_shutdown() Juan Quintela
2023-06-14 15:54 ` Peter Xu
2023-05-30 18:39 ` [PATCH v2 20/20] qemu-file: Make qemu_file_get_error_obj() static Juan Quintela
2023-06-14 15:54 ` Peter Xu
2023-05-31 9:10 ` [PATCH v2 00/20] Next round of migration atomic counters Fiona Ebner
2023-05-31 10:22 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530183941.7223-1-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.