All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: laurent@vivier.eu, qemu-devel@nongnu.org
Subject: [PATCH v2 15/23] q800: move ESCC device to Q800MachineState
Date: Wed, 31 May 2023 13:53:52 +0100	[thread overview]
Message-ID: <20230531125400.288917-16-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20230531125400.288917-1-mark.cave-ayland@ilande.co.uk>

Also change the instantiation of the ESCC device to use object_initialize_child().

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/m68k/q800.c         | 6 ++++--
 include/hw/m68k/q800.h | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index e25f6f1373..ac92daf190 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -347,7 +347,9 @@ static void q800_machine_init(MachineState *machine)
 
     /* SCC */
 
-    dev = qdev_new(TYPE_ESCC);
+    object_initialize_child(OBJECT(machine), "escc", &m->escc,
+                            TYPE_ESCC);
+    dev = DEVICE(&m->escc);
     qdev_prop_set_uint32(dev, "disabled", 0);
     qdev_prop_set_uint32(dev, "frequency", MAC_CLOCK);
     qdev_prop_set_uint32(dev, "it_shift", 1);
@@ -357,7 +359,7 @@ static void q800_machine_init(MachineState *machine)
     qdev_prop_set_uint32(dev, "chnBtype", 0);
     qdev_prop_set_uint32(dev, "chnAtype", 0);
     sysbus = SYS_BUS_DEVICE(dev);
-    sysbus_realize_and_unref(sysbus, &error_fatal);
+    sysbus_realize(sysbus, &error_fatal);
 
     /* Logically OR both its IRQs together */
     escc_orgate = DEVICE(object_new(TYPE_OR_IRQ));
diff --git a/include/hw/m68k/q800.h b/include/hw/m68k/q800.h
index 82964cfea1..d03603fe02 100644
--- a/include/hw/m68k/q800.h
+++ b/include/hw/m68k/q800.h
@@ -26,6 +26,7 @@
 #include "hw/m68k/q800-glue.h"
 #include "hw/misc/mac_via.h"
 #include "hw/net/dp8393x.h"
+#include "hw/char/escc.h"
 
 /*
  * The main Q800 machine
@@ -40,6 +41,7 @@ struct Q800MachineState {
     MOS6522Q800VIA1State via1;
     MOS6522Q800VIA2State via2;
     dp8393xState dp8393x;
+    ESCCState escc;
     MemoryRegion macio;
     MemoryRegion macio_alias;
 };
-- 
2.30.2



  parent reply	other threads:[~2023-05-31 12:56 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 12:53 [PATCH v2 00/23] q800: add support for booting MacOS Classic - part 1 Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 01/23] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array Mark Cave-Ayland
2023-05-31 13:56   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 02/23] q800: add missing space after parent object in GLUEState Mark Cave-Ayland
2023-05-31 13:35   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 03/23] q800: introduce Q800MachineState Mark Cave-Ayland
2023-05-31 13:37   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 04/23] q800: rename q800_init() to q800_machine_init() Mark Cave-Ayland
2023-05-31 13:37   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 05/23] q800: move CPU object into Q800MachineState Mark Cave-Ayland
2023-05-31 13:40   ` Philippe Mathieu-Daudé
2023-05-31 15:00     ` Markus Armbruster
2023-06-01  8:00       ` Mark Cave-Ayland
2023-06-01  9:00         ` Markus Armbruster
2023-06-03 20:42           ` Mark Cave-Ayland
2023-06-13 11:50             ` Markus Armbruster
2023-06-19 12:28               ` Mark Cave-Ayland
     [not found]   ` <edd9f126-526e-ee57-767b-a1d307008a4d@linaro.org>
2023-06-03 20:36     ` Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 06/23] q800: move ROM memory region to Q800MachineState Mark Cave-Ayland
2023-05-31 13:42   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 07/23] q800: move GLUE device into separate q800-glue.c file Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 08/23] q800: move GLUE device to Q800MachineState Mark Cave-Ayland
2023-05-31 13:43   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 09/23] q800: introduce mac-io container memory region Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 10/23] q800: reimplement mac-io region aliasing using IO " Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 11/23] q800: move VIA1 device to Q800MachineState Mark Cave-Ayland
2023-05-31 13:45   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 12/23] q800: move VIA2 " Mark Cave-Ayland
2023-05-31 13:47   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 13/23] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h Mark Cave-Ayland
2023-05-31 13:49   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 14/23] q800: move dp8393x device to Q800MachineState Mark Cave-Ayland
2023-05-31 13:49   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` Mark Cave-Ayland [this message]
2023-05-31 13:49   ` [PATCH v2 15/23] q800: move ESCC " Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 16/23] q800: move escc_orgate " Mark Cave-Ayland
2023-05-31 13:50   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 17/23] q800: move ESP " Mark Cave-Ayland
2023-05-31 13:51   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 18/23] q800: move SWIM " Mark Cave-Ayland
2023-05-31 13:51   ` Philippe Mathieu-Daudé
2023-05-31 12:53 ` [PATCH v2 19/23] q800: move mac-nubus-bridge " Mark Cave-Ayland
2023-05-31 13:52   ` Philippe Mathieu-Daudé
2023-06-03 20:22     ` Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 20/23] q800: don't access Nubus bus directly from the mac-nubus-bridge device Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 21/23] q800: move macfb device to Q800MachineState Mark Cave-Ayland
2023-05-31 13:55   ` Philippe Mathieu-Daudé
2023-06-03 20:32     ` Mark Cave-Ayland
2023-05-31 12:53 ` [PATCH v2 22/23] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf Mark Cave-Ayland
2023-05-31 12:54 ` [PATCH v2 23/23] mac_via: fix rtc command decoding for the PRAM seconds registers Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531125400.288917-16-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.