From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 370A4C7EE23 for ; Thu, 1 Jun 2023 07:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SDD/3UI/cHtTbF9UWtFfqioYU+XDD4DtM1lT8MDN8/U=; b=U+HiLjZtciVTiR 6g25hDZlNburM2DmJfVOopeHLuIRh87BZLvs4GVxyRgGIvbeBoNkaAioOa96lx33wjrBCjhzOTtKZ RL4PYA5vRrNdsfgeMFsC2EQiXEwsNnRgO1wScKlWmNhMjd3ptgVgkNu3NskpAOPMegBSo9WhLFyBd HKX/VAlwLdC+kUBfcXJn/nl+T3mOVsdbxXwkdUk+6swlH9iT4aoMhHE3C59NJKHd5+IS//Ci/wZEA G2tPRm50rdTcoPxq7OmFDiYWZRUMMwmlh0Fl9j3RkvtpO4advmw1RgDmIPigne9ZMW+MiFrnacBzD L0q7hjc+PYr48sfQScyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4d3j-002QIs-08; Thu, 01 Jun 2023 07:49:23 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4d3f-002QH6-0e for linux-mtd@lists.infradead.org; Thu, 01 Jun 2023 07:49:21 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685605753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8zgnzutmlxoB/RLgH8MCBdqpFZrjqcSK1xpIkDue6o=; b=KbeWYcIkRJ1sK7c0UlhKZhnmQ8JZHE5MzAxAfkwMiJ6rsCuqfR7J2qpxuwAwjR4KNy1cKZ P4ThP/k9rpHM/5CbGzqogIzEexqvotx5PqMxuOCTOwwS2Y+C557Jba38pbWPXrfpFJ3D8j G2yY5ib1G9o12uuxy65gvPoQj6UoYnfmGQ+sIEAEfEpmMwbf4nQ1B8zDAop80MAndIhX3I dJQCmb3du9+OmxJPYPcBjWq7UnH2tlTtz++DKJm6pDwu2WBs0TFFixhen7v79PL2IOrMI3 bz8YCrdizsPVkEja2BkNpTUlNT7unWKk3fYPEAuDTjErhGjeREpdk4v9jU/FSA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 1DBD640014; Thu, 1 Jun 2023 07:49:09 +0000 (UTC) Date: Thu, 1 Jun 2023 09:49:08 +0200 From: Miquel Raynal To: Nikita Shubin Cc: Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Richard Weinberger , Vignesh Raghavendra , Jonathan Cameron , Stephen Boyd , Christophe Kerello , Jean Delvare , Liang Yang , Florian Fainelli , Michael Peters , Kris Bahnsen , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v1 24/43] mtd: nand: add support for ts72xx Message-ID: <20230601094908.7838ec17@xps-13> In-Reply-To: <20230601054549.10843-6-nikita.shubin@maquefel.me> References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-6-nikita.shubin@maquefel.me> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_004919_544273_DED48B22 X-CRM114-Status: GOOD ( 33.05 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTmlraXRhLAoKbmlraXRhLnNodWJpbkBtYXF1ZWZlbC5tZSB3cm90ZSBvbiBUaHUsICAxIEp1 biAyMDIzIDA4OjQ1OjI5ICswMzAwOgoKPiBUZWNobm9sb2dpYyBTeXN0ZW1zIGhhcyBpdCdzIG93 biBuYW5kIGNvbnRyb2xsZXIgaW1wbGVtZW50YXRpb24gaW4gQ1BMRC4KPiAKPiBUaGlzIHBhdGNo IGFkZHMgc3VwcG9ydCBmb3IgVFMtNzJYWCBib2FyZHMgZmFtaWx5Lgo+IAo+IFNpZ25lZC1vZmYt Ynk6IE5pa2l0YSBTaHViaW4gPG5pa2l0YS5zaHViaW5AbWFxdWVmZWwubWU+Cj4gLS0tCj4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L0tjb25maWcgICAgICAgICAgICAgICAgICB8ICAgNyArCj4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L01ha2VmaWxlICAgICAgICAgICAgICAgICB8ICAgMSArCj4gIC4u Li9uYW5kL3Jhdy90ZWNobm9sb2dpYy1uYW5kLWNvbnRyb2xsZXIuYyAgICB8IDE1MSArKysrKysr KysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNTkgaW5zZXJ0aW9ucygrKQo+ICBjcmVh dGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQvbmFuZC9yYXcvdGVjaG5vbG9naWMtbmFuZC1jb250 cm9sbGVyLmMKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvS2NvbmZpZyBi L2RyaXZlcnMvbXRkL25hbmQvcmF3L0tjb25maWcKPiBpbmRleCBiNTIzMzU0ZGZiMDAuLjk0Nzg4 ZGExYTE2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9LY29uZmlnCj4gKysr IGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvS2NvbmZpZwo+IEBAIC00NTYsNiArNDU2LDEzIEBAIGNv bmZpZyBNVERfTkFORF9SRU5FU0FTCj4gIAkgIEVuYWJsZXMgc3VwcG9ydCBmb3IgdGhlIE5BTkQg Y29udHJvbGxlciBmb3VuZCBvbiBSZW5lc2FzIFItQ2FyCj4gIAkgIEdlbjMgYW5kIFJaL04xIFNv QyBmYW1pbGllcy4KPiAgCj4gK2NvbmZpZyBNVERfTkFORF9UUzcyWFgKPiArCWJvb2wgInRzNzJ4 eCBOQU5EIGNvbnRyb2xsZXIiCj4gKwlkZXBlbmRzIG9uIEFSQ0hfRVA5M1hYICYmIEhBU19JT01F TQo+ICsJaGVscAo+ICsJICBFbmFibGVzIHN1cHBvcnQgZm9yIE5BTkQgY29udHJvbGxlciBvbiB0 czcyeHggU0JDcy4KPiArCSAgVGhpcyBpcyBhIGxlZ2FjeSBkcml2ZXIgYmFzZWQgb24gZ2VuX25h bmQuCj4gKwo+ICBjb21tZW50ICJNaXNjIgo+ICAKPiAgY29uZmlnIE1URF9TTV9DT01NT04KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvTWFrZWZpbGUgYi9kcml2ZXJzL210ZC9u YW5kL3Jhdy9NYWtlZmlsZQo+IGluZGV4IDkxN2NkZmI4MTViOS4uNzgzZTk5MGEwMDc4IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9t dGQvbmFuZC9yYXcvTWFrZWZpbGUKPiBAQCAtMjMsNiArMjMsNyBAQCBvbWFwMl9uYW5kLW9ianMg Oj0gb21hcDIubwo+ICBvYmotJChDT05GSUdfTVREX05BTkRfT01BUDIpIAkJKz0gb21hcDJfbmFu ZC5vCj4gIG9iai0kKENPTkZJR19NVERfTkFORF9PTUFQX0JDSF9CVUlMRCkJKz0gb21hcF9lbG0u bwo+ICBvYmotJChDT05GSUdfTVREX05BTkRfTUFSVkVMTCkJCSs9IG1hcnZlbGxfbmFuZC5vCj4g K29iai0kKENPTkZJR19NVERfTkFORF9UUzcyWFgpCQkrPSB0ZWNobm9sb2dpYy1uYW5kLWNvbnRy b2xsZXIubwo+ICBvYmotJChDT05GSUdfTVREX05BTkRfUExBVEZPUk0pCQkrPSBwbGF0X25hbmQu bwo+ICBvYmotJChDT05GSUdfTVREX05BTkRfUEFTRU1JKQkJKz0gcGFzZW1pX25hbmQubwo+ICBv YmotJChDT05GSUdfTVREX05BTkRfT1JJT04pCQkrPSBvcmlvbl9uYW5kLm8KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvdGVjaG5vbG9naWMtbmFuZC1jb250cm9sbGVyLmMgYi9k cml2ZXJzL210ZC9uYW5kL3Jhdy90ZWNobm9sb2dpYy1uYW5kLWNvbnRyb2xsZXIuYwo+IG5ldyBm aWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi4wOWFlYWRhOTMzYTEKPiAtLS0g L2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvdGVjaG5vbG9naWMtbmFuZC1j b250cm9sbGVyLmMKPiBAQCAtMCwwICsxLDE1MSBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRp ZmllcjogR1BMLTIuMAo+ICsvKgo+ICsgKiBUZWNobm9sb2dpYyBTeXN0ZW1zIFRTNzJ4eCBOQU5E IGNvbnRyb2xsZXIgZHJpdmVyCj4gKyAqCj4gKyAqIENvcHlyaWdodCAoQykgMjAyMyBOaWtpdGEg U2h1YmluIDxuaWtpdGEuc2h1YmluQG1hcXVlZmVsLm1lPgo+ICsgKgo+ICsgKiBkZXJpdmVkOiBw bGF0X25hbmQuYwo+ICsgKiAgQXV0aG9yOiBWaXRhbHkgV29vbCA8dml0YWx5d29vbEBnbWFpbC5j b20+Cj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2Vyci5oPgo+ICsjaW5jbHVkZSA8bGlu dXgvaW8uaD4KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICsjaW5jbHVkZSA8bGludXgv cGxhdGZvcm1fZGV2aWNlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9zbGFiLmg+Cj4gKyNpbmNsdWRl IDxsaW51eC9tdGQvbXRkLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9tdGQvcGxhdG5hbmQuaD4KPiAr Cj4gKyNkZWZpbmUgVFM3MlhYX05BTkRfQ09OVFJPTF9BRERSX0xJTkUJMjIJLyogMHhOMDQwMDAw MCAqLwo+ICsjZGVmaW5lIFRTNzJYWF9OQU5EX0JVU1lfQUREUl9MSU5FCTIzCS8qIDB4TjA4MDAw MDAgKi8KPiArCj4gK3N0cnVjdCB0czcyeHhfbmFuZF9kYXRhIHsKPiArCXN0cnVjdCBuYW5kX2Nv bnRyb2xsZXIJY29udHJvbGxlcjsKPiArCXN0cnVjdCBuYW5kX2NoaXAJY2hpcDsKPiArCXZvaWQg X19pb21lbQkJKmlvX2Jhc2U7Cj4gK307Cj4gKwo+ICtzdGF0aWMgaW50IHRzNzJ4eF9uYW5kX2F0 dGFjaF9jaGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gK3sKPiArCWlmIChjaGlwLT5lY2Mu ZW5naW5lX3R5cGUgPT0gTkFORF9FQ0NfRU5HSU5FX1RZUEVfU09GVCAmJgo+ICsJICAgIGNoaXAt PmVjYy5hbGdvID09IE5BTkRfRUNDX0FMR09fVU5LTk9XTikKPiArCQljaGlwLT5lY2MuYWxnbyA9 IE5BTkRfRUNDX0FMR09fSEFNTUlORzsKCkkgYmVsaWV2ZSBlbmdpbmVfdHlwZSA9PSBPTl9IT1NU IHNob3VsZCByZXR1cm4gYW4gZXJyb3IuCgo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtz dGF0aWMgY29uc3Qgc3RydWN0IG5hbmRfY29udHJvbGxlcl9vcHMgdHM3Mnh4X25hbmRfb3BzID0g ewo+ICsJLmF0dGFjaF9jaGlwID0gdHM3Mnh4X25hbmRfYXR0YWNoX2NoaXAsCj4gK307Cj4gKwo+ ICtzdGF0aWMgdm9pZCB0czcyeHhfbmFuZF9od2NvbnRyb2woc3RydWN0IG5hbmRfY2hpcCAqY2hp cCwKPiArCQkJCSAgaW50IGNtZCwgdW5zaWduZWQgaW50IGN0cmwpCj4gK3sKPiArCWlmIChjdHJs ICYgTkFORF9DVFJMX0NIQU5HRSkgewo+ICsJCXZvaWQgX19pb21lbSAqYWRkciA9IGNoaXAtPmxl Z2FjeS5JT19BRERSX1I7Cj4gKwkJdW5zaWduZWQgY2hhciBiaXRzOwo+ICsKPiArCQlhZGRyICs9 ICgxIDw8IFRTNzJYWF9OQU5EX0NPTlRST0xfQUREUl9MSU5FKTsKPiArCj4gKwkJYml0cyA9IHJl YWRiKGFkZHIpICYgfjB4MDc7Cj4gKwkJYml0cyB8PSAoY3RybCAmIE5BTkRfTkNFKSA8PCAyOwkv KiBiaXQgMCAtPiBiaXQgMiAqLwo+ICsJCWJpdHMgfD0gKGN0cmwgJiBOQU5EX0NMRSk7CS8qIGJp dCAxIC0+IGJpdCAxICovCj4gKwkJYml0cyB8PSAoY3RybCAmIE5BTkRfQUxFKSA+PiAyOwkvKiBi aXQgMiAtPiBiaXQgMCAqLwo+ICsKPiArCQl3cml0ZWIoYml0cywgYWRkcik7Cj4gKwl9Cj4gKwo+ ICsJaWYgKGNtZCAhPSBOQU5EX0NNRF9OT05FKQo+ICsJCXdyaXRlYihjbWQsIGNoaXAtPmxlZ2Fj eS5JT19BRERSX1cpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHRzNzJ4eF9uYW5kX2RldmljZV9y ZWFkeShzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwKQo+ICt7Cj4gKwl2b2lkIF9faW9tZW0gKmFkZHIg PSBjaGlwLT5sZWdhY3kuSU9fQUREUl9SOwo+ICsKPiArCWFkZHIgKz0gKDEgPDwgVFM3MlhYX05B TkRfQlVTWV9BRERSX0xJTkUpOwo+ICsKPiArCXJldHVybiAhIShyZWFkYihhZGRyKSAmIDB4MjAp Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHRzNzJ4eF9uYW5kX3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4gK3sKPiArCXN0cnVjdCB0czcyeHhfbmFuZF9kYXRhICpkYXRhOwo+ ICsJc3RydWN0IG10ZF9pbmZvICptdGQ7Cj4gKwlpbnQgZXJyID0gMDsKPiArCj4gKwkvKiBBbGxv Y2F0ZSBtZW1vcnkgZm9yIHRoZSBkZXZpY2Ugc3RydWN0dXJlIChhbmQgemVybyBpdCkgKi8KPiAr CWRhdGEgPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKHN0cnVjdCB0czcyeHhfbmFu ZF9kYXRhKSwKPiArCQkJICAgIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFkYXRhKQo+ICsJCXJldHVy biAtRU5PTUVNOwo+ICsKPiArCWRhdGEtPmNvbnRyb2xsZXIub3BzID0gJnRzNzJ4eF9uYW5kX29w czsKPiArCW5hbmRfY29udHJvbGxlcl9pbml0KCZkYXRhLT5jb250cm9sbGVyKTsKPiArCWRhdGEt PmNoaXAuY29udHJvbGxlciA9ICZkYXRhLT5jb250cm9sbGVyOwo+ICsKPiArCWRhdGEtPmlvX2Jh c2UgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gKwlpZiAoSVNf RVJSKGRhdGEtPmlvX2Jhc2UpKQo+ICsJCXJldHVybiBQVFJfRVJSKGRhdGEtPmlvX2Jhc2UpOwo+ ICsKPiArCW5hbmRfc2V0X2ZsYXNoX25vZGUoJmRhdGEtPmNoaXAsIHBkZXYtPmRldi5vZl9ub2Rl KTsKPiArCW10ZCA9IG5hbmRfdG9fbXRkKCZkYXRhLT5jaGlwKTsKPiArCW10ZC0+ZGV2LnBhcmVu dCA9ICZwZGV2LT5kZXY7Cj4gKwo+ICsJZGF0YS0+Y2hpcC5sZWdhY3kuSU9fQUREUl9SID0gZGF0 YS0+aW9fYmFzZTsKPiArCWRhdGEtPmNoaXAubGVnYWN5LklPX0FERFJfVyA9IGRhdGEtPmlvX2Jh c2U7Cj4gKwlkYXRhLT5jaGlwLmxlZ2FjeS5jbWRfY3RybCA9IHRzNzJ4eF9uYW5kX2h3Y29udHJv bDsKPiArCWRhdGEtPmNoaXAubGVnYWN5LmRldl9yZWFkeSA9IHRzNzJ4eF9uYW5kX2RldmljZV9y ZWFkeTsKPiArCj4gKwlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBkYXRhKTsKPiArCj4gKwkv Kgo+ICsJICogVGhpcyBkcml2ZXIgYXNzdW1lcyB0aGF0IHRoZSBkZWZhdWx0IEVDQyBlbmdpbmUg c2hvdWxkIGJlIFRZUEVfU09GVC4KPiArCSAqIFNldCAtPmVuZ2luZV90eXBlIGJlZm9yZSByZWdp c3RlcmluZyB0aGUgTkFORCBkZXZpY2VzIGluIG9yZGVyIHRvCj4gKwkgKiBwcm92aWRlIGEgZHJp dmVyIHNwZWNpZmljIGRlZmF1bHQgdmFsdWUuCj4gKwkgKi8KPiArCWRhdGEtPmNoaXAuZWNjLmVu Z2luZV90eXBlID0gTkFORF9FQ0NfRU5HSU5FX1RZUEVfU09GVDsKPiArCj4gKwkvKiBTY2FuIHRv IGZpbmQgZXhpc3RlbmNlIG9mIHRoZSBkZXZpY2UgKi8KPiArCWVyciA9IG5hbmRfc2NhbigmZGF0 YS0+Y2hpcCwgMSk7Cj4gKwlpZiAoZXJyKQo+ICsJCXJldHVybiBlcnI7Cj4gKwo+ICsJZXJyID0g bXRkX2RldmljZV9wYXJzZV9yZWdpc3RlcihtdGQsIE5VTEwsIE5VTEwsCj4gKwkJCQkJTlVMTCwg MCk7CgpUaGUgdXN1YWwgd2F5IC1hbmQgbW9yZSByZWFkYWJsZS0gaXMgdG8ganVtcCB0byBhIGdv dG8gbGFiZWwgdXBvbgplcnJvciwgYW5kIHJldHVybiAwIGluIHRoZSBub3JtYWwgcGF0aC4KPiAr Cj4gKwlpZiAoIWVycikKPiArCQlyZXR1cm4gZXJyOwo+ICsKPiArCW5hbmRfY2xlYW51cCgmZGF0 YS0+Y2hpcCk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHRzNzJ4 eF9uYW5kX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICt7Cj4gKwlzdHJ1 Y3QgdHM3Mnh4X25hbmRfZGF0YSAqZGF0YSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ ICsJc3RydWN0IG5hbmRfY2hpcCAqY2hpcCA9ICZkYXRhLT5jaGlwOwo+ICsJaW50IHJldDsKPiAr Cj4gKwlyZXQgPSBtdGRfZGV2aWNlX3VucmVnaXN0ZXIobmFuZF90b19tdGQoY2hpcCkpOwo+ICsJ V0FSTl9PTihyZXQpOwo+ICsJbmFuZF9jbGVhbnVwKGNoaXApOwo+ICt9Cj4gKwo+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCB0czcyeHhfaWRfdGFibGVbXSA9IHsKPiArCXsgLmNv bXBhdGlibGUgPSAidGVjaG5vbG9naWMsdHM3MjAwLW5hbmQiIH0sCj4gKwl7IC8qIHNlbnRpbmVs ICovIH0KPiArfTsKPiArTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgdHM3Mnh4X2lkX3RhYmxlKTsK PiArCj4gK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHRzNzJ4eF9uYW5kX2RyaXZlciA9 IHsKPiArCS5kcml2ZXIgPSB7Cj4gKwkJLm5hbWUgPSAidHM3Mnh4LW5hbmQiLAo+ICsJCS5vZl9t YXRjaF90YWJsZSA9IHRzNzJ4eF9pZF90YWJsZSwKPiArCX0sCj4gKwkucHJvYmUgPSB0czcyeHhf bmFuZF9wcm9iZSwKPiArCS5yZW1vdmVfbmV3ID0gdHM3Mnh4X25hbmRfcmVtb3ZlLAo+ICt9Owo+ ICttb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHRzNzJ4eF9uYW5kX2RyaXZlcik7Cj4gKwoKClRoYW5r cywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82201C7EE23 for ; Thu, 1 Jun 2023 07:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbjFAH5F (ORCPT ); Thu, 1 Jun 2023 03:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbjFAHzA (ORCPT ); Thu, 1 Jun 2023 03:55:00 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A95B1A1 for ; Thu, 1 Jun 2023 00:49:15 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685605753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8zgnzutmlxoB/RLgH8MCBdqpFZrjqcSK1xpIkDue6o=; b=KbeWYcIkRJ1sK7c0UlhKZhnmQ8JZHE5MzAxAfkwMiJ6rsCuqfR7J2qpxuwAwjR4KNy1cKZ P4ThP/k9rpHM/5CbGzqogIzEexqvotx5PqMxuOCTOwwS2Y+C557Jba38pbWPXrfpFJ3D8j G2yY5ib1G9o12uuxy65gvPoQj6UoYnfmGQ+sIEAEfEpmMwbf4nQ1B8zDAop80MAndIhX3I dJQCmb3du9+OmxJPYPcBjWq7UnH2tlTtz++DKJm6pDwu2WBs0TFFixhen7v79PL2IOrMI3 bz8YCrdizsPVkEja2BkNpTUlNT7unWKk3fYPEAuDTjErhGjeREpdk4v9jU/FSA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 1DBD640014; Thu, 1 Jun 2023 07:49:09 +0000 (UTC) Date: Thu, 1 Jun 2023 09:49:08 +0200 From: Miquel Raynal To: Nikita Shubin Cc: Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Richard Weinberger , Vignesh Raghavendra , Jonathan Cameron , Stephen Boyd , Christophe Kerello , Jean Delvare , Liang Yang , Florian Fainelli , Michael Peters , Kris Bahnsen , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v1 24/43] mtd: nand: add support for ts72xx Message-ID: <20230601094908.7838ec17@xps-13> In-Reply-To: <20230601054549.10843-6-nikita.shubin@maquefel.me> References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-6-nikita.shubin@maquefel.me> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikita, nikita.shubin@maquefel.me wrote on Thu, 1 Jun 2023 08:45:29 +0300: > Technologic Systems has it's own nand controller implementation in CPLD. >=20 > This patch adds support for TS-72XX boards family. >=20 > Signed-off-by: Nikita Shubin > --- > drivers/mtd/nand/raw/Kconfig | 7 + > drivers/mtd/nand/raw/Makefile | 1 + > .../nand/raw/technologic-nand-controller.c | 151 ++++++++++++++++++ > 3 files changed, 159 insertions(+) > create mode 100644 drivers/mtd/nand/raw/technologic-nand-controller.c >=20 > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index b523354dfb00..94788da1a169 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -456,6 +456,13 @@ config MTD_NAND_RENESAS > Enables support for the NAND controller found on Renesas R-Car > Gen3 and RZ/N1 SoC families. > =20 > +config MTD_NAND_TS72XX > + bool "ts72xx NAND controller" > + depends on ARCH_EP93XX && HAS_IOMEM > + help > + Enables support for NAND controller on ts72xx SBCs. > + This is a legacy driver based on gen_nand. > + > comment "Misc" > =20 > config MTD_SM_COMMON > diff --git a/drivers/mtd/nand/raw/Makefile b/drivers/mtd/nand/raw/Makefile > index 917cdfb815b9..783e990a0078 100644 > --- a/drivers/mtd/nand/raw/Makefile > +++ b/drivers/mtd/nand/raw/Makefile > @@ -23,6 +23,7 @@ omap2_nand-objs :=3D omap2.o > obj-$(CONFIG_MTD_NAND_OMAP2) +=3D omap2_nand.o > obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) +=3D omap_elm.o > obj-$(CONFIG_MTD_NAND_MARVELL) +=3D marvell_nand.o > +obj-$(CONFIG_MTD_NAND_TS72XX) +=3D technologic-nand-controller.o > obj-$(CONFIG_MTD_NAND_PLATFORM) +=3D plat_nand.o > obj-$(CONFIG_MTD_NAND_PASEMI) +=3D pasemi_nand.o > obj-$(CONFIG_MTD_NAND_ORION) +=3D orion_nand.o > diff --git a/drivers/mtd/nand/raw/technologic-nand-controller.c b/drivers= /mtd/nand/raw/technologic-nand-controller.c > new file mode 100644 > index 000000000000..09aeada933a1 > --- /dev/null > +++ b/drivers/mtd/nand/raw/technologic-nand-controller.c > @@ -0,0 +1,151 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Technologic Systems TS72xx NAND controller driver > + * > + * Copyright (C) 2023 Nikita Shubin > + * > + * derived: plat_nand.c > + * Author: Vitaly Wool > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define TS72XX_NAND_CONTROL_ADDR_LINE 22 /* 0xN0400000 */ > +#define TS72XX_NAND_BUSY_ADDR_LINE 23 /* 0xN0800000 */ > + > +struct ts72xx_nand_data { > + struct nand_controller controller; > + struct nand_chip chip; > + void __iomem *io_base; > +}; > + > +static int ts72xx_nand_attach_chip(struct nand_chip *chip) > +{ > + if (chip->ecc.engine_type =3D=3D NAND_ECC_ENGINE_TYPE_SOFT && > + chip->ecc.algo =3D=3D NAND_ECC_ALGO_UNKNOWN) > + chip->ecc.algo =3D NAND_ECC_ALGO_HAMMING; I believe engine_type =3D=3D ON_HOST should return an error. > + > + return 0; > +} > + > +static const struct nand_controller_ops ts72xx_nand_ops =3D { > + .attach_chip =3D ts72xx_nand_attach_chip, > +}; > + > +static void ts72xx_nand_hwcontrol(struct nand_chip *chip, > + int cmd, unsigned int ctrl) > +{ > + if (ctrl & NAND_CTRL_CHANGE) { > + void __iomem *addr =3D chip->legacy.IO_ADDR_R; > + unsigned char bits; > + > + addr +=3D (1 << TS72XX_NAND_CONTROL_ADDR_LINE); > + > + bits =3D readb(addr) & ~0x07; > + bits |=3D (ctrl & NAND_NCE) << 2; /* bit 0 -> bit 2 */ > + bits |=3D (ctrl & NAND_CLE); /* bit 1 -> bit 1 */ > + bits |=3D (ctrl & NAND_ALE) >> 2; /* bit 2 -> bit 0 */ > + > + writeb(bits, addr); > + } > + > + if (cmd !=3D NAND_CMD_NONE) > + writeb(cmd, chip->legacy.IO_ADDR_W); > +} > + > +static int ts72xx_nand_device_ready(struct nand_chip *chip) > +{ > + void __iomem *addr =3D chip->legacy.IO_ADDR_R; > + > + addr +=3D (1 << TS72XX_NAND_BUSY_ADDR_LINE); > + > + return !!(readb(addr) & 0x20); > +} > + > +static int ts72xx_nand_probe(struct platform_device *pdev) > +{ > + struct ts72xx_nand_data *data; > + struct mtd_info *mtd; > + int err =3D 0; > + > + /* Allocate memory for the device structure (and zero it) */ > + data =3D devm_kzalloc(&pdev->dev, sizeof(struct ts72xx_nand_data), > + GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + data->controller.ops =3D &ts72xx_nand_ops; > + nand_controller_init(&data->controller); > + data->chip.controller =3D &data->controller; > + > + data->io_base =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(data->io_base)) > + return PTR_ERR(data->io_base); > + > + nand_set_flash_node(&data->chip, pdev->dev.of_node); > + mtd =3D nand_to_mtd(&data->chip); > + mtd->dev.parent =3D &pdev->dev; > + > + data->chip.legacy.IO_ADDR_R =3D data->io_base; > + data->chip.legacy.IO_ADDR_W =3D data->io_base; > + data->chip.legacy.cmd_ctrl =3D ts72xx_nand_hwcontrol; > + data->chip.legacy.dev_ready =3D ts72xx_nand_device_ready; > + > + platform_set_drvdata(pdev, data); > + > + /* > + * This driver assumes that the default ECC engine should be TYPE_SOFT. > + * Set ->engine_type before registering the NAND devices in order to > + * provide a driver specific default value. > + */ > + data->chip.ecc.engine_type =3D NAND_ECC_ENGINE_TYPE_SOFT; > + > + /* Scan to find existence of the device */ > + err =3D nand_scan(&data->chip, 1); > + if (err) > + return err; > + > + err =3D mtd_device_parse_register(mtd, NULL, NULL, > + NULL, 0); The usual way -and more readable- is to jump to a goto label upon error, and return 0 in the normal path. > + > + if (!err) > + return err; > + > + nand_cleanup(&data->chip); > + > + return 0; > +} > + > +static void ts72xx_nand_remove(struct platform_device *pdev) > +{ > + struct ts72xx_nand_data *data =3D platform_get_drvdata(pdev); > + struct nand_chip *chip =3D &data->chip; > + int ret; > + > + ret =3D mtd_device_unregister(nand_to_mtd(chip)); > + WARN_ON(ret); > + nand_cleanup(chip); > +} > + > +static const struct of_device_id ts72xx_id_table[] =3D { > + { .compatible =3D "technologic,ts7200-nand" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, ts72xx_id_table); > + > +static struct platform_driver ts72xx_nand_driver =3D { > + .driver =3D { > + .name =3D "ts72xx-nand", > + .of_match_table =3D ts72xx_id_table, > + }, > + .probe =3D ts72xx_nand_probe, > + .remove_new =3D ts72xx_nand_remove, > +}; > +module_platform_driver(ts72xx_nand_driver); > + Thanks, Miqu=C3=A8l