From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8492BC7EE29 for ; Tue, 6 Jun 2023 12:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236095AbjFFMVF (ORCPT ); Tue, 6 Jun 2023 08:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230297AbjFFMVC (ORCPT ); Tue, 6 Jun 2023 08:21:02 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DE0F3E54; Tue, 6 Jun 2023 05:21:01 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 303FA80AE; Tue, 6 Jun 2023 12:21:01 +0000 (UTC) Date: Tue, 6 Jun 2023 15:20:59 +0300 From: Tony Lindgren To: Chen-Yu Tsai Cc: John Ogness , Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM Message-ID: <20230606122059.GC14287@atomide.com> References: <20230602083335.GA181647@google.com> <87a5xii33r.fsf@jogness.linutronix.de> <20230603054139.GR14287@atomide.com> <20230603063533.GS14287@atomide.com> <20230605061511.GW14287@atomide.com> <20230605122447.GY14287@atomide.com> <20230605131803.GA14287@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Chen-Yu Tsai [230606 09:17]: > I ended up following 8250_dw's design, which seemed less convoluted. > The original code was waaay too convoluted. OK that looks good to me thanks. Good to hear you got it sorted out. The 8250_dw style runtime PM is a good solution for simple cases. Where it won't work are SoCs where runtime PM calls need to propagate up the bus hierarchy. For example, 8250_omap needs runtime PM calls for the interconnect and power domain to get register access working. > BTW, the Bluetooth breakage seems like a different problem. OK seems like we're good to go then :) Regards, Tony