From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 857E4C77B7A for ; Tue, 6 Jun 2023 13:49:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D75AA85A97; Tue, 6 Jun 2023 15:49:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VxEcn0ql"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2539985A97; Tue, 6 Jun 2023 15:49:06 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E76A5859F2 for ; Tue, 6 Jun 2023 15:49:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-bb131cd7c4aso5343202276.1 for ; Tue, 06 Jun 2023 06:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1686059339; x=1688651339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V1+TPahqJ7TVSD0JVLJhesZAv74He29F98egxE+DdnE=; b=VxEcn0ql3qryI3gC5dYEyeHbSjONTngV7pvewq/EncV8Uw6CaTMuKF7wVyqcuP4kJc PQ5gGD7S8VC1oHd+QuVW7BhrYSZPb3KECo0Y16ymo5w8juO8r3NHbxjLukHI+jtkOTLE 6o88fAG9KX6jYH9X1bOM5JFN0V5Cc49TSNz6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686059339; x=1688651339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V1+TPahqJ7TVSD0JVLJhesZAv74He29F98egxE+DdnE=; b=RdPdlMIKnHEHejie3oZwLkxZ3YMfrXHUpEUoalhw0vJhaosHmkGXcKcVZFVGP9S3mF 4tvDaoDIcB6T5QhQpHxfYVTla5JzvLPo4eBWe45up6z3IvoewPQ1ltrDFuxKZ8CGrX8w q06QlNWSqXjuS53+RFkZrds/C/335+3jGl7dfb37rW/FsfQ//1YNZARyz+fovESA6tcW DLDQEZaqKNKReiZj5dpN+Gnt9MKLZ3ak6pT5zLqYT4xmdKUqr6HdAU0ogIAnF4sMPPpl EZozZbQd/X6WlwLAmnY7ARnYyhGsAor8qIOAFtnh2VT8NSJolZ/0Dk8zWQhQ12hoiSSC Di9g== X-Gm-Message-State: AC+VfDwED5Qt55dHc6lmo0QBXqLj+8K9ha5TuPDn8NuJKkd8drtYaQL+ 0R8JkMRFzMwH6oh/gdzJ56bgWg== X-Google-Smtp-Source: ACHHUZ7pDoEwBVnDv1YZ7SIFAMttrcbBGXqqf3gbaLqckO3jF4r83DpgB8X6hLh1ImGRz/o1nU6OpA== X-Received: by 2002:a81:a194:0:b0:55a:1f2:ef6 with SMTP id y142-20020a81a194000000b0055a01f20ef6mr2168669ywg.9.1686059339402; Tue, 06 Jun 2023 06:48:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-99ca-6782-9ebf-4e83.res6.spectrum.com. [2603:6081:7b00:6400:99ca:6782:9ebf:4e83]) by smtp.gmail.com with ESMTPSA id u5-20020a0deb05000000b0055a07585a91sm4115286ywe.11.2023.06.06.06.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 06:48:58 -0700 (PDT) Date: Tue, 6 Jun 2023 09:48:56 -0400 From: Tom Rini To: Abdellatif El Khlifi Cc: sjg@chromium.org, nd@arm.com, u-boot@lists.denx.de, ilias.apalodimas@linaro.org Subject: Re: [PATCH v12 00/10] introduce Arm FF-A support Message-ID: <20230606134856.GA1871110@bill-the-cat> References: <20230412094245.44674-1-abdellatif.elkhlifi@arm.com> <20230512121044.111574-1-abdellatif.elkhlifi@arm.com> <20230522091320.GA31886@e130802.arm.com> <20230606115628.GA17201@e130802.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2J9p9Hh5zzTyDZlX" Content-Disposition: inline In-Reply-To: <20230606115628.GA17201@e130802.arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --2J9p9Hh5zzTyDZlX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 06, 2023 at 12:56:28PM +0100, Abdellatif El Khlifi wrote: > On Mon, May 22, 2023 at 10:13:20AM +0100, Abdellatif El Khlifi wrote: >=20 > Hi Simon, Tom, >=20 > > Hi Simon, > >=20 > > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A)= [A]. > > >=20 > > > FF-A specifies interfaces that enable a pair of software execution en= vironments aka partitions to > > > communicate with each other. A partition could be a VM in the Normal = or Secure world, an > > > application in S-EL0, or a Trusted OS in S-EL1. > > >=20 > > > FF-A is a discoverable bus and similar to architecture features. > > > FF-A bus is discovered using ARM_SMCCC_FEATURES mechanism performed > > > by the PSCI driver. > > >=20 > > > =3D> dm tree > > >=20 > > > Class Index Probed Driver Name > > > ----------------------------------------------------------- > > > ... > > > firmware 0 [ + ] psci |-- psci > > > ffa 0 [ ] arm_ffa | `-- ar= m_ffa > > > ... > > >=20 > > > Clients are able to probe then use the FF-A bus by calling the DM cla= ss > > > searching APIs (e.g: uclass_first_device). > > >=20 > > > This implementation of the specification provides support for Aarch64. > > >=20 > > > The FF-A driver uses the SMC ABIs defined by the FF-A specification t= o: > > >=20 > > > - Discover the presence of secure partitions (SPs) of interest > > > - Access an SP's service through communication protocols > > > (e.g: EFI MM communication protocol) > > >=20 > > > The FF-A support provides the following features: > > >=20 > > > - Being generic by design and can be used by any Arm 64-bit platf= orm > > > - FF-A support can be compiled and used without EFI > > > - Support for SMCCCv1.2 x0-x17 registers > > > - Support for SMC32 calling convention > > > - Support for 32-bit and 64-bit FF-A direct messaging > > > - Support for FF-A MM communication (compatible with EFI boot tim= e) > > > - Enabling FF-A and MM communication in Corstone1000 platform as = a use case > > > - A Uclass driver providing generic FF-A methods. > > > - An Arm FF-A device driver providing Arm-specific methods and re= using the Uclass methods. > > > - A sandbox emulator for Arm FF-A, emulates the FF-A side of the = Secure World and provides > > > FF-A ABIs inspection methods. > > > - An FF-A sandbox device driver for FF-A communication with the e= mulated Secure World. > > > The driver leverages the FF-A Uclass to establish FF-A communic= ation. > > > - Sandbox FF-A test cases. > > > - A new command called armffa is provided as an example of how to= access the > > > FF-A bus > > >=20 > > > For more details about the FF-A support please refer to [B] and refer= to [C] for > > > how to use the armffa command. > > >=20 > > > Please find at [D] an example of the expected boot logs when enabling > > > FF-A support for a platform. In this example the platform is > > > Corstone1000. But it can be any Arm 64-bit platform. > > >=20 > > > Changelog of the major changes: > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > >=20 > > > v12: > > >=20 > > > * remove the global variable (dscvry_info), use uc_priv instead > > > * replace dscvry_info.invoke_ffa_fn() with a weak invoke_ffa_fn > > > (user drivers can override it) > > > * improve FFA_PARTITION_INFO_GET implementation > > > (clients no longer need to calloc a buffer) > > > * remove reparenting by making the sandbox emulator parent of the FF-= A device in the DT > > > * improve argument checks for the armffa command > > > * address nits > > >=20 > ... > > > Cc: Tom Rini > > > Cc: Simon Glass > >=20 > > A gentle reminder about the v12 patchset. > >=20 > > Your feedback is more than welcome :) >=20 > Could you please provide a feedback about the v12 patchset ? >=20 > Most of the patches are generic. >=20 > I'm gonna address Ilias comment for patch #9 with your future comments. >=20 > Your review is very much appreciated. I've been waiting for Ilias to be happy with the series and then I'll pick it up for -next. --=20 Tom --2J9p9Hh5zzTyDZlX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmR/OUEACgkQFHw5/5Y0 tyx64gv/ckVis7isQ5MOu06O3cUcBwAPpQZiC6S8XqBIL1hafseMLxnUhZ+JkZoY ASe2cGPXqMpxLQpY+/tTObV+FJoukvr7/6+yjnRQOzTRrBY2wUBJoIMUEUSAzA0K A36EPR4O4two455q+id4mnWMAjBWRdWrdte1GDnuh/gU4Dmnnf7Ft+CffVVTUSQt FMvbvl28m2BCrzq8uPqDu6uYB6OMv/UZAgJzXioUpX5P8aRHCb6xOb2ITGle1SuT hv/HGHA0U0qKef14PrnHIJO0AQE2P2RAQ5i+r6NuFqWdrsyajMK2mkNUI5RgJuQE teAVYHHahiq9zJYYiJ1AJ6uuGzoz1Gtu1c0ZxpP9hGb+uQ0ow/TLt45nuRyynYwX AFcb0M3IIW9gt15xmlHoioFwPxi7+3z0+DU80v9TCZvPnz5xHDtMybP8gMyGngfE 5Ws49Up1CODo2D5qj5G9r4By5nqltSYDk5XyRbOOaiZdnxjs5DGp6vz+k9ZO8SRh WBs2/S0c =MvDN -----END PGP SIGNATURE----- --2J9p9Hh5zzTyDZlX--