From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2BDAC7EE29 for ; Thu, 8 Jun 2023 20:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbjFHU6y (ORCPT ); Thu, 8 Jun 2023 16:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbjFHU6x (ORCPT ); Thu, 8 Jun 2023 16:58:53 -0400 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BADB269A; Thu, 8 Jun 2023 13:58:52 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-33b1da9a8acso4884465ab.3; Thu, 08 Jun 2023 13:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686257931; x=1688849931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2FMvGYAzuZRfNH9ntpuhSoq2QKXt57EC2toGT1Yc+LQ=; b=B163tFeOKLbvVhXiLjMGP1hgJkXxkDKFBQ/X9ZpS6zwB2qzr1ztKXy6ncSoFCBiTTs qu1RYcLZCXthMZykAcp4xYvrNl7tnuT87AmtCGd6jMkVNSraTfxUXJJZOamLs+rQBiuX SBQGNKLNDRsHsrKFISTfXexEU+TnyQd/YLa+aEQxDgvVDX1a5MKokuLrqLNAWGXiBKxA dpC+VuuAz6h2jYpNgbxvvuyYKgani+hy4pvMUipp8sYwLMS3xM5yUUnJcNWBnkBiBNmR efa2PkPAlF11EfVh8FncgJjMdDkClmC/VSU47SCzUkYsANtIQfDp5rXnWE8ufnK58K+u o9wA== X-Gm-Message-State: AC+VfDyvYB2ko9iMVcWZV3fYnBOdhPZ4Mu25hlS6p4AXiegWCZCFK/6F 4BMVa0f8y2919c7sqzXtIQ== X-Google-Smtp-Source: ACHHUZ5ulKJE2NEgESnPWkXHIhgORYjMch54tcncszW51gmLv2NwnUQflJQQonqUZB/1nKyGzK2X8A== X-Received: by 2002:a92:cc01:0:b0:33c:b80e:4599 with SMTP id s1-20020a92cc01000000b0033cb80e4599mr11532791ilp.9.1686257931638; Thu, 08 Jun 2023 13:58:51 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id z12-20020a92d6cc000000b0033bea7559ffsm630717ilp.53.2023.06.08.13.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 13:58:50 -0700 (PDT) Received: (nullmailer pid 3434522 invoked by uid 1000); Thu, 08 Jun 2023 20:58:48 -0000 Date: Thu, 8 Jun 2023 14:58:48 -0600 From: Rob Herring To: Konrad Dybcio Cc: Krzysztof Kozlowski , freedreno@lists.freedesktop.org, Sean Paul , Akhil P Oommen , devicetree@vger.kernel.org, Bjorn Andersson , Marijn Suijten , linux-arm-msm@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Rob Clark , Abhinav Kumar , Conor Dooley , Daniel Vetter , Rob Clark , Konrad Dybcio , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Dmitry Baryshkov Subject: Re: [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx Message-ID: <20230608205848.GA3424883-robh@kernel.org> References: <20230223-topic-gmuwrapper-v8-0-69c68206609e@linaro.org> <20230223-topic-gmuwrapper-v8-1-69c68206609e@linaro.org> <20230530122652.lct6tk6zseny6gxl@krzk-bin> <1ceeb56e-3efd-6858-358a-bd1976c625b1@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ceeb56e-3efd-6858-358a-bd1976c625b1@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: > > > On 30.05.2023 14:26, Krzysztof Kozlowski wrote: > > On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: > >> The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks > >> we'd normally assign to the GMU as if they were a part of the GMU, even > >> though they are not". It's a (good) software representation of the GMU_CX > >> and GMU_GX register spaces within the GPUSS that helps us programatically > >> treat these de-facto GMU-less parts in a way that's very similar to their > >> GMU-equipped cousins, massively saving up on code duplication. > >> > >> The "wrapper" register space was specifically designed to mimic the layout > >> of a real GMU, though it rather obviously does not have the M3 core et al. > >> > >> GMU wrapper-equipped A6xx GPUs require clocks and clock-names to be > >> specified under the GPU node, just like their older cousins. Account > >> for that. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >> .../devicetree/bindings/display/msm/gpu.yaml | 61 ++++++++++++++++++---- > >> 1 file changed, 52 insertions(+), 9 deletions(-) > >> > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > I think it'd be beneficial if the bot diffed the output of checks pre- > and post- patch. Fix all the warnings and it will. ;) Care to donate h/w to run the build twice every time? Really what I care about on these is when I keep getting changes to a schema and the list of warnings remains long and not getting fixed. This case was less than useful with just the oneOf warning. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38315C7EE25 for ; Thu, 8 Jun 2023 20:58:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D77A10E087; Thu, 8 Jun 2023 20:58:54 +0000 (UTC) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFDD210E087; Thu, 8 Jun 2023 20:58:52 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-33b1da9a8acso4884475ab.3; Thu, 08 Jun 2023 13:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686257931; x=1688849931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2FMvGYAzuZRfNH9ntpuhSoq2QKXt57EC2toGT1Yc+LQ=; b=RV2k5pDfTY0ZYIxoqDoSO1pu/adbKnwqvIO7/0oblKdv6Ho1SoJbCsfvSjC6msaFlR PSejtDaB4xMnrYyK+fnmgW/98XAsUY/MKWzfZBTONykqsCQ22y+UI3K6wDNvTCot8kpW xIbnMt1fjaY/ZWNGuNjMhOi8mGcqQHxwDuEa126PVq4ItL4L/dwK6J7djYJPOrq7eYPI ieHSZ4YGYExnRWAcroX0Hsjq/8Qk89m/bzlqR4WihzvCV3wBJyoRqca8h1+UO4WOyAYU IIq3EkxkboKVJE8vk0k0s5L4enmKAs3iN+pBx6JQwkzu1wGKqvtIf3A4ThE8lUC3qVSV obZQ== X-Gm-Message-State: AC+VfDxsBxoe/z8N6LR5dYVnYO4lNCYfS/s9gH0z5m+cm/yapgpfqrxU /W1UL8FWEApzRKNqUHiURg== X-Google-Smtp-Source: ACHHUZ5ulKJE2NEgESnPWkXHIhgORYjMch54tcncszW51gmLv2NwnUQflJQQonqUZB/1nKyGzK2X8A== X-Received: by 2002:a92:cc01:0:b0:33c:b80e:4599 with SMTP id s1-20020a92cc01000000b0033cb80e4599mr11532791ilp.9.1686257931638; Thu, 08 Jun 2023 13:58:51 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id z12-20020a92d6cc000000b0033bea7559ffsm630717ilp.53.2023.06.08.13.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 13:58:50 -0700 (PDT) Received: (nullmailer pid 3434522 invoked by uid 1000); Thu, 08 Jun 2023 20:58:48 -0000 Date: Thu, 8 Jun 2023 14:58:48 -0600 From: Rob Herring To: Konrad Dybcio Subject: Re: [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx Message-ID: <20230608205848.GA3424883-robh@kernel.org> References: <20230223-topic-gmuwrapper-v8-0-69c68206609e@linaro.org> <20230223-topic-gmuwrapper-v8-1-69c68206609e@linaro.org> <20230530122652.lct6tk6zseny6gxl@krzk-bin> <1ceeb56e-3efd-6858-358a-bd1976c625b1@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ceeb56e-3efd-6858-358a-bd1976c625b1@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Akhil P Oommen , freedreno@lists.freedesktop.org, Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, Abhinav Kumar , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: > > > On 30.05.2023 14:26, Krzysztof Kozlowski wrote: > > On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: > >> The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks > >> we'd normally assign to the GMU as if they were a part of the GMU, even > >> though they are not". It's a (good) software representation of the GMU_CX > >> and GMU_GX register spaces within the GPUSS that helps us programatically > >> treat these de-facto GMU-less parts in a way that's very similar to their > >> GMU-equipped cousins, massively saving up on code duplication. > >> > >> The "wrapper" register space was specifically designed to mimic the layout > >> of a real GMU, though it rather obviously does not have the M3 core et al. > >> > >> GMU wrapper-equipped A6xx GPUs require clocks and clock-names to be > >> specified under the GPU node, just like their older cousins. Account > >> for that. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >> .../devicetree/bindings/display/msm/gpu.yaml | 61 ++++++++++++++++++---- > >> 1 file changed, 52 insertions(+), 9 deletions(-) > >> > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > I think it'd be beneficial if the bot diffed the output of checks pre- > and post- patch. Fix all the warnings and it will. ;) Care to donate h/w to run the build twice every time? Really what I care about on these is when I keep getting changes to a schema and the list of warnings remains long and not getting fixed. This case was less than useful with just the oneOf warning. Rob