From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59490174FA; Tue, 13 Jun 2023 21:09:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CA2C433C0; Tue, 13 Jun 2023 21:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686690580; bh=CnDPIeLogwBWCfXwDFCGYSnn6freMhcPiMKmnauZmK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZwHrH/UtQy5gtJuV6CZdRxLuHzTaAkiUGIx/JgEU65AMLsBIKZ0sWdlw1vTEQYgdy gSLYt19YIoeRBe5zYzLlgTuRTMMo3kgRmlRYZUwN9+y0DX2gj67q8Dp8pJtQUo0gHp Oy60KuQPQMSSexOGqUQrMmT3Fgb1GBewXzaMMxDEmcoyUN9bNnKzEk/bEsVagentbs IrjokONRoY0TE+yzqvQqq0avTQyKOfbb7gZycLtP7znx6sVR7tnvKBFHLqFKSVwEs2 kIA6GPsL9JTaWmKMWc1Wdyo1oerK/huG9zsVu6RfIYfLEAg8ULTJ9IL3DRtm5ddTXF JrMlJp241w1cA== Date: Wed, 14 Jun 2023 00:09:00 +0300 From: Mike Rapoport To: Kent Overstreet Cc: Song Liu , Mark Rutland , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 00/13] mm: jit/text allocator Message-ID: <20230613210900.GV52412@kernel.org> References: <20230601101257.530867-1-rppt@kernel.org> <20230605092040.GB3460@kernel.org> <20230608184116.GJ52412@kernel.org> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jun 13, 2023 at 02:56:14PM -0400, Kent Overstreet wrote: > On Thu, Jun 08, 2023 at 09:41:16PM +0300, Mike Rapoport wrote: > > On Tue, Jun 06, 2023 at 11:21:59AM -0700, Song Liu wrote: > > > On Mon, Jun 5, 2023 at 3:09 AM Mark Rutland wrote: > > > > > > [...] > > > > > > > > > > Can you give more detail on what parameters you need? If the only extra > > > > > > > parameter is just "does this allocation need to live close to kernel > > > > > > > text", that's not that big of a deal. > > > > > > > > > > > > My thinking was that we at least need the start + end for each caller. That > > > > > > might be it, tbh. > > > > > > > > > > Do you mean that modules will have something like > > > > > > > > > > jit_text_alloc(size, MODULES_START, MODULES_END); > > > > > > > > > > and kprobes will have > > > > > > > > > > jit_text_alloc(size, KPROBES_START, KPROBES_END); > > > > > ? > > > > > > > > Yes. > > > > > > How about we start with two APIs: > > > jit_text_alloc(size); > > > jit_text_alloc_range(size, start, end); > > > > > > AFAICT, arm64 is the only arch that requires the latter API. And TBH, I am > > > not quite convinced it is needed. > > > > Right now arm64 and riscv override bpf and kprobes allocations to use the > > entire vmalloc address space, but having the ability to allocate generated > > code outside of modules area may be useful for other architectures. > > > > Still the start + end for the callers feels backwards to me because the > > callers do not define the ranges, but rather the architectures, so we still > > need a way for architectures to define how they want allocate memory for > > the generated code. > > So, the start + end just comes from the need to keep relative pointers > under a certain size. I think this could be just a flag, I see no reason > to expose actual addresses here. It's the other way around. The start + end comes from the need to restrict allocation to certain range because of the relative addressing. I don't see how a flag can help here. -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB021EB64D8 for ; Tue, 13 Jun 2023 21:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ElFfQ1Qhgy0/BwLIhPGM4kYj97ysLjPsuqH6c3kia30=; b=xfLLvGuabMLr+E kUR3lJXy1B9o/DHJuJp7pkdlok8RHWiukweYN9YR/MPvHmPL6t0Qb9WchBuA+kqZAiX0cbujifCLC kBcbhaGzIWrNVOmh8qb2zGs1TvnY5qP3m/105nOMB30rNyayyGbcZnGOxYRmIgRKPUkAOGMHA+EZE narXz5AFXJxFJ0mc/0LQX4WL0HmmQTmbODyz2cYjdaQmPkCnkGwUOPGQbpY4wqpmrS8yYkK8Cu6pb n6qdWbeRxMdumF1DS+UFeuVO20WaJxnln3aE0vd1rcWnC35kPiwln+iS14gEc7mshv+aMHzyMutAr 9TTNlBKfcB4OHmQDz7sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9BGt-009B8w-1C; Tue, 13 Jun 2023 21:09:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9BGn-009B76-2e; Tue, 13 Jun 2023 21:09:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 459FD63B01; Tue, 13 Jun 2023 21:09:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CA2C433C0; Tue, 13 Jun 2023 21:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686690580; bh=CnDPIeLogwBWCfXwDFCGYSnn6freMhcPiMKmnauZmK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZwHrH/UtQy5gtJuV6CZdRxLuHzTaAkiUGIx/JgEU65AMLsBIKZ0sWdlw1vTEQYgdy gSLYt19YIoeRBe5zYzLlgTuRTMMo3kgRmlRYZUwN9+y0DX2gj67q8Dp8pJtQUo0gHp Oy60KuQPQMSSexOGqUQrMmT3Fgb1GBewXzaMMxDEmcoyUN9bNnKzEk/bEsVagentbs IrjokONRoY0TE+yzqvQqq0avTQyKOfbb7gZycLtP7znx6sVR7tnvKBFHLqFKSVwEs2 kIA6GPsL9JTaWmKMWc1Wdyo1oerK/huG9zsVu6RfIYfLEAg8ULTJ9IL3DRtm5ddTXF JrMlJp241w1cA== Date: Wed, 14 Jun 2023 00:09:00 +0300 From: Mike Rapoport To: Kent Overstreet Cc: Song Liu , Mark Rutland , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 00/13] mm: jit/text allocator Message-ID: <20230613210900.GV52412@kernel.org> References: <20230601101257.530867-1-rppt@kernel.org> <20230605092040.GB3460@kernel.org> <20230608184116.GJ52412@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_140941_944508_B0DA2DC2 X-CRM114-Status: GOOD ( 29.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMTMsIDIwMjMgYXQgMDI6NTY6MTRQTSAtMDQwMCwgS2VudCBPdmVyc3RyZWV0 IHdyb3RlOgo+IE9uIFRodSwgSnVuIDA4LCAyMDIzIGF0IDA5OjQxOjE2UE0gKzAzMDAsIE1pa2Ug UmFwb3BvcnQgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1biAwNiwgMjAyMyBhdCAxMToyMTo1OUFNIC0w NzAwLCBTb25nIExpdSB3cm90ZToKPiA+ID4gT24gTW9uLCBKdW4gNSwgMjAyMyBhdCAzOjA54oCv QU0gTWFyayBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT4gd3JvdGU6Cj4gPiA+IAo+ID4g PiBbLi4uXQo+ID4gPiAKPiA+ID4gPiA+ID4gPiBDYW4geW91IGdpdmUgbW9yZSBkZXRhaWwgb24g d2hhdCBwYXJhbWV0ZXJzIHlvdSBuZWVkPyBJZiB0aGUgb25seSBleHRyYQo+ID4gPiA+ID4gPiA+ IHBhcmFtZXRlciBpcyBqdXN0ICJkb2VzIHRoaXMgYWxsb2NhdGlvbiBuZWVkIHRvIGxpdmUgY2xv c2UgdG8ga2VybmVsCj4gPiA+ID4gPiA+ID4gdGV4dCIsIHRoYXQncyBub3QgdGhhdCBiaWcgb2Yg YSBkZWFsLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBNeSB0aGlua2luZyB3YXMgdGhhdCB3ZSBh dCBsZWFzdCBuZWVkIHRoZSBzdGFydCArIGVuZCBmb3IgZWFjaCBjYWxsZXIuIFRoYXQKPiA+ID4g PiA+ID4gbWlnaHQgYmUgaXQsIHRiaC4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBEbyB5b3UgbWVhbiB0 aGF0IG1vZHVsZXMgd2lsbCBoYXZlIHNvbWV0aGluZyBsaWtlCj4gPiA+ID4gPgo+ID4gPiA+ID4g ICAgICAgaml0X3RleHRfYWxsb2Moc2l6ZSwgTU9EVUxFU19TVEFSVCwgTU9EVUxFU19FTkQpOwo+ ID4gPiA+ID4KPiA+ID4gPiA+IGFuZCBrcHJvYmVzIHdpbGwgaGF2ZQo+ID4gPiA+ID4KPiA+ID4g PiA+ICAgICAgIGppdF90ZXh0X2FsbG9jKHNpemUsIEtQUk9CRVNfU1RBUlQsIEtQUk9CRVNfRU5E KTsKPiA+ID4gPiA+ID8KPiA+ID4gPgo+ID4gPiA+IFllcy4KPiA+ID4gCj4gPiA+IEhvdyBhYm91 dCB3ZSBzdGFydCB3aXRoIHR3byBBUElzOgo+ID4gPiAgICAgIGppdF90ZXh0X2FsbG9jKHNpemUp Owo+ID4gPiAgICAgIGppdF90ZXh0X2FsbG9jX3JhbmdlKHNpemUsIHN0YXJ0LCBlbmQpOwo+ID4g PiAKPiA+ID4gQUZBSUNULCBhcm02NCBpcyB0aGUgb25seSBhcmNoIHRoYXQgcmVxdWlyZXMgdGhl IGxhdHRlciBBUEkuIEFuZCBUQkgsIEkgYW0KPiA+ID4gbm90IHF1aXRlIGNvbnZpbmNlZCBpdCBp cyBuZWVkZWQuCj4gPiAgCj4gPiBSaWdodCBub3cgYXJtNjQgYW5kIHJpc2N2IG92ZXJyaWRlIGJw ZiBhbmQga3Byb2JlcyBhbGxvY2F0aW9ucyB0byB1c2UgdGhlCj4gPiBlbnRpcmUgdm1hbGxvYyBh ZGRyZXNzIHNwYWNlLCBidXQgaGF2aW5nIHRoZSBhYmlsaXR5IHRvIGFsbG9jYXRlIGdlbmVyYXRl ZAo+ID4gY29kZSBvdXRzaWRlIG9mIG1vZHVsZXMgYXJlYSBtYXkgYmUgdXNlZnVsIGZvciBvdGhl ciBhcmNoaXRlY3R1cmVzLgo+ID4gCj4gPiBTdGlsbCB0aGUgc3RhcnQgKyBlbmQgZm9yIHRoZSBj YWxsZXJzIGZlZWxzIGJhY2t3YXJkcyB0byBtZSBiZWNhdXNlIHRoZQo+ID4gY2FsbGVycyBkbyBu b3QgZGVmaW5lIHRoZSByYW5nZXMsIGJ1dCByYXRoZXIgdGhlIGFyY2hpdGVjdHVyZXMsIHNvIHdl IHN0aWxsCj4gPiBuZWVkIGEgd2F5IGZvciBhcmNoaXRlY3R1cmVzIHRvIGRlZmluZSBob3cgdGhl eSB3YW50IGFsbG9jYXRlIG1lbW9yeSBmb3IKPiA+IHRoZSBnZW5lcmF0ZWQgY29kZS4KPiAKPiBT bywgdGhlIHN0YXJ0ICsgZW5kIGp1c3QgY29tZXMgZnJvbSB0aGUgbmVlZCB0byBrZWVwIHJlbGF0 aXZlIHBvaW50ZXJzCj4gdW5kZXIgYSBjZXJ0YWluIHNpemUuIEkgdGhpbmsgdGhpcyBjb3VsZCBi ZSBqdXN0IGEgZmxhZywgSSBzZWUgbm8gcmVhc29uCj4gdG8gZXhwb3NlIGFjdHVhbCBhZGRyZXNz ZXMgaGVyZS4KCkl0J3MgdGhlIG90aGVyIHdheSBhcm91bmQuIFRoZSBzdGFydCArIGVuZCBjb21l cyBmcm9tIHRoZSBuZWVkIHRvIHJlc3RyaWN0CmFsbG9jYXRpb24gdG8gY2VydGFpbiByYW5nZSBi ZWNhdXNlIG9mIHRoZSByZWxhdGl2ZSBhZGRyZXNzaW5nLiBJIGRvbid0IHNlZQpob3cgYSBmbGFn IGNhbiBoZWxwIGhlcmUuCgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBs aXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04BCFEB64D7 for ; Tue, 13 Jun 2023 21:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uvVAzpUecQJl4EdeC5gXLPOCgkjKkt3MsYg/bJG+CgQ=; b=n/LyVyPnET78vh xoLiWbUb02wsxnC7ZFI+zDQDGnaq4OPEl/DrYB3LJTAEAwm2lJatVmacggfCCFpTU6sfmjEHIiFbF iVOBdaEbcLRb8Jeu+73agB/zQNiVPReyBXnShQxk8eCObEMyDt24MKEeFATDNXgUo9EdNwcjSmWWl 1ASSl9Wc6O+W4OHw+54KmUXaBwCQozA/0u+Xx/lpV/ySwG6HqM3XOEpMh74jUqJd24HD6Mume6c8D 3Op7u+LCNinibNJuWlYgwjSr5lryXfu430nT9U4bVdzEutm08xMBdnhTZbIE46N5pSx1noRI0H00R AK7iohC9AHg0/b6j8e1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9BGs-009B8c-33; Tue, 13 Jun 2023 21:09:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9BGn-009B76-2e; Tue, 13 Jun 2023 21:09:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 459FD63B01; Tue, 13 Jun 2023 21:09:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CA2C433C0; Tue, 13 Jun 2023 21:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686690580; bh=CnDPIeLogwBWCfXwDFCGYSnn6freMhcPiMKmnauZmK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZwHrH/UtQy5gtJuV6CZdRxLuHzTaAkiUGIx/JgEU65AMLsBIKZ0sWdlw1vTEQYgdy gSLYt19YIoeRBe5zYzLlgTuRTMMo3kgRmlRYZUwN9+y0DX2gj67q8Dp8pJtQUo0gHp Oy60KuQPQMSSexOGqUQrMmT3Fgb1GBewXzaMMxDEmcoyUN9bNnKzEk/bEsVagentbs IrjokONRoY0TE+yzqvQqq0avTQyKOfbb7gZycLtP7znx6sVR7tnvKBFHLqFKSVwEs2 kIA6GPsL9JTaWmKMWc1Wdyo1oerK/huG9zsVu6RfIYfLEAg8ULTJ9IL3DRtm5ddTXF JrMlJp241w1cA== Date: Wed, 14 Jun 2023 00:09:00 +0300 From: Mike Rapoport To: Kent Overstreet Cc: Song Liu , Mark Rutland , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 00/13] mm: jit/text allocator Message-ID: <20230613210900.GV52412@kernel.org> References: <20230601101257.530867-1-rppt@kernel.org> <20230605092040.GB3460@kernel.org> <20230608184116.GJ52412@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_140941_944508_B0DA2DC2 X-CRM114-Status: GOOD ( 29.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMTMsIDIwMjMgYXQgMDI6NTY6MTRQTSAtMDQwMCwgS2VudCBPdmVyc3RyZWV0 IHdyb3RlOgo+IE9uIFRodSwgSnVuIDA4LCAyMDIzIGF0IDA5OjQxOjE2UE0gKzAzMDAsIE1pa2Ug UmFwb3BvcnQgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1biAwNiwgMjAyMyBhdCAxMToyMTo1OUFNIC0w NzAwLCBTb25nIExpdSB3cm90ZToKPiA+ID4gT24gTW9uLCBKdW4gNSwgMjAyMyBhdCAzOjA54oCv QU0gTWFyayBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT4gd3JvdGU6Cj4gPiA+IAo+ID4g PiBbLi4uXQo+ID4gPiAKPiA+ID4gPiA+ID4gPiBDYW4geW91IGdpdmUgbW9yZSBkZXRhaWwgb24g d2hhdCBwYXJhbWV0ZXJzIHlvdSBuZWVkPyBJZiB0aGUgb25seSBleHRyYQo+ID4gPiA+ID4gPiA+ IHBhcmFtZXRlciBpcyBqdXN0ICJkb2VzIHRoaXMgYWxsb2NhdGlvbiBuZWVkIHRvIGxpdmUgY2xv c2UgdG8ga2VybmVsCj4gPiA+ID4gPiA+ID4gdGV4dCIsIHRoYXQncyBub3QgdGhhdCBiaWcgb2Yg YSBkZWFsLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBNeSB0aGlua2luZyB3YXMgdGhhdCB3ZSBh dCBsZWFzdCBuZWVkIHRoZSBzdGFydCArIGVuZCBmb3IgZWFjaCBjYWxsZXIuIFRoYXQKPiA+ID4g PiA+ID4gbWlnaHQgYmUgaXQsIHRiaC4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBEbyB5b3UgbWVhbiB0 aGF0IG1vZHVsZXMgd2lsbCBoYXZlIHNvbWV0aGluZyBsaWtlCj4gPiA+ID4gPgo+ID4gPiA+ID4g ICAgICAgaml0X3RleHRfYWxsb2Moc2l6ZSwgTU9EVUxFU19TVEFSVCwgTU9EVUxFU19FTkQpOwo+ ID4gPiA+ID4KPiA+ID4gPiA+IGFuZCBrcHJvYmVzIHdpbGwgaGF2ZQo+ID4gPiA+ID4KPiA+ID4g PiA+ICAgICAgIGppdF90ZXh0X2FsbG9jKHNpemUsIEtQUk9CRVNfU1RBUlQsIEtQUk9CRVNfRU5E KTsKPiA+ID4gPiA+ID8KPiA+ID4gPgo+ID4gPiA+IFllcy4KPiA+ID4gCj4gPiA+IEhvdyBhYm91 dCB3ZSBzdGFydCB3aXRoIHR3byBBUElzOgo+ID4gPiAgICAgIGppdF90ZXh0X2FsbG9jKHNpemUp Owo+ID4gPiAgICAgIGppdF90ZXh0X2FsbG9jX3JhbmdlKHNpemUsIHN0YXJ0LCBlbmQpOwo+ID4g PiAKPiA+ID4gQUZBSUNULCBhcm02NCBpcyB0aGUgb25seSBhcmNoIHRoYXQgcmVxdWlyZXMgdGhl IGxhdHRlciBBUEkuIEFuZCBUQkgsIEkgYW0KPiA+ID4gbm90IHF1aXRlIGNvbnZpbmNlZCBpdCBp cyBuZWVkZWQuCj4gPiAgCj4gPiBSaWdodCBub3cgYXJtNjQgYW5kIHJpc2N2IG92ZXJyaWRlIGJw ZiBhbmQga3Byb2JlcyBhbGxvY2F0aW9ucyB0byB1c2UgdGhlCj4gPiBlbnRpcmUgdm1hbGxvYyBh ZGRyZXNzIHNwYWNlLCBidXQgaGF2aW5nIHRoZSBhYmlsaXR5IHRvIGFsbG9jYXRlIGdlbmVyYXRl ZAo+ID4gY29kZSBvdXRzaWRlIG9mIG1vZHVsZXMgYXJlYSBtYXkgYmUgdXNlZnVsIGZvciBvdGhl ciBhcmNoaXRlY3R1cmVzLgo+ID4gCj4gPiBTdGlsbCB0aGUgc3RhcnQgKyBlbmQgZm9yIHRoZSBj YWxsZXJzIGZlZWxzIGJhY2t3YXJkcyB0byBtZSBiZWNhdXNlIHRoZQo+ID4gY2FsbGVycyBkbyBu b3QgZGVmaW5lIHRoZSByYW5nZXMsIGJ1dCByYXRoZXIgdGhlIGFyY2hpdGVjdHVyZXMsIHNvIHdl IHN0aWxsCj4gPiBuZWVkIGEgd2F5IGZvciBhcmNoaXRlY3R1cmVzIHRvIGRlZmluZSBob3cgdGhl eSB3YW50IGFsbG9jYXRlIG1lbW9yeSBmb3IKPiA+IHRoZSBnZW5lcmF0ZWQgY29kZS4KPiAKPiBT bywgdGhlIHN0YXJ0ICsgZW5kIGp1c3QgY29tZXMgZnJvbSB0aGUgbmVlZCB0byBrZWVwIHJlbGF0 aXZlIHBvaW50ZXJzCj4gdW5kZXIgYSBjZXJ0YWluIHNpemUuIEkgdGhpbmsgdGhpcyBjb3VsZCBi ZSBqdXN0IGEgZmxhZywgSSBzZWUgbm8gcmVhc29uCj4gdG8gZXhwb3NlIGFjdHVhbCBhZGRyZXNz ZXMgaGVyZS4KCkl0J3MgdGhlIG90aGVyIHdheSBhcm91bmQuIFRoZSBzdGFydCArIGVuZCBjb21l cyBmcm9tIHRoZSBuZWVkIHRvIHJlc3RyaWN0CmFsbG9jYXRpb24gdG8gY2VydGFpbiByYW5nZSBi ZWNhdXNlIG9mIHRoZSByZWxhdGl2ZSBhZGRyZXNzaW5nLiBJIGRvbid0IHNlZQpob3cgYSBmbGFn IGNhbiBoZWxwIGhlcmUuCgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74FE8EB64D7 for ; Tue, 13 Jun 2023 21:10:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZwHrH/Ut; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qgh6T5RFBz30hw for ; Wed, 14 Jun 2023 07:10:41 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZwHrH/Ut; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Qgh5P6XPhz2xpl for ; Wed, 14 Jun 2023 07:09:45 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 459FD63B01; Tue, 13 Jun 2023 21:09:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CA2C433C0; Tue, 13 Jun 2023 21:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686690580; bh=CnDPIeLogwBWCfXwDFCGYSnn6freMhcPiMKmnauZmK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZwHrH/UtQy5gtJuV6CZdRxLuHzTaAkiUGIx/JgEU65AMLsBIKZ0sWdlw1vTEQYgdy gSLYt19YIoeRBe5zYzLlgTuRTMMo3kgRmlRYZUwN9+y0DX2gj67q8Dp8pJtQUo0gHp Oy60KuQPQMSSexOGqUQrMmT3Fgb1GBewXzaMMxDEmcoyUN9bNnKzEk/bEsVagentbs IrjokONRoY0TE+yzqvQqq0avTQyKOfbb7gZycLtP7znx6sVR7tnvKBFHLqFKSVwEs2 kIA6GPsL9JTaWmKMWc1Wdyo1oerK/huG9zsVu6RfIYfLEAg8ULTJ9IL3DRtm5ddTXF JrMlJp241w1cA== Date: Wed, 14 Jun 2023 00:09:00 +0300 From: Mike Rapoport To: Kent Overstreet Subject: Re: [PATCH 00/13] mm: jit/text allocator Message-ID: <20230613210900.GV52412@kernel.org> References: <20230601101257.530867-1-rppt@kernel.org> <20230605092040.GB3460@kernel.org> <20230608184116.GJ52412@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , x86@kernel.org, Catalin Marinas , linux-mips@vger.kernel.org, Song Liu , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Russell King , "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , Andrew Morton , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dinh Nguyen , Luis Chamberlain , Palmer Dabbelt , bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 13, 2023 at 02:56:14PM -0400, Kent Overstreet wrote: > On Thu, Jun 08, 2023 at 09:41:16PM +0300, Mike Rapoport wrote: > > On Tue, Jun 06, 2023 at 11:21:59AM -0700, Song Liu wrote: > > > On Mon, Jun 5, 2023 at 3:09 AM Mark Rutland wrote: > > > > > > [...] > > > > > > > > > > Can you give more detail on what parameters you need? If the only extra > > > > > > > parameter is just "does this allocation need to live close to kernel > > > > > > > text", that's not that big of a deal. > > > > > > > > > > > > My thinking was that we at least need the start + end for each caller. That > > > > > > might be it, tbh. > > > > > > > > > > Do you mean that modules will have something like > > > > > > > > > > jit_text_alloc(size, MODULES_START, MODULES_END); > > > > > > > > > > and kprobes will have > > > > > > > > > > jit_text_alloc(size, KPROBES_START, KPROBES_END); > > > > > ? > > > > > > > > Yes. > > > > > > How about we start with two APIs: > > > jit_text_alloc(size); > > > jit_text_alloc_range(size, start, end); > > > > > > AFAICT, arm64 is the only arch that requires the latter API. And TBH, I am > > > not quite convinced it is needed. > > > > Right now arm64 and riscv override bpf and kprobes allocations to use the > > entire vmalloc address space, but having the ability to allocate generated > > code outside of modules area may be useful for other architectures. > > > > Still the start + end for the callers feels backwards to me because the > > callers do not define the ranges, but rather the architectures, so we still > > need a way for architectures to define how they want allocate memory for > > the generated code. > > So, the start + end just comes from the need to keep relative pointers > under a certain size. I think this could be just a flag, I see no reason > to expose actual addresses here. It's the other way around. The start + end comes from the need to restrict allocation to certain range because of the relative addressing. I don't see how a flag can help here. -- Sincerely yours, Mike.