All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Ghiti <alexghiti@rivosinc.com>
To: Ard Biesheuvel <ardb@kernel.org>,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [RFC PATCH 0/1] zboot: Garbage collect unused functions
Date: Wed, 21 Jun 2023 13:44:38 +0200	[thread overview]
Message-ID: <20230621114439.42851-1-alexghiti@rivosinc.com> (raw)

This patch is meant to solve the issue reported by lkp in [1] with the KASLR
series support for RISC-V.

The problem in [1] is caused by the addition of new functions in
efi-stub-helper.c which reference symbols that are not defined in the context
of zboot. Those functions are not used in zboot but it causes those link
errors.

I can move those new functions around so that the problem disappears, but I
believe that fixing that using the linker garbage collection is more sane.

That's an RFC, I'll include it in my KASLR series if that's the right
direction.

[1] https://lore.kernel.org/oe-kbuild-all/202306080741.ArdxyO6n-lkp@intel.com/

Alexandre Ghiti (1):
  libstub: zboot: Use -ffunction-sections + --gc-sections

 drivers/firmware/efi/libstub/Makefile       | 1 +
 drivers/firmware/efi/libstub/Makefile.zboot | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.39.2


             reply	other threads:[~2023-06-21 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 11:44 Alexandre Ghiti [this message]
2023-06-21 11:44 ` [RFC PATCH 1/1] libstub: zboot: Use -ffunction-sections + --gc-sections Alexandre Ghiti
2023-07-07  8:44   ` Alexandre Ghiti
2023-07-07  8:47     ` Ard Biesheuvel
2023-07-07  9:06       ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621114439.42851-1-alexghiti@rivosinc.com \
    --to=alexghiti@rivosinc.com \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.