From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1C31C38 for ; Sat, 24 Jun 2023 12:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687610405; x=1719146405; h=date:from:to:cc:subject:message-id:mime-version; bh=1eZCC1umqee8JFPlJaoyY7eFR7IL50ZdcYNSpvR4BfI=; b=Ci7KMQZnRXTh5rKulwKg9EhwzJuWmkOyrKxssmsst6jniFbxNEorTiz0 V7lqRK4oUavoiZmBVzqc7kfzPqXjmqH/JT8j1BU8si98o7AEDg8Cwp+LJ 4VKOjz+V5mmPr4yX90c5HjTaqpue8v+JUg9D9OThBaTCK14dP7f+wBv7w Gkxfd9mVaOI3ZYkgkeK2Xmq9tnuYyvWmyxw/BET8kwm45vFw8qnYWURgw KCx8uiWMbkvwTU1niiCBfEkGrh0obeyATdTJmXmWxPJpcVh/f4GSIPTcw SwPSJF1K7mxlHPWeGR9xrBgi4EVUL/7hUcxg1AEj2FpT0X1v57y9gXwDU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10750"; a="364386885" X-IronPort-AV: E=Sophos;i="6.01,155,1684825200"; d="scan'208";a="364386885" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2023 05:40:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10750"; a="828674485" X-IronPort-AV: E=Sophos;i="6.01,155,1684825200"; d="scan'208";a="828674485" Received: from lkp-server01.sh.intel.com (HELO 783282924a45) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 24 Jun 2023 05:40:02 -0700 Received: from kbuild by 783282924a45 with local (Exim 4.96) (envelope-from ) id 1qD2Yc-00092n-0J; Sat, 24 Jun 2023 12:40:02 +0000 Date: Sat, 24 Jun 2023 20:39:46 +0800 From: kernel test robot To: Luciano Coelho , Golan Ben Ami , Michael Golant , Johannes Berg Cc: oe-kbuild-all@lists.linux.dev Subject: drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure) Message-ID: <202306242057.clLr1Ln1-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Chris, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/chromeos.git chromeos-5.10__release/core60-51 head: 79f190d7ae78b399a873f6814484a1854cb4ba31 commit: c8d6b6fd606bc9604d16db5f59563a435cc335c7 FROMGIT: drm/i915/gt: Rename lrc.c to execlists_submission.c date: 2 years, 4 months ago config: x86_64-buildonly-randconfig-r003-20230624 (https://download.01.org/0day-ci/archive/20230624/202306242057.clLr1Ln1-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230624/202306242057.clLr1Ln1-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306242057.clLr1Ln1-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6130: >> drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6130: drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("lo spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6130: drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("hi spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ 3 errors generated. vim +167 drivers/gpu/drm/i915/gt/selftest_execlists.c 280e285dc78f73 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2020-02-27 134 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 135 static int live_sanitycheck(void *arg) 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 136 { 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 137 struct intel_gt *gt = arg; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 138 struct intel_engine_cs *engine; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 139 enum intel_engine_id id; 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 140 struct igt_spinner spin; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 141 int err = 0; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 142 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 143 if (!HAS_LOGICAL_RING_CONTEXTS(gt->i915)) 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 144 return 0; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 145 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 146 if (igt_spinner_init(&spin, gt)) 2af402982ab382 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-04 147 return -ENOMEM; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 148 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 149 for_each_engine(engine, gt, id) { e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 150 struct intel_context *ce; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 151 struct i915_request *rq; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 152 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 153 ce = intel_context_create(engine); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 154 if (IS_ERR(ce)) { e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 155 err = PTR_ERR(ce); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 156 break; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 157 } e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 158 f277bc0c98a407 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-07-31 159 rq = igt_spinner_create_request(&spin, ce, MI_NOOP); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 160 if (IS_ERR(rq)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 161 err = PTR_ERR(rq); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 162 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 163 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 164 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 165 i915_request_add(rq); 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 166 if (!igt_wait_for_spinner(&spin, rq)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 @167 GEM_TRACE("spinner failed to start\n"); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 168 GEM_TRACE_DUMP(); 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 169 intel_gt_set_wedged(gt); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 170 err = -EIO; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 171 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 172 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 173 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 174 igt_spinner_end(&spin); 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 175 if (igt_flush_test(gt->i915)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 176 err = -EIO; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 177 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 178 } e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 179 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 180 out_ctx: e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 181 intel_context_put(ce); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 182 if (err) e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 183 break; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 184 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 185 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 186 igt_spinner_fini(&spin); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 187 return err; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 188 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 189 :::::: The code at line 167 was first introduced by commit :::::: 2c66555ec19235efd689741c44bbeb893aa8e7de drm/i915/selftests: Add basic sanitychecks for execlists :::::: TO: Chris Wilson :::::: CC: Chris Wilson -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki