From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFCBEB64DA for ; Tue, 27 Jun 2023 02:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbjF0Cdr (ORCPT ); Mon, 26 Jun 2023 22:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjF0Cdo (ORCPT ); Mon, 26 Jun 2023 22:33:44 -0400 Received: from out-34.mta1.migadu.com (out-34.mta1.migadu.com [95.215.58.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E91519A2 for ; Mon, 26 Jun 2023 19:33:43 -0700 (PDT) Date: Mon, 26 Jun 2023 22:33:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687833221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=38qafIfwmej2yIV1ZeFe4J/KUFbio8gHNCs5CXunBVc=; b=NSs/CdCJGB5SpYsfV+H44QeRwHi2yIisRly7GRzJvDcW+4keYpPOHE3G2O1i7rl0EJuUQL oePr6bXLyCH7dcUbPXg6L8qFk+3grgsfdQMHGp7MeJf0SupJHlB6zVKEBS4hScZRtthnWq NzLTaicV8FLEbJR5v/Iri4EFKI7kM/k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jens Axboe Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Christoph Hellwig Subject: Re: [GIT PULL] bcachefs Message-ID: <20230627023337.dordpfdxaad56hdn@moria.home.lan> References: <20230626214656.hcp4puionmtoloat@moria.home.lan> <20230627000635.43azxbkd2uf3tu6b@moria.home.lan> <91e9064b-84e3-1712-0395-b017c7c4a964@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91e9064b-84e3-1712-0395-b017c7c4a964@kernel.dk> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2023 at 07:13:54PM -0600, Jens Axboe wrote: > fs/bcachefs/alloc_background.c: In function ‘bch2_check_alloc_info’: > fs/bcachefs/alloc_background.c:1526:1: warning: the frame size of 2640 bytes is larger than 2048 bytes [-Wframe-larger-than=] > 1526 | } > | ^ > fs/bcachefs/reflink.c: In function ‘bch2_remap_range’: > fs/bcachefs/reflink.c:388:1: warning: the frame size of 2352 bytes is larger than 2048 bytes [-Wframe-larger-than=] > 388 | } > | ^ What version of gcc are you using? I'm not seeing either of those warnings - I'm wondering if gcc recently got better about stack usage when inlining. also not seeing any reason why bch2_remap_range's stack frame should be that big, to my eye it looks like it should be more like 1k, so if anyone knows some magic for seeing stack frame layout that would be handy... anyways, there's a patch in my testing branch that should fix bch2_check_alloc_info