From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5515EB64D7 for ; Fri, 30 Jun 2023 18:16:00 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0841410FC; Fri, 30 Jun 2023 20:15:59 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 2F0BB40EDB for ; Fri, 30 Jun 2023 20:15:59 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-666eba6f3d6so1248398b3a.3 for ; Fri, 30 Jun 2023 11:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688148958; x=1690740958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/V7/JLkg4UE68YiKET9KhQW6qASVJK4kc25fGMtI8GA=; b=KtRptbb4ZMVoGt5R8AVexz6fdj3rJ5aNInI0wHZ5Il6ReOWXtioVHmo32lex7p5eK/ oKsZi+4CgJZkACIcRlIE96bhMB6FIVaNvFeuF76Dr6Dpmaj5KggyhL6bbBhltnPmYmyB 5ur9ikuhtK16Zyb1cTdvElgm7wA4qjN60abbuS9ICU5PQ9srHNiZ7fNRgHu51GElYNta +QXpjRfeO2r4Q3TPQrjtz5K0eaEQJOEgXZqp8IHmVbpE8sLUP0jQrSDzowT9L4TrglIP k9HX0JKcfOqGJuhZdQPrhY4RugC6t6J8pE6gydyfiyUlMH6UuhApI5Ue8I8aRASjyrKd 6+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688148958; x=1690740958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/V7/JLkg4UE68YiKET9KhQW6qASVJK4kc25fGMtI8GA=; b=Y1/dCKetv6TrfJbEMpgyZYE4JX94xDNoR7Xh4VSDyhy4hlpf2RjN3wnmRQ98x9z5TU IzlOEki4oWBuGZKPL0hsErIKjO0hN5F9kSh2BHuj8CTmcv84uJ4zFvFJzWbRc6O0/cok lMioPvzbAdh9plZhvV9SrpeEIL0tENKIV5NDsXUNlyeUnpIo9PtHJHhkXyrCZBn3/urw LNb5PEAJzttIksIOpO2DOcTFWNHBtNN/RugquYmP96TZGDH+V2V9JpjBw+0TIMGAVU2i CIGHIbNjWdHfiNM5bbOqJF6mC/6vCG331oulP0tL83AEQ7mTDZb0IyNkaid5qGaday1b RYWw== X-Gm-Message-State: ABy/qLagXPs6rTVVn6rZ7y2swtsrwbKPF4oXgCiAXNYlrd7u6Rhm0WZJ gPmcnW4gD//KZUgOgOjldwKJ1Q== X-Google-Smtp-Source: APBJJlEY5GcVPXxOjnvfLFKZndmy8kIpQccMCy7qRO94mpo122CY/Km5EZBTFYz3yc7b5g+agilIAg== X-Received: by 2002:a05:6a00:218a:b0:653:b76d:4d62 with SMTP id h10-20020a056a00218a00b00653b76d4d62mr3931048pfi.24.1688148958271; Fri, 30 Jun 2023 11:15:58 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id r21-20020a62e415000000b00676a3041d6esm8661419pfh.92.2023.06.30.11.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 11:15:58 -0700 (PDT) Date: Fri, 30 Jun 2023 11:15:56 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" , jerinj@marvell.com Cc: , , , , , , , , , Subject: Re: [dpdk-dev] [PATCH 07/10] examples/l3fwd: add function return value check Message-ID: <20230630111556.7a43a9cc@hermes.local> In-Reply-To: <1618839289-33224-8-git-send-email-humin29@huawei.com> References: <1618839289-33224-1-git-send-email-humin29@huawei.com> <1618839289-33224-8-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 19 Apr 2021 21:34:46 +0800 "Min Hu (Connor)" wrote: > From: HongBo Zheng > > Return value of a function 'rte_eth_macaddr_get' called at > l3fwd_eth_dev_port_setup is not checked, but it is usually > checked for this function. > > This patch fix this problem. > > Fixes: a65bf3d724df ("examples/l3fwd: add ethdev setup based on eventdev") > Cc: stable@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) This looks correct, but only a buggy driver would never set macaddr. Acked-by: Stephen Hemminger