All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration
Date: Mon, 3 Jul 2023 16:19:09 -0700	[thread overview]
Message-ID: <20230703161909.23a7da1d@hermes.local> (raw)
In-Reply-To: <1619599379-470-1-git-send-email-humin29@huawei.com>

On Wed, 28 Apr 2021 16:42:59 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:

> From: Huisong Li <lihuisong@huawei.com>
> 
> Currently, the pause command in ethtool to enable Rx/Tx pause has the
> following problem. Namely, Assume that the device supports flow control
> auto-negotiation to set pause parameters, which will the device that does
> not support flow control auto-negotiation fails to run this command.
> 
> This patch supports the configuration of flow control auto-negotiation
> and fixes the print format and style of the pause cmd to make it more
> readable.
> 
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Overall, this looks good.
DPDK is mainly used in devices 1G and above where I think that
auto negotiation is required by IEEE spec.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

  parent reply	other threads:[~2023-07-03 23:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:42 [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration Min Hu (Connor)
2021-06-28  2:17 ` Min Hu (Connor)
2021-07-17  2:15   ` Min Hu (Connor)
2021-09-28  1:20     ` Min Hu (Connor)
2023-07-03 23:19 ` Stephen Hemminger [this message]
2023-11-10  3:30 ` [PATCH v2] " Huisong Li
2023-11-22 22:50   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703161909.23a7da1d@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.