From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2A9C001B0 for ; Wed, 5 Jul 2023 17:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232573AbjGERk7 (ORCPT ); Wed, 5 Jul 2023 13:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231688AbjGERk5 (ORCPT ); Wed, 5 Jul 2023 13:40:57 -0400 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [46.30.211.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F09419B for ; Wed, 5 Jul 2023 10:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=F5wP4GaD2OeQcLZCchJTXLTRkr0vmE7y7CKsxYuClzsRDNJ+3yyY7cEprDx7f/FhtN8Z33tJsusRX mVakIqrhR1bEcfPpxboAERlKmb+NSF0ARG+NFKBxjvALdajSBXT1WlcaT2vGeq2CGlSonASxqHZrnm KzmQw1g6dN3QSzKHYudGwh1LIgVmJ53dQAWtGDDyQ1QcEVCZQkOm0Rdy+bUVn7PRVrW4xQpGWCVwlQ YSoWRXNNvAjnYgnE5qYBRcB+piSPngd0oBGvijCU4i+UpH4eHsZY2EmcnHVtW9aSOYM2PU6hqFBJG+ 9JIGfzE8uVI7USi5+cVtXYGUdCffx8A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=Do9skGeypNLVI7zeveYEQqKi0JsTReyLIbwKr68clQyyQMJ3aNfdzB7vvRM2FtMtLRQ9Oo10dibXO VHe/CPDAQ== X-HalOne-ID: f076bdb9-1b5a-11ee-97e5-592bb1efe9dc Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id f076bdb9-1b5a-11ee-97e5-592bb1efe9dc; Wed, 05 Jul 2023 17:39:50 +0000 (UTC) Date: Wed, 5 Jul 2023 19:39:49 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: neil.armstrong@linaro.org, Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Message-ID: <20230705173949.GA106478@ravnborg.org> References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> <194ac047-b20e-04c1-1d96-67cc483bb4a1@linaro.org> <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Wed, Jul 05, 2023 at 04:38:05PM +0200, Paul Cercueil wrote: > Hi Neil, > > Le mercredi 05 juillet 2023 à 15:57 +0200, Neil Armstrong a écrit : > > On 03/07/2023 23:47, Paul Cercueil wrote: > > > Register a backlight device to be able to switch between all the > > > gamma > > > levels. > > > > > > Signed-off-by: Paul Cercueil > > > --- > > >   drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 > > > ++++++++++++++++++++ > > >   1 file changed, 40 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > index 7fd9444b42c5..b4f87d6244cb 100644 > > > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > @@ -8,6 +8,7 @@ > > >    * Andrzej Hajda > > >   */ > > >   > > > +#include > > >   #include > > >   #include > > >   #include > > > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > > >         return 0; > > >   } > > >   > > > +static int ld9040_bl_update_status(struct backlight_device *dev) > > > +{ > > > +       struct ld9040 *ctx = dev_get_drvdata(&dev->dev); > > > + > > > +       ctx->brightness = dev->props.brightness; Use backlight_get_brightness(dev); > > > +       ld9040_brightness_set(ctx); > > > + > > > +       return 0; > > > +} > > > + > > > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > > > +{ > > > +       if (dev->props.fb_blank == FB_BLANK_UNBLANK && > > > +                       dev->props.power == FB_BLANK_UNBLANK) > > > +               return dev->props.brightness; > > > + > > > +       return 0; > > > +} > > > > You can totally drop the _get_brightness. > > The current behaviour is to return 0 when the framebuffer is blanked. A > few drivers do that so I thought it was the norm; and the backlight > core doesn't do that by default (and just uses dev->props.brightness). > > It is not clear to me if that's the preferred behaviour. The > "backlight_get_brightness" function in backlight.h seems to suggest > that the current behaviour is correct, unless it is not supposed to be > used in the backlight_ops.get_brightness() callback. Then in that case > some other drivers get it wrong too. Several drivers get it wrong. You are supposed to provide get_brightness only when you read back a value from the HW, which is not the case here so just drop it is the right choice. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBE59EB64DA for ; Wed, 5 Jul 2023 17:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=85gxnaM7kUn713IwgA5fdrClJQNvptZCDTdgWAtrEZw=; b=BwiPI9Ot6/GqLt 3ud1h5liv7SkKbOMQ7TxX2VlmkfdW+NFPtMWAugUoqpXp8U8VGS30HZQLY9/dss3yHnzxnAnI/Thp nHUGS+HzPCg0paeq+wJCgNhnZESp3vMVnv3YJcp/zg1L+S2JYT0/TpVzLG0bhRuRzwDvnGYu3O6Pp eKs5Kh0k1E6MnEr5mqLclcwi61Puv5siZr1kf+ASuo4AHv1GggXnax6hzhX9dQod4IQc5wWwUr5Sh Z/u+WBg+oYDJ/ovLougeEtRc5weSrLcktPEK/lA9d8XCbJSs4IFmpnkB2Gz/ZCQltWFomTq1rn3gS n+TwvUSpXZD7ls2YO2sQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qH6U3-00Ge1u-0o; Wed, 05 Jul 2023 17:40:07 +0000 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:403::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qH6Ty-00GdzQ-0k for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 17:40:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=F5wP4GaD2OeQcLZCchJTXLTRkr0vmE7y7CKsxYuClzsRDNJ+3yyY7cEprDx7f/FhtN8Z33tJsusRX mVakIqrhR1bEcfPpxboAERlKmb+NSF0ARG+NFKBxjvALdajSBXT1WlcaT2vGeq2CGlSonASxqHZrnm KzmQw1g6dN3QSzKHYudGwh1LIgVmJ53dQAWtGDDyQ1QcEVCZQkOm0Rdy+bUVn7PRVrW4xQpGWCVwlQ YSoWRXNNvAjnYgnE5qYBRcB+piSPngd0oBGvijCU4i+UpH4eHsZY2EmcnHVtW9aSOYM2PU6hqFBJG+ 9JIGfzE8uVI7USi5+cVtXYGUdCffx8A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=Do9skGeypNLVI7zeveYEQqKi0JsTReyLIbwKr68clQyyQMJ3aNfdzB7vvRM2FtMtLRQ9Oo10dibXO VHe/CPDAQ== X-HalOne-ID: f076bdb9-1b5a-11ee-97e5-592bb1efe9dc Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id f076bdb9-1b5a-11ee-97e5-592bb1efe9dc; Wed, 05 Jul 2023 17:39:50 +0000 (UTC) Date: Wed, 5 Jul 2023 19:39:49 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: neil.armstrong@linaro.org, Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Message-ID: <20230705173949.GA106478@ravnborg.org> References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> <194ac047-b20e-04c1-1d96-67cc483bb4a1@linaro.org> <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_104004_038243_E37D7872 X-CRM114-Status: GOOD ( 29.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Wed, Jul 05, 2023 at 04:38:05PM +0200, Paul Cercueil wrote: > Hi Neil, > = > Le mercredi 05 juillet 2023 =E0 15:57 +0200, Neil Armstrong a =E9crit=A0: > > On 03/07/2023 23:47, Paul Cercueil wrote: > > > Register a backlight device to be able to switch between all the > > > gamma > > > levels. > > > = > > > Signed-off-by: Paul Cercueil > > > --- > > > =A0 drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 > > > ++++++++++++++++++++ > > > =A0 1 file changed, 40 insertions(+) > > > = > > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > index 7fd9444b42c5..b4f87d6244cb 100644 > > > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > @@ -8,6 +8,7 @@ > > > =A0=A0 * Andrzej Hajda > > > =A0 */ > > > =A0 = > > > +#include > > > =A0 #include > > > =A0 #include > > > =A0 #include > > > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > > > =A0=A0=A0=A0=A0=A0=A0=A0return 0; > > > =A0 } > > > =A0 = > > > +static int ld9040_bl_update_status(struct backlight_device *dev) > > > +{ > > > +=A0=A0=A0=A0=A0=A0=A0struct ld9040 *ctx =3D dev_get_drvdata(&dev->de= v); > > > + > > > +=A0=A0=A0=A0=A0=A0=A0ctx->brightness =3D dev->props.brightness; Use backlight_get_brightness(dev); > > > +=A0=A0=A0=A0=A0=A0=A0ld9040_brightness_set(ctx); > > > + > > > +=A0=A0=A0=A0=A0=A0=A0return 0; > > > +} > > > + > > > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > > > +{ > > > +=A0=A0=A0=A0=A0=A0=A0if (dev->props.fb_blank =3D=3D FB_BLANK_UNBLANK= && > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0dev->props.power =3D=3D FB_BLANK_UNBLANK) > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return dev->props.brigh= tness; > > > + > > > +=A0=A0=A0=A0=A0=A0=A0return 0; > > > +} > > = > > You can totally drop the _get_brightness. > = > The current behaviour is to return 0 when the framebuffer is blanked. A > few drivers do that so I thought it was the norm; and the backlight > core doesn't do that by default (and just uses dev->props.brightness). > = > It is not clear to me if that's the preferred behaviour. The > "backlight_get_brightness" function in backlight.h seems to suggest > that the current behaviour is correct, unless it is not supposed to be > used in the backlight_ops.get_brightness() callback. Then in that case > some other drivers get it wrong too. Several drivers get it wrong. You are supposed to provide get_brightness only when you read back a value from the HW, which is not the case here so just drop it is the right choice. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86657EB64DD for ; Wed, 5 Jul 2023 17:41:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE2B410E3A0; Wed, 5 Jul 2023 17:41:01 +0000 (UTC) Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [46.30.211.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CD6910E185 for ; Wed, 5 Jul 2023 17:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=F5wP4GaD2OeQcLZCchJTXLTRkr0vmE7y7CKsxYuClzsRDNJ+3yyY7cEprDx7f/FhtN8Z33tJsusRX mVakIqrhR1bEcfPpxboAERlKmb+NSF0ARG+NFKBxjvALdajSBXT1WlcaT2vGeq2CGlSonASxqHZrnm KzmQw1g6dN3QSzKHYudGwh1LIgVmJ53dQAWtGDDyQ1QcEVCZQkOm0Rdy+bUVn7PRVrW4xQpGWCVwlQ YSoWRXNNvAjnYgnE5qYBRcB+piSPngd0oBGvijCU4i+UpH4eHsZY2EmcnHVtW9aSOYM2PU6hqFBJG+ 9JIGfzE8uVI7USi5+cVtXYGUdCffx8A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=uX1KxxDBhiVzU9ji2kzcp/Y9e3VFw+X4GIkq8uU2bbU=; b=Do9skGeypNLVI7zeveYEQqKi0JsTReyLIbwKr68clQyyQMJ3aNfdzB7vvRM2FtMtLRQ9Oo10dibXO VHe/CPDAQ== X-HalOne-ID: f076bdb9-1b5a-11ee-97e5-592bb1efe9dc Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id f076bdb9-1b5a-11ee-97e5-592bb1efe9dc; Wed, 05 Jul 2023 17:39:50 +0000 (UTC) Date: Wed, 5 Jul 2023 19:39:49 +0200 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Message-ID: <20230705173949.GA106478@ravnborg.org> References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> <194ac047-b20e-04c1-1d96-67cc483bb4a1@linaro.org> <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e81dd5d9f62139e740ea123aa2087cb1bbcb04b.camel@crapouillou.net> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: neil.armstrong@linaro.org, Conor Dooley , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Alim Akhtar , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul, On Wed, Jul 05, 2023 at 04:38:05PM +0200, Paul Cercueil wrote: > Hi Neil, > > Le mercredi 05 juillet 2023 à 15:57 +0200, Neil Armstrong a écrit : > > On 03/07/2023 23:47, Paul Cercueil wrote: > > > Register a backlight device to be able to switch between all the > > > gamma > > > levels. > > > > > > Signed-off-by: Paul Cercueil > > > --- > > >   drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 > > > ++++++++++++++++++++ > > >   1 file changed, 40 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > index 7fd9444b42c5..b4f87d6244cb 100644 > > > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > > > @@ -8,6 +8,7 @@ > > >    * Andrzej Hajda > > >   */ > > >   > > > +#include > > >   #include > > >   #include > > >   #include > > > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > > >         return 0; > > >   } > > >   > > > +static int ld9040_bl_update_status(struct backlight_device *dev) > > > +{ > > > +       struct ld9040 *ctx = dev_get_drvdata(&dev->dev); > > > + > > > +       ctx->brightness = dev->props.brightness; Use backlight_get_brightness(dev); > > > +       ld9040_brightness_set(ctx); > > > + > > > +       return 0; > > > +} > > > + > > > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > > > +{ > > > +       if (dev->props.fb_blank == FB_BLANK_UNBLANK && > > > +                       dev->props.power == FB_BLANK_UNBLANK) > > > +               return dev->props.brightness; > > > + > > > +       return 0; > > > +} > > > > You can totally drop the _get_brightness. > > The current behaviour is to return 0 when the framebuffer is blanked. A > few drivers do that so I thought it was the norm; and the backlight > core doesn't do that by default (and just uses dev->props.brightness). > > It is not clear to me if that's the preferred behaviour. The > "backlight_get_brightness" function in backlight.h seems to suggest > that the current behaviour is correct, unless it is not supposed to be > used in the backlight_ops.get_brightness() callback. Then in that case > some other drivers get it wrong too. Several drivers get it wrong. You are supposed to provide get_brightness only when you read back a value from the HW, which is not the case here so just drop it is the right choice. Sam